From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E37ACC432BE for ; Wed, 1 Sep 2021 20:09:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD0FB61074 for ; Wed, 1 Sep 2021 20:09:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243543AbhIAUK4 (ORCPT ); Wed, 1 Sep 2021 16:10:56 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:46014 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242567AbhIAUKx (ORCPT ); Wed, 1 Sep 2021 16:10:53 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 2B52D1C0BA1; Wed, 1 Sep 2021 22:09:54 +0200 (CEST) Date: Wed, 1 Sep 2021 22:09:53 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Xiaoliang Yang , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 5.10 047/103] net: stmmac: add mutex lock to protect est parameters Message-ID: <20210901200953.GB8962@duo.ucw.cz> References: <20210901122300.503008474@linuxfoundation.org> <20210901122302.156121465@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NDin8bjvE/0mNLFQ" Content-Disposition: inline In-Reply-To: <20210901122302.156121465@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NDin8bjvE/0mNLFQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > [ Upstream commit b2aae654a4794ef898ad33a179f341eb610f6b85 ] >=20 > Add a mutex lock to protect est structure parameters so that the > EST parameters can be updated by other threads. Mainline version of the patch is okay, but I believe we need one more mutex_unlock in 5.10. Signed-off-by: Pavel Machek (CIP) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/= ethernet/stmicro/stmmac/stmmac_tc.c index 22c34474e617..639980306115 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -765,6 +765,7 @@ static int tc_setup_taprio(struct stmmac_priv *priv, priv->plat->tx_queues_to_use, priv->plat->rx_queues_to_use, fpe); if (ret && fpe) { + mutex_unlock(&priv->plat->est->lock); netdev_err(priv->dev, "failed to enable Frame Preemption\n"); return ret; } Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --NDin8bjvE/0mNLFQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYS/eEQAKCRAw5/Bqldv6 8iXtAKCmVub25dmgVRjdPVCSSwcoYfHMXwCglP2YuNR7kwoLoT4ksL7PVsmuQd4= =kCOO -----END PGP SIGNATURE----- --NDin8bjvE/0mNLFQ--