From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD22DC432BE for ; Wed, 1 Sep 2021 21:45:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 193A460041 for ; Wed, 1 Sep 2021 21:45:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 193A460041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DCFE283290; Wed, 1 Sep 2021 23:45:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="JbvqUfW5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B435D8327F; Wed, 1 Sep 2021 23:45:03 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7B3638325B for ; Wed, 1 Sep 2021 23:44:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 629A460041; Wed, 1 Sep 2021 21:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630532695; bh=KSTGF+RRCsAl3wZv4ZyJP/+84C959wHOZ9hRI/WU7KQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JbvqUfW5PkXLfJRLA8yx1NYzJquehq3n6z9AR8KARg+bv2xPAfzzAxw5u8pkjjFWW RA40dkk4xDkvfQImuluAs8Ze9L/AXozmmlJe1TCNHLBOMKTeU5BCff/l7T69Cn5EaT rj169DWytpAnRHDN94llatYZ1W8EGuuXzQwOWUc326yGJ+xVftoIboAR+TqcqFv+mX hgkQKuhIA4dRT57f02laO/+DRXPArtLcyqU5Gj05LviEOXjrFAni+RaLAVrD+phrHS FMnYWxc+0zXetVa8869qsjVWLseQtwSUaUigUCEaIaL7hg60w5qoAsyxkG0NUvp3HG TgurCbEN6F2AQ== Received: by pali.im (Postfix) id 2188BA46; Wed, 1 Sep 2021 23:44:53 +0200 (CEST) Date: Wed, 1 Sep 2021 23:44:52 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Tom Rini Cc: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?utf-8?B?QmVow7pu?= , u-boot@lists.denx.de Subject: Re: [PATCH 00/11] Reduce usage of timestamp macros Message-ID: <20210901214452.lxyy7cqjn6fkbghk@pali> References: <20210802131838.21097-1-pali@kernel.org> <20210901205909.GA23592@bill-the-cat> <20210901210545.4mbkattfc4m7nupl@pali> <20210901211706.GR858@bill-the-cat> <20210901212854.dabsvrkga4xdqxdf@pali> <20210901213357.GS858@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210901213357.GS858@bill-the-cat> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wednesday 01 September 2021 17:33:57 Tom Rini wrote: > On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Rohár wrote: > > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote: > > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > > > > > > > > > Including timestamp.h (either directly or transitionally) cause build > > > > > > system to recompile binaries at every 'make' run. This has disadvantage > > > > > > in U-Boot development as for every small change 'make' recompiles lot of > > > > > > other irrelevant files which were not touched / changed. > > > > > > > > > > > > This patch series eliminate transitional / indirect usage of > > > > > > timestamp.h by removing unneeded inclusion of header files, moving > > > > > > timestamp values from macros to global variables, etc... > > > > > > > > > > > > After these patches, U-Boot tools are not recompiled by every 'make' run, > > > > > > which decrease time for incremental U-Boot recompilation. > > > > > > > > > > > > Please test these patches, specially m68k and powerpc parts as I do not > > > > > > have any of these boards. > > > > > > > > > > > > Patch series depend on this patch (now marked as accepted): > > > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-pali@kernel.org/ > > > > > > > > > > > > Pali Rohár (11): > > > > > > Remove #include from files which do not need it > > > > > > Remove #include from files which do not need it > > > > > > efi_loader: Use directly version_string variable > > > > > > version: Move version_string[] from version.h to version_string.h > > > > > > m68k: mcf: Remove overloading version_string > > > > > > version: Put version_string[] variable into section > > > > > > .text_version_string > > > > > > powerpc: mpc: Put U-Boot version string at correct place by linker > > > > > > script > > > > > > version: Do not make version_string[] variable as a weak > > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > > > > > > version: Remove global macro U_BOOT_VERSION_STRING from version.h > > > > > > Remove including timestamp.h in version.h > > > > > > > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > > > > this fails to build for at least qemu-ppce500 and xtfpga. Over in > > > > > doc/develop/ci_testing.rst we document how to run a world build. Please > > > > > fix these build errors and re-submit, thanks. > > > > > > > > Already happened about month ago > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-pali@kernel.org/ > > > > > > > > As stated, following build command now passes: > > > > make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin > > > > > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... > > > > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 and > > this should be fixed above patch. At least I got similar error for > > MCR3000_defconfig with new gcc before that. > > > > But now after scrolling down I see that second xtfpga error > > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > > But seems that in this UI is error log truncated. I see only > > > > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA [00000000fe021584,00000000fe0215c7] overlaps section .u_boot_list LMA [00000000fe021584,00000000fe021e6b] > > > > Is there a way how to show full build log? And which defconfig and > > compiler is used? Because that error does not help me what is wrong > > here... > > That's the full error log, from the linker, I believe. It's the xtfpga > config for the xtensa architecture. It's one of the few that buildman > won't fetch a good toolchain for so you'll want to look at > tools/docker/Dockerfile and see we get it from > https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_64-2020.07-xtensa-dc233c-elf.tar.gz > if you don't have the CI builder container itself handy already. So this is the only other build which failed, right? I suspect that there is some other bug in xtfpga linker script, that it missed specifying wildcard sections and this change triggered it. I will try to look at it. It is pity that in above gitlab build log is missing full command which produced that error as in its arguments could be something interesting, like path to linker script or compile flags...