All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel J. Ogorchock" <djogorchock@gmail.com>
To: linux-input@vger.kernel.org
Cc: thunderbird2k@gmail.com, blaws05@gmail.com,
	benjamin.tissoires@redhat.com, jikos@kernel.org,
	Roderick.Colenbrander@sony.com, svv@google.com,
	s.jegen@gmail.com, carmueller@gmail.com,
	pgriffais@valvesoftware.com, hadess@hadess.net,
	pobrn@protonmail.com,
	"Daniel J. Ogorchock" <djogorchock@gmail.com>
Subject: [PATCH v15 09/16] HID: nintendo: patch hw version for userspace HID mappings
Date: Wed,  1 Sep 2021 19:42:29 -0400	[thread overview]
Message-ID: <20210901234236.3113-10-djogorchock@gmail.com> (raw)
In-Reply-To: <20210901234236.3113-1-djogorchock@gmail.com>

This patch sets the most significant bit of the hid hw version to allow
userspace to distinguish between this driver's input mappings vs. the
default hid mappings. This prevents breaking userspace applications that
use SDL2 for gamepad input, allowing them to distinguish the mappings
based on the version.

Signed-off-by: Daniel J. Ogorchock <djogorchock@gmail.com>
---
 drivers/hid/hid-nintendo.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
index c13fcd777fa21..f673a6903f04a 100644
--- a/drivers/hid/hid-nintendo.c
+++ b/drivers/hid/hid-nintendo.c
@@ -1426,6 +1426,15 @@ static int nintendo_hid_probe(struct hid_device *hdev,
 		goto err_wq;
 	}
 
+	/*
+	 * Patch the hw version of pro controller/joycons, so applications can
+	 * distinguish between the default HID mappings and the mappings defined
+	 * by the Linux game controller spec. This is important for the SDL2
+	 * library, which has a game controller database, which uses device ids
+	 * in combination with version as a key.
+	 */
+	hdev->version |= 0x8000;
+
 	ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW);
 	if (ret) {
 		hid_err(hdev, "HW start failed\n");
-- 
2.33.0


  parent reply	other threads:[~2021-09-01 23:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 23:42 [PATCH v15 00/16] HID: nintendo Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 01/16] HID: nintendo: add nintendo switch controller driver Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 02/16] HID: nintendo: add player led support Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 03/16] HID: nintendo: add power supply support Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 04/16] HID: nintendo: add home led support Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 05/16] HID: nintendo: add rumble support Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 06/16] HID: nintendo: improve subcommand reliability Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 07/16] HID: nintendo: send subcommands after receiving input report Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 08/16] HID: nintendo: reduce device removal subcommand errors Daniel J. Ogorchock
2021-09-01 23:42 ` Daniel J. Ogorchock [this message]
2021-09-01 23:42 ` [PATCH v15 10/16] HID: nintendo: set controller uniq to MAC Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 11/16] HID: nintendo: add support for charging grip Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 12/16] HID: nintendo: add support for reading user calibration Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 13/16] HID: nintendo: add IMU support Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 14/16] HID: nintendo: improve rumble performance and stability Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 15/16] HID: nintendo: ratelimit subcommands and rumble Daniel J. Ogorchock
2021-09-01 23:42 ` [PATCH v15 16/16] HID: nintendo: prevent needless queueing of the rumble worker Daniel J. Ogorchock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210901234236.3113-10-djogorchock@gmail.com \
    --to=djogorchock@gmail.com \
    --cc=Roderick.Colenbrander@sony.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=blaws05@gmail.com \
    --cc=carmueller@gmail.com \
    --cc=hadess@hadess.net \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=pgriffais@valvesoftware.com \
    --cc=pobrn@protonmail.com \
    --cc=s.jegen@gmail.com \
    --cc=svv@google.com \
    --cc=thunderbird2k@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.