From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF9BC432BE for ; Thu, 2 Sep 2021 00:39:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 413CD61074 for ; Thu, 2 Sep 2021 00:39:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 413CD61074 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EB9CE817D3; Thu, 2 Sep 2021 02:39:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="RxBLOazd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EE256811F7; Thu, 2 Sep 2021 02:39:41 +0200 (CEST) Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 991FA811F7 for ; Thu, 2 Sep 2021 02:39:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x629.google.com with SMTP id u1so143776plq.5 for ; Wed, 01 Sep 2021 17:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=QnZSJU/EZygE8p3fH0oLBBYwgbeFYi79SLHgfL86MT4=; b=RxBLOazds2kAXDg6v2qgEpDZ8SJRlXU1fZ8PCRstQtbSjG8vv9EB2mTn7FRKXHH00g nYS+dlS4duM9jfCuazVX5Hy9VwRtJwtqukOUJNiQfV/CpFZ+/PyHNVhAXzWRkDSGTMt5 pkw7q71az8CUFr/LX5rP9X6lYIrhYMK46yI9/vvT7mRKR3khYk0jYHCieRGodlpNfb5/ vSQrZi//P826Cgs/CWkc/tVELzblCT3W5Hxq+nMjm9WtcCUyxTiMICC16VnmTEN4OPpR qPgirA5ebathdw5D9DaJB6mw27SL7vzZG5dD4D6stzrW0aBPagexlKfasDRpfThP20IX h0Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=QnZSJU/EZygE8p3fH0oLBBYwgbeFYi79SLHgfL86MT4=; b=rHcemNTdH17RuO4xZGRbjt18kqCdRbWFm/3ainuuTr4e1N9uvhtRpZ1exxvBH3BSX2 W/yqdZfvmyLcXx7ouFIpBnrRxC9TGtA/O9DSuEcv5xxZtQPM5L2t+HV+48Lj4LUZEkju U1q/bHKw3aDKnx5Xfb4ZYZpLVqENvHk0a9pyvbgBXXtrn+9UwJg132vsEkPpBM4LBuE6 CV74NUqspnL6fhIQkz3F8uPLvjTODsDe8kXApl9Uy0seEqzG1T5McS+qWVSOl+w3fj8V 7WwyfWOvkIuStADDtRphDwao2hzLx3dm+8qSeefgzpXqpKgEGNnYSe+YHReI2HoFezDR /E1w== X-Gm-Message-State: AOAM530LzH2RguMUabIgWyNY2m+9c9i6EnReuWG8wNuN38tP7caTEyKT xspN19cKGE5GyXAKAERCICBFpQ== X-Google-Smtp-Source: ABdhPJwdmyz7uLTTNQ2izLnLdYHNzhw16JjK0ZJJvpqzOEaAZ9URBFbVEF+UbrQ77PC115D0K5ZDHw== X-Received: by 2002:a17:90a:bb04:: with SMTP id u4mr498943pjr.221.1630543174634; Wed, 01 Sep 2021 17:39:34 -0700 (PDT) Received: from laputa (p784a44f4.tkyea130.ap.so-net.ne.jp. [120.74.68.244]) by smtp.gmail.com with ESMTPSA id a23sm139908pfo.120.2021.09.01.17.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 17:39:34 -0700 (PDT) Date: Thu, 2 Sep 2021 09:39:30 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de, agraf@csgraf.de Subject: Re: [PATCH v3 5/5] test/py: efi_capsule: align with the syntax change of mkeficapsule Message-ID: <20210902003930.GA71098@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de, agraf@csgraf.de References: <20210831024659.53464-1-takahiro.akashi@linaro.org> <20210831024659.53464-6-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 31, 2021 at 08:10:31AM +0200, Heinrich Schuchardt wrote: > On 8/31/21 4:46 AM, AKASHI Takahiro wrote: > > Modify command line arguments at mkeficapsule as the syntax was > > a bit modified in the previous commit. > > > > Signed-off-by: AKASHI Takahiro > > --- > > test/py/tests/test_efi_capsule/conftest.py | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/test/py/tests/test_efi_capsule/conftest.py b/test/py/tests/test_efi_capsule/conftest.py > > index 6ad5608cd71c..8b5368c11abc 100644 > > --- a/test/py/tests/test_efi_capsule/conftest.py > > +++ b/test/py/tests/test_efi_capsule/conftest.py > > @@ -50,10 +50,10 @@ def efi_capsule_data(request, u_boot_config): > > check_call('cd %s; %s/tools/mkimage -f uboot_bin_env.its uboot_bin_env.itb' % > > (data_dir, u_boot_config.build_dir), > > shell=True) > > - check_call('cd %s; %s/tools/mkeficapsule --fit uboot_bin_env.itb --index 1 Test01' % > > + check_call('cd %s; %s/tools/mkeficapsule --index 1 --fit uboot_bin_env.itb Test01' % > > (data_dir, u_boot_config.build_dir), > > shell=True) > > - check_call('cd %s; %s/tools/mkeficapsule --raw u-boot.bin.new --index 1 Test02' % > > + check_call('cd %s; %s/tools/mkeficapsule --index 1 --raw u-boot.bin.new Test02' % > > (data_dir, u_boot_config.build_dir), > > shell=True) > > > > > > Should one of the tsts use a GUID (introduced in patch 4)? Good point. After adding an extra test, I found a bug :) uuid_parse() in libuuid is used to convert a string into a guid value, but uuid and guid have different formats of representation and we can't use the return value from uuid_parse() as it is. -Takahiro Akashi > Best regards > > Heinrich >