From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mLiWn-0002tx-J0 for mharc-grub-devel@gnu.org; Thu, 02 Sep 2021 04:56:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLiWm-0002tP-6n for grub-devel@gnu.org; Thu, 02 Sep 2021 04:56:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLiWk-0004wT-SU for grub-devel@gnu.org; Thu, 02 Sep 2021 04:56:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630573014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IFawiD6ZOvzb9u39gnQz2ZSETAHllYdwqovZp+jkJVQ=; b=KuxBFFMZNLhCe0ndQXJfI2BjJJYZD4udGQvaepkGAZB/Hbbezk79v+hSsbN808o5xJAo9S nu9d0uLeRV+ut2c3a2tLmbZ0Lcv5GU/3UoK8bkRH2c889W77YOe0TmnNB244y+lVZBhi9i KH7QB8jCWMKLnjV1cnXq80+X+LClmEE= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-IFsHdSc1O8KZBFhVk7oF1Q-1; Thu, 02 Sep 2021 04:56:52 -0400 X-MC-Unique: IFsHdSc1O8KZBFhVk7oF1Q-1 Received: by mail-ed1-f71.google.com with SMTP id b8-20020a056402350800b003c5e3d4e2a7so624277edd.2 for ; Thu, 02 Sep 2021 01:56:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=IFawiD6ZOvzb9u39gnQz2ZSETAHllYdwqovZp+jkJVQ=; b=C3xeUbYGEZCRZCpYS+7wJzbH4KslvpIL8u8P1yL1jbKGRsi5xGv93ihO8nDl0tJb0C MQGcBdTO26k8mqiEli7w+gEKozwgtQhyYodoTyIoTw5kiahjEyQPqfExf+BorBiYmzjc 1FpqXMU7ZvFUSerkLSZX9Li8QQSuDjtrpWXRYGE6OBb7QZnspH4BbONO/eLA9Iu9nIVh isNNu+ChwsXtMDDWOdBvgSFKYhaDWaiHI294bYkIu/6H/8/42IYlph0quKLeJ/WJJiP/ Unp/S2lIDiBNxykoTzGTZuWGUNoIu1MZiu+3rxosHMeS6VDemm3am3hQr4rq+/arVks3 SjEQ== X-Gm-Message-State: AOAM533Hv49GSm5vga/wQiAj6UqsUOBmDLqKLNw7SC02ipt10xhYQr96 XK1cCe7D6F2RzZKowrrsg6e3trjoAS6HtC7Bdz1sMafhecmbIIMYOZWkuK12+GPznKS7m0O1Wmi 69+I0HTxKCAk= X-Received: by 2002:a50:cac7:: with SMTP id f7mr2474281edi.302.1630573011820; Thu, 02 Sep 2021 01:56:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0JqCojqb3WtfeEM2jiZI3lZgA/i17lnShRoNJvjNTxrFFKLfkq0qrFg3B292BllbU8Qt2FQ== X-Received: by 2002:a50:cac7:: with SMTP id f7mr2474265edi.302.1630573011567; Thu, 02 Sep 2021 01:56:51 -0700 (PDT) Received: from omega.lan (ip4-46-39-172-19.cust.nbox.cz. [46.39.172.19]) by smtp.gmail.com with ESMTPSA id j24sm690571edj.56.2021.09.02.01.56.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 01:56:50 -0700 (PDT) Date: Thu, 2 Sep 2021 10:56:49 +0200 From: Carlos Maiolino To: Daniel Kiper Cc: Erwan Velu , grub-devel@gnu.org, Erwan Velu , javierm@redhat.com Subject: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock Message-ID: <20210902085649.zucibvxhnez2meys@omega.lan> References: <20210825133152.1165682-1-e.velu@criteo.com> <20210826132616.dhhiwdowapcolrdr@omega.lan> <20210830114850.kemzuknbe4nwzkip@omega.lan> <20210901124057.qqmqkjh7k3dkgnsv@tomti.i.net-space.pl> MIME-Version: 1.0 In-Reply-To: <20210901124057.qqmqkjh7k3dkgnsv@tomti.i.net-space.pl> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cmaiolino@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cmaiolino@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2021 08:56:56 -0000 On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > CC-ing Javier... > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > Hi. > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > > Good day list, > > > Le jeu. 26 août 2021 à 15:26, Carlos Maiolino <[1]cmaiolino@redhat.com> > > > a écrit : > > > > > > [..] > > > Thanks for spotting this! > > > > > > I'm adding the maintainers in CC. Carlos who commit the patch I'm > > > fixing, agreed on the content. > > > > I didn't test the patch itself yet, but I've reproduced the issue. I was quite > > sure I had tested this patch on a V4 fs, but looks like I miscalculated the > > sizing. Thanks again. I'll try to test the patch here asap. > > Did you test this patch? If yes may I add your Tested-by to it? Yup, patch works fine, just finished testing it, I was just trying to understand where/why I miscalculated the inode size on V4 filesystems, and the reason was the same why Erwan split the last/first members of inode v2/v3 in two different unused structs. Feel free to add to the patch: Tested-by: Carlos Maiolino > > Daniel > -- Carlos