From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED760C87FD4 for ; Thu, 2 Sep 2021 16:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 216336112E for ; Thu, 2 Sep 2021 16:07:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237074AbhIBQIo (ORCPT ); Thu, 2 Sep 2021 12:08:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234786AbhIBQIn (ORCPT ); Thu, 2 Sep 2021 12:08:43 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5550C061757 for ; Thu, 2 Sep 2021 09:07:44 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id 8so2461704pga.7 for ; Thu, 02 Sep 2021 09:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BGrVU98Zacn5uG81q99DxyUsWOrCnOhhT/dK37UsEiU=; b=lQfm8PKUgLZqfpgTk9CZI28oAthBMMxm9xTl2XYEBMCVut/D/XscAuELHGMabtiU7d r2FH9zrmKqXbJy4ol/w2QaFc1j7XV/o8NW4ubivUp4ALkp19LfVsupvUMlQANopLM2kw Y6zyDQRM8GOGvJO8BVMb/ni4OYK77TtzG+omQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BGrVU98Zacn5uG81q99DxyUsWOrCnOhhT/dK37UsEiU=; b=Vkh6I+4WiUxcogw+IZfw3mhR40iFOUNXXTR8DGU7YXcDCD9JyuSPeoGKjZBjvUbirf dtZZ1R7XFFap4QZJ+56Ekf5uyPEDDwr7sr7lVcGc+/jma6i6j3XOy4HDaCmjP7y99mHr ZvR04zrVVEXCMnz46/rNgPqr1rEYNVxlOAK0c9OF576wPyJztc4PCofgFf3yBmOnRxnu TfrsFvzM6/K8gvPZpp4DxPIS7dgkG1ytB7Ed79hILXTrylO5b+ljJNB8z8eek8Qc7IbG +ZJxPie9N7yoeqSVJnoRAeAPds1D5XbNsT2SVFdOPj2QQfbcLK2WhLI+VzAO/f69j79b 3x/w== X-Gm-Message-State: AOAM530E59jeIq4kQwYyTf82DEp5xSV3Bo1PuH5mqy7sxA4YFzGHc2gT HzinURUeX1FRqjz21jpXYVWvFg== X-Google-Smtp-Source: ABdhPJzNQZasCUlINaO1/WxTEUOJhLcP6KAhMypIpiLxI1BdOKXxkzuvOj3gnCdQv+9EZtpdl5jh+Q== X-Received: by 2002:a63:5413:: with SMTP id i19mr3942630pgb.297.1630598864267; Thu, 02 Sep 2021 09:07:44 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q22sm3111413pgn.67.2021.09.02.09.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:07:43 -0700 (PDT) Date: Thu, 2 Sep 2021 09:07:42 -0700 From: Kees Cook To: Keith Packard Cc: linux-kernel@vger.kernel.org, Abbott Liu , Alexander Sverdlin , Al Viro , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Arnd Bergmann , Bjorn Andersson , Florian Fainelli , Geert Uytterhoeven , Hartley Sweeten , Jens Axboe , Jian Cai , Joe Perches , Linus Walleij , linux-arm-kernel@lists.infradead.org, Maninder Singh , Manivannan Sadhasivam , Marc Zyngier , Masahiro Yamada , Mike Rapoport , Nick Desaulniers , Nick Desaulniers , Nicolas Pitre , Peter Zijlstra , Russell King , Thomas Gleixner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Valentin Schneider , Vaneet Narang , "Wolfram Sang (Renesas)" , YiFei Zhu , Keith Packard , linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK Message-ID: <202109020904.976207C@keescook> References: <20210902155429.3987201-1-keithp@keithp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210902155429.3987201-1-keithp@keithp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2021 at 08:54:26AM -0700, Keith Packard wrote: > Placing thread_info in the kernel stack leaves it vulnerable to stack > overflow attacks. This short series addresses that by using the > existing THREAD_INFO_IN_TASK infrastructure. Very cool! Thanks for working on this. If you want, you can refer to the KSPP bug for this too: https://github.com/KSPP/linux/issues/1 (Anyone want to do MIPS?) -Kees -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC204C87FCE for ; Thu, 2 Sep 2021 16:25:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F902611CB for ; Thu, 2 Sep 2021 16:10:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F902611CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F9t+1DguyLv881eGNRke/GCUb/KvxCpGtcGioiZ3me8=; b=dAS9jm09otW0ac j0EZtU3V3+AgJ9j4WKt/eXfkKbaG7apeGfQeanY6JLIUriigQdnM2XH0vjZKWYAhvdI0AQE8eAv+Y hOmeyYYRmMaBqX/E1w4ROvpt6NZQfGHi89sGaGe5jrNqU+Xlul5BwfIOSMErXuyT6Lr0WNTqircfq a4HeT1/5upfFhTekiScxkJBQzQpXkgkcKOOPnjDYGR87TZAC8NKDb3S8Hcrx97dqujkeCtsN3smeR 3As2Q+btsIWokfbehcgSsKzcosrUvxLXp5OAHPYps5Cotp2qnyc2Rzbvzsb+8FS1JTAIsxSWvdfEU lFEKDcNGeupo/wtuhy4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLpFs-009xSj-8o; Thu, 02 Sep 2021 16:07:56 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLpFl-009xRG-ML for linux-arm-kernel@lists.infradead.org; Thu, 02 Sep 2021 16:07:53 +0000 Received: by mail-pf1-x433.google.com with SMTP id 2so2007968pfo.8 for ; Thu, 02 Sep 2021 09:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BGrVU98Zacn5uG81q99DxyUsWOrCnOhhT/dK37UsEiU=; b=lQfm8PKUgLZqfpgTk9CZI28oAthBMMxm9xTl2XYEBMCVut/D/XscAuELHGMabtiU7d r2FH9zrmKqXbJy4ol/w2QaFc1j7XV/o8NW4ubivUp4ALkp19LfVsupvUMlQANopLM2kw Y6zyDQRM8GOGvJO8BVMb/ni4OYK77TtzG+omQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BGrVU98Zacn5uG81q99DxyUsWOrCnOhhT/dK37UsEiU=; b=LHf105mJKmx2TIao14YrBSbInMiFeix/CpFTugA3/eNglQkLF/wIb/NHTXVZfW3lby wvhRV+6fjZnXoHRo2/QzWCwWcSLIeUie+HGST/z+bcNpc6ao3Q4QQ+2sgKEw0LHVOB9Q BEsofhcwL6RQH7iHRwx8JdTxsyKpY7WteRpHeiz8YDrh02G+JNqqbdtfLysTR1dF+WKu k+ZLZmwsM906+WnXDHL5BO9+6jnnmxX2xLhKmB36tHiPC+dA9yh96QL0EMTUuMvLkq55 neicje59yQ0zFG/ih26iubWybr5DTm4TIPqNbIULSTvKIgBKIR+2MahiYdtOluNnN0dE ++PQ== X-Gm-Message-State: AOAM5303p6C0MQnaWFxsKCPmxWnPQrlwO/ZlAteaRbfSlYYT43TBsBj3 QHOOpTk4dV7KFyhr+iMlILrt7w== X-Google-Smtp-Source: ABdhPJzNQZasCUlINaO1/WxTEUOJhLcP6KAhMypIpiLxI1BdOKXxkzuvOj3gnCdQv+9EZtpdl5jh+Q== X-Received: by 2002:a63:5413:: with SMTP id i19mr3942630pgb.297.1630598864267; Thu, 02 Sep 2021 09:07:44 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q22sm3111413pgn.67.2021.09.02.09.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:07:43 -0700 (PDT) Date: Thu, 2 Sep 2021 09:07:42 -0700 From: Kees Cook To: Keith Packard Cc: linux-kernel@vger.kernel.org, Abbott Liu , Alexander Sverdlin , Al Viro , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Arnd Bergmann , Bjorn Andersson , Florian Fainelli , Geert Uytterhoeven , Hartley Sweeten , Jens Axboe , Jian Cai , Joe Perches , Linus Walleij , linux-arm-kernel@lists.infradead.org, Maninder Singh , Manivannan Sadhasivam , Marc Zyngier , Masahiro Yamada , Mike Rapoport , Nick Desaulniers , Nick Desaulniers , Nicolas Pitre , Peter Zijlstra , Russell King , Thomas Gleixner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Valentin Schneider , Vaneet Narang , "Wolfram Sang (Renesas)" , YiFei Zhu , Keith Packard , linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK Message-ID: <202109020904.976207C@keescook> References: <20210902155429.3987201-1-keithp@keithp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210902155429.3987201-1-keithp@keithp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_090749_780911_C9D07502 X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 02, 2021 at 08:54:26AM -0700, Keith Packard wrote: > Placing thread_info in the kernel stack leaves it vulnerable to stack > overflow attacks. This short series addresses that by using the > existing THREAD_INFO_IN_TASK infrastructure. Very cool! Thanks for working on this. If you want, you can refer to the KSPP bug for this too: https://github.com/KSPP/linux/issues/1 (Anyone want to do MIPS?) -Kees -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel