All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style
Date: Thu, 2 Sep 2021 09:04:59 -0700	[thread overview]
Message-ID: <20210902090459.33d98d8e@hermes.local> (raw)
In-Reply-To: <YTDythD/ZZPGWr5f@bricha3-MOBL.ger.corp.intel.com>

On Thu, 2 Sep 2021 16:50:14 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> On Thu, Sep 02, 2021 at 08:24:58AM -0700, Stephen Hemminger wrote:
> > On Thu, 2 Sep 2021 09:10:47 +0100
> > Bruce Richardson <bruce.richardson@intel.com> wrote:
> >   
> > > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote:  
> > > > This fixes most of the warnings from the Flake8 style checker.
> > > > The ones remaing are long lines (we allow > 79 characters)
> > > > and a line break warning.  The line break style changed in later
> > > > versions of PEP 8 and the tool is not updated.
> > > > 
> > > > https://www.flake8rules.com/rules/W503.html
> > > > 
> > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > > ---
> > > >  usertools/dpdk-devbind.py | 70 ++++++++++++++++++++++-----------------
> > > >  1 file changed, 39 insertions(+), 31 deletions(-)
> > > >    
> > > Thanks for the cleanup.
> > > 
> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>   
> > 
> > I don't use devbind (except in artifical testing), could someone with
> > hardware make sure that nothing changed here.  
> 
> I didn't go testing with all possible options and inputs, but basic
> operation for binding unbinding devices and giving error messages for
> invalid device names works fine with this patch applied.
> 
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>

Thanks

  reply	other threads:[~2021-09-02 16:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 21:27 [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style Stephen Hemminger
2021-09-02  8:10 ` Bruce Richardson
2021-09-02 15:24   ` Stephen Hemminger
2021-09-02 15:50     ` Bruce Richardson
2021-09-02 16:04       ` Stephen Hemminger [this message]
2021-10-25 20:21         ` Thomas Monjalon
2021-09-02 10:32 ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210902090459.33d98d8e@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.