From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mLkzB-0005Mn-Uq for mharc-grub-devel@gnu.org; Thu, 02 Sep 2021 07:34:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLkz9-0005HD-MK for grub-devel@gnu.org; Thu, 02 Sep 2021 07:34:23 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:37111) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1mLkz8-0004dP-40 for grub-devel@gnu.org; Thu, 02 Sep 2021 07:34:23 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:50358 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2114170AbhIBLeJ (ORCPT ); Thu, 2 Sep 2021 13:34:09 +0200 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Thu, 2 Sep 2021 13:33:58 +0200 From: Daniel Kiper To: Carlos Maiolino Cc: Erwan Velu , grub-devel@gnu.org, Erwan Velu , javierm@redhat.com Subject: Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock Message-ID: <20210902113358.hk4d52v3dowkgwt3@tomti.i.net-space.pl> References: <20210825133152.1165682-1-e.velu@criteo.com> <20210826132616.dhhiwdowapcolrdr@omega.lan> <20210830114850.kemzuknbe4nwzkip@omega.lan> <20210901124057.qqmqkjh7k3dkgnsv@tomti.i.net-space.pl> <20210902085649.zucibvxhnez2meys@omega.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210902085649.zucibvxhnez2meys@omega.lan> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2021 11:34:24 -0000 On Thu, Sep 02, 2021 at 10:56:49AM +0200, Carlos Maiolino wrote: > On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > > CC-ing Javier... > > > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > > Hi. > > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > > > Good day list, > > > > Le jeu. 26 août 2021 à 15:26, Carlos Maiolino <[1]cmaiolino@redhat.com> > > > > a écrit : > > > > > > > > [..] > > > > Thanks for spotting this! > > > > > > > > I'm adding the maintainers in CC. Carlos who commit the patch I'm > > > > fixing, agreed on the content. > > > > > > I didn't test the patch itself yet, but I've reproduced the issue. I was quite > > > sure I had tested this patch on a V4 fs, but looks like I miscalculated the > > > sizing. Thanks again. I'll try to test the patch here asap. > > > > Did you test this patch? If yes may I add your Tested-by to it? > > Yup, patch works fine, just finished testing it, I was just trying to understand > where/why I miscalculated the inode size on V4 filesystems, and the reason was > the same why Erwan split the last/first members of inode v2/v3 in two different > unused structs. > > Feel free to add to the patch: > > Tested-by: Carlos Maiolino Cool! Thanks a lot! Daniel