From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EDFBC432BE for ; Thu, 2 Sep 2021 14:44:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32BE36108E for ; Thu, 2 Sep 2021 14:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345595AbhIBOpf (ORCPT ); Thu, 2 Sep 2021 10:45:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:44248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345374AbhIBOpZ (ORCPT ); Thu, 2 Sep 2021 10:45:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5CB33610CC; Thu, 2 Sep 2021 14:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630593866; bh=QSkZv2N1yXVzhucXRsxaUE7H3wr+r7TSYHXNxXgC910=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oDOYYkTybQvl1z6Luah3ixvfoCcvxrLI1lfGneZBWECIuC7las8tHY4sx9jFAowup mtthFD4gHpW2p17sYrm7Mgh85X7CvTV5On0a1IRI0cvEcJzmLbz7pvkvXoeAWswxyN gLaJLeqUgQ7jJqx3ynHZEPF46lNi27sb31qr1nVxWHR2xRApLthfDAGhYYTlgVaHNB maEoFyoOpTZfV7rpXhEPr77U+Q2vRZfu5GsC10TzD8Tvh6rKqlxzJ9Uacomw+ZmuWN UfQpwJeKIZb4wX6C9HQN7WrqESL+pG6RY7QBb2q4bMSbonZF6O6JJnqgzOosm9DMwq 7PhKumonfatXQ== Date: Thu, 2 Sep 2021 15:43:54 +0100 From: Mark Brown To: Alejandro Tafalla Cc: Andy Shevchenko , Liam Girdwood , "alsa-devel@alsa-project.org" , Rob Herring , Jaroslav Kysela , Takashi Iwai , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND 1/2] ASoC: max98927: Handle reset gpio when probing i2c Message-ID: <20210902144354.GD11164@sirena.org.uk> References: <20210829170019.384632-1-atafalla@dnyon.com> <20210829170019.384632-2-atafalla@dnyon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NtwzykIc2mflq5ck" Content-Disposition: inline In-Reply-To: X-Cookie: Famous last words: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NtwzykIc2mflq5ck Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 30, 2021 at 12:13:41AM +0200, Alejandro Tafalla wrote: > On Sun, Aug 29, 2021 at 11:22:35PM +0300, Andy Shevchenko wrote: > > > + struct gpio_desc *reset_gpio; > > Why? Are you using it outside of ->probe()? > No, I'll delete it and use a local variable. It can be good to reassert reset when unloading the driver in order to ensure that the device isn't active. It doesn't really matter though. --NtwzykIc2mflq5ck Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEw4yoACgkQJNaLcl1U h9DWrAgAg56iA1Au+XNyIyNCXB0VXn2oIgAwnxeXEjv3PKrw4YE0fW7dcbvywDnr 8Fs2PMIw09wFpzzoSzAQCNGN8Ts3OeiL8QFHnsOQeeyIzSkuOviiBrOWDtuCfx/j 0XXcxoH4ODxf0faKlbCGHQ6LdBgvsSeQiU3ExLjqJHYusxXbXUdRJ8XxIyhDC5tI +7KZOK7azIuJxSJrfYJ9aIlHvMmkCS9o/OpynCwkrwZwAh47+XyNSR6mn3pgiEoS Q8+WJChvT1kQ/XdYHo4GigjZIVXF0hUeA0GJJUoIdbJKl7O+8YLlOH0MDh8i0isX iTLYJ+8bqv+F8ONYPxTXcdlw4pcYdQ== =IJLZ -----END PGP SIGNATURE----- --NtwzykIc2mflq5ck-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 583D1C432BE for ; Thu, 2 Sep 2021 14:45:32 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53950610CC for ; Thu, 2 Sep 2021 14:45:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 53950610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0F0961757; Thu, 2 Sep 2021 16:44:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0F0961757 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1630593929; bh=QSkZv2N1yXVzhucXRsxaUE7H3wr+r7TSYHXNxXgC910=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vOYFibSYTtDs7WZPgZgaK/TIgroscCUfBygfPBOKBCYyeEakQyOnAvxZb65fEp4vs gW0B1/Cz1bUwWJnVR4gQ5kpBLoXyfgyUZBqXoVdtnLOozuZRXKQv4iQ4ZbVE2Qwlof JFd6PU2BqKDDLbSXAJGX5omzhgpsdPKrOfjVDuLo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9ACD9F8025B; Thu, 2 Sep 2021 16:44:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 00CBDF80269; Thu, 2 Sep 2021 16:44:35 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 89AEBF80125 for ; Thu, 2 Sep 2021 16:44:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 89AEBF80125 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oDOYYkTy" Received: by mail.kernel.org (Postfix) with ESMTPSA id 5CB33610CC; Thu, 2 Sep 2021 14:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630593866; bh=QSkZv2N1yXVzhucXRsxaUE7H3wr+r7TSYHXNxXgC910=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oDOYYkTybQvl1z6Luah3ixvfoCcvxrLI1lfGneZBWECIuC7las8tHY4sx9jFAowup mtthFD4gHpW2p17sYrm7Mgh85X7CvTV5On0a1IRI0cvEcJzmLbz7pvkvXoeAWswxyN gLaJLeqUgQ7jJqx3ynHZEPF46lNi27sb31qr1nVxWHR2xRApLthfDAGhYYTlgVaHNB maEoFyoOpTZfV7rpXhEPr77U+Q2vRZfu5GsC10TzD8Tvh6rKqlxzJ9Uacomw+ZmuWN UfQpwJeKIZb4wX6C9HQN7WrqESL+pG6RY7QBb2q4bMSbonZF6O6JJnqgzOosm9DMwq 7PhKumonfatXQ== Date: Thu, 2 Sep 2021 15:43:54 +0100 From: Mark Brown To: Alejandro Tafalla Subject: Re: [PATCH RESEND 1/2] ASoC: max98927: Handle reset gpio when probing i2c Message-ID: <20210902144354.GD11164@sirena.org.uk> References: <20210829170019.384632-1-atafalla@dnyon.com> <20210829170019.384632-2-atafalla@dnyon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NtwzykIc2mflq5ck" Content-Disposition: inline In-Reply-To: X-Cookie: Famous last words: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Takashi Iwai , Liam Girdwood , Andy Shevchenko , Rob Herring X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --NtwzykIc2mflq5ck Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 30, 2021 at 12:13:41AM +0200, Alejandro Tafalla wrote: > On Sun, Aug 29, 2021 at 11:22:35PM +0300, Andy Shevchenko wrote: > > > + struct gpio_desc *reset_gpio; > > Why? Are you using it outside of ->probe()? > No, I'll delete it and use a local variable. It can be good to reassert reset when unloading the driver in order to ensure that the device isn't active. It doesn't really matter though. --NtwzykIc2mflq5ck Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEw4yoACgkQJNaLcl1U h9DWrAgAg56iA1Au+XNyIyNCXB0VXn2oIgAwnxeXEjv3PKrw4YE0fW7dcbvywDnr 8Fs2PMIw09wFpzzoSzAQCNGN8Ts3OeiL8QFHnsOQeeyIzSkuOviiBrOWDtuCfx/j 0XXcxoH4ODxf0faKlbCGHQ6LdBgvsSeQiU3ExLjqJHYusxXbXUdRJ8XxIyhDC5tI +7KZOK7azIuJxSJrfYJ9aIlHvMmkCS9o/OpynCwkrwZwAh47+XyNSR6mn3pgiEoS Q8+WJChvT1kQ/XdYHo4GigjZIVXF0hUeA0GJJUoIdbJKl7O+8YLlOH0MDh8i0isX iTLYJ+8bqv+F8ONYPxTXcdlw4pcYdQ== =IJLZ -----END PGP SIGNATURE----- --NtwzykIc2mflq5ck--