From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA94C432BE for ; Thu, 2 Sep 2021 12:47:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26EE561057 for ; Thu, 2 Sep 2021 12:47:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344733AbhIBMsV (ORCPT ); Thu, 2 Sep 2021 08:48:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:49598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344474AbhIBMsT (ORCPT ); Thu, 2 Sep 2021 08:48:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 41A4E60F4B; Thu, 2 Sep 2021 12:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630586840; bh=+EA3TGY+wk4s7qcMYWQyoSQZEnBOtgNwQlNF0Odv+k4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hopQzbzFq2LHkCUVnIksl7xgexrg0zpDMbTVxtztWjqL8w1B47FrcuWSUxSC+MUoU CnRJiyJcY6dv4OZwHsDN2U1ZNNrXz3nlMvhN08TuXrfUzOc50wcIDk649oLYVjAAHa g4QW+FuCn6sK59odqJMu6d2KhXLkJl1xvPZ9Tc1ElX7rlxQfmtPIr0j8tgra8eENLo JfRBn+ZoXR6dR3U1qHf6qcqPBZJV1gESfRPxpB0u5Pyx7cWY/nIRVW6pLg0nA7SoKz HlqXcXwGmRZn/nYHXtyrje/feHuasVValKubXSycGKbqkSDGtvZDUNoo/Kz8FLeGW/ Z+GWBHWZXzRkg== Date: Thu, 2 Sep 2021 14:47:16 +0200 From: Mauro Carvalho Chehab To: Greg Kroah-Hartman Cc: Lee Jones , linuxarm@huawei.com, mauro.chehab@huawei.com, Arnd Bergmann , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: hi6421-spmi-pmic: cleanup drvdata Message-ID: <20210902144716.661e183f@coco.lan> In-Reply-To: References: <6959a4b11cb840aaae8d144889bb7b4899c3b335.1630583284.git.mchehab+huawei@kernel.org> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, 2 Sep 2021 14:04:55 +0200 Greg Kroah-Hartman escreveu: > On Thu, Sep 02, 2021 at 01:48:11PM +0200, Mauro Carvalho Chehab wrote: > > There are lots of fields at struct hi6421_spmi_pmic that aren't > > used. In a matter of fact, only regmap is needed. > > > > So, drop the struct as a hole, and set just the regmap as > > the drvdata. > > > > While here, add a missing dot at the Huawei's copyrights. > > What "missing dot"? I do not see any such change in this patch :( Probably moved to some other patch during the dozens of e-mails that this patch series suffered. I'll resend this patch without this comment. Thanks, Mauro