All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 04/11] tests/kms_big_fb: Use igt_plane_has_rotation()
Date: Thu,  2 Sep 2021 19:45:01 +0300	[thread overview]
Message-ID: <20210902164508.20104-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20210902164508.20104-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Use igt_plane_has_rotation() instead of the manual
"if there's no rotation prop -> only 0 dgree is supported"
conclusion.

And let's also get rid of the atomic vs. 0/270 degree rotation
check. I think I added this to avoid the test failing since
we can't do the TEST_ONLY probe withoiut atomic. With the
unsupported rotations filtered out ahead of time we should
never get into that situation.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_big_fb.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b988a092771a..092cbc6846fe 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -323,14 +323,7 @@ static bool test_plane(data_t *data)
 	if (!igt_plane_has_format_mod(plane, data->format, data->modifier))
 		return false;
 
-	if (data->rotation != IGT_ROTATION_0 &&
-	    !igt_plane_has_prop(plane, IGT_PLANE_ROTATION))
-		return false;
-
-	/* FIXME need atomic on i965/g4x */
-	if (data->rotation != IGT_ROTATION_0 &&
-	    data->rotation != IGT_ROTATION_180 &&
-	    !data->display.is_atomic)
+	if (!igt_plane_has_rotation(plane, data->rotation))
 		return false;
 
 	if (igt_plane_has_prop(plane, IGT_PLANE_ROTATION))
-- 
2.31.1

  parent reply	other threads:[~2021-09-02 16:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 16:44 [igt-dev] [PATCH i-g-t 00/11] kms: Clean up the supported rotations mess Ville Syrjala
2021-09-02 16:44 ` [igt-dev] [PATCH i-g-t 01/11] lib/kms: Add igt_plane_has_rotation() Ville Syrjala
2021-09-02 16:44 ` [igt-dev] [PATCH i-g-t 02/11] tests/kms_rotation_crc: Use igt_plane_has_rotation() Ville Syrjala
2021-09-09 14:59   ` [igt-dev] [PATCH i-g-t v2 02/12] " Ville Syrjala
2021-09-02 16:45 ` [igt-dev] [PATCH i-g-t 03/11] tests/kms_plane_scaling: " Ville Syrjala
2021-09-02 16:45 ` Ville Syrjala [this message]
2021-09-02 16:45 ` [igt-dev] [PATCH i-g-t 05/11] tests/kms_big_fb: Use igt_has_drm_cap() Ville Syrjala
2021-09-02 16:45 ` [igt-dev] [PATCH i-g-t 06/11] tests/kms_big_fb: Move batch creation into lower level functions Ville Syrjala
2021-09-02 16:45 ` [igt-dev] [PATCH i-g-t 07/11] tests/kms_big_fb: Move format/modifier checks lower Ville Syrjala
2021-09-02 16:45 ` [igt-dev] [PATCH i-g-t 08/11] tests/kms_big_fb: Nuke the stride/format overrides Ville Syrjala
2021-09-02 16:45 ` [igt-dev] [PATCH i-g-t 09/11] tests/kms_big_fb: Check whether the rotation is supposed in the async flip test Ville Syrjala
2021-09-02 16:45 ` [igt-dev] [PATCH i-g-t 10/11] tests/kms_plane: Abstract single vs. multiple crsc better Ville Syrjala
2021-09-02 16:45 ` [igt-dev] [PATCH i-g-t 11/11] tests/kms_plane: Use single colors during extended test Ville Syrjala
2021-09-02 17:48 ` [igt-dev] ✓ Fi.CI.BAT: success for kms: Clean up the supported rotations mess Patchwork
2021-09-02 21:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210902164508.20104-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.