From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C04EC83026 for ; Thu, 2 Sep 2021 16:55:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2382B60698 for ; Thu, 2 Sep 2021 16:55:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346450AbhIBQ4U (ORCPT ); Thu, 2 Sep 2021 12:56:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346378AbhIBQ4N (ORCPT ); Thu, 2 Sep 2021 12:56:13 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 846ECC061575; Thu, 2 Sep 2021 09:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rzf/6LcMzbI/PQP7yFlRIA7pmDSDhpmLqpTRt4zcusM=; b=KA0wsFCq85MvWpCbZrfWAzFK9 DFF3VTTxKeQwwxkQ3ZwEssNR7QluZij19whJHnhW+i+XfQ79kjrQW4hMhY/bF/TXx5/kvN/OjBCkW +7bkjwNzX/hrFMk51unl46AAG2zLcUlGeyITeTNUFDf5Z9XFTxuqFPnybr7P5Ynmc54aJAoJbpZFN ILRTPWqJZuM48e2TqGNBsnA9KyAItSgKjTcW5HmDJDaPybw9R+7waM4Cq/AOGxBy8A9C0cPvr8+b1 nRMn1a+G0/6zKfjGyz7N0MhaOhkAjYqVhiIel9nMuGLmM+/j0YksZAQPlDXPzu4Yhw7ZzFrOhLbMO 5iPUXz2Vg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48096) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLpzI-0001iR-BC; Thu, 02 Sep 2021 17:54:52 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1mLpzH-00081q-Ns; Thu, 02 Sep 2021 17:54:51 +0100 Date: Thu, 2 Sep 2021 17:54:51 +0100 From: "Russell King (Oracle)" To: Kees Cook Cc: Keith Packard , linux-kernel@vger.kernel.org, Abbott Liu , Alexander Sverdlin , Al Viro , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Arnd Bergmann , Bjorn Andersson , Florian Fainelli , Geert Uytterhoeven , Hartley Sweeten , Jens Axboe , Jian Cai , Joe Perches , Linus Walleij , linux-arm-kernel@lists.infradead.org, Maninder Singh , Manivannan Sadhasivam , Marc Zyngier , Masahiro Yamada , Mike Rapoport , Nick Desaulniers , Nick Desaulniers , Nicolas Pitre , Peter Zijlstra , Thomas Gleixner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Valentin Schneider , Vaneet Narang , "Wolfram Sang (Renesas)" , YiFei Zhu , Keith Packard , linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK Message-ID: <20210902165451.GJ22278@shell.armlinux.org.uk> References: <20210902155429.3987201-1-keithp@keithp.com> <202109020904.976207C@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202109020904.976207C@keescook> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2021 at 09:07:42AM -0700, Kees Cook wrote: > On Thu, Sep 02, 2021 at 08:54:26AM -0700, Keith Packard wrote: > > Placing thread_info in the kernel stack leaves it vulnerable to stack > > overflow attacks. This short series addresses that by using the > > existing THREAD_INFO_IN_TASK infrastructure. > > Very cool! Thanks for working on this. If you want, you can refer to the > KSPP bug for this too: > https://github.com/KSPP/linux/issues/1 Not so fast. It's buggy. I've rejected this "solution" before. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2147C83026 for ; Thu, 2 Sep 2021 16:57:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A065E61041 for ; Thu, 2 Sep 2021 16:57:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A065E61041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k6Th3Eav3PLppwrwA5hUieige/D9pfO0QY7H6DxF44A=; b=yLfuoNpjgSqILi 0GiG2AbBUkiN+uq+TzhBkmHkOHSiLm5GU425LRCRYa697NfSWlEIE8rjOe6GwPxk4CLrHLeCuwcRU MNdkBRbBqE77pvI+Aylu66LqETs83DCPi5jDnN6gB5G/bPeAMClI0wrx/Ust5sYgYeDo0T6wqe4Po hXr37w8zWB962TJGPktAPQqM5LGsm33ENfEroRBwskvjkSHlqNveq8mIJ+ZyovUr6eXmLZ3YucVAc cqn3cUH3pkEr5ct4lG84e8jOGDyuCyHLNxM2L/slU/srx0u4SzaabKhvFDhDos0w6AO7+FxkgnwAH RF+gkZTqToJUfEPg7afQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLpzU-00A2yv-V1; Thu, 02 Sep 2021 16:55:05 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLpzR-00A2xR-Be for linux-arm-kernel@lists.infradead.org; Thu, 02 Sep 2021 16:55:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rzf/6LcMzbI/PQP7yFlRIA7pmDSDhpmLqpTRt4zcusM=; b=KA0wsFCq85MvWpCbZrfWAzFK9 DFF3VTTxKeQwwxkQ3ZwEssNR7QluZij19whJHnhW+i+XfQ79kjrQW4hMhY/bF/TXx5/kvN/OjBCkW +7bkjwNzX/hrFMk51unl46AAG2zLcUlGeyITeTNUFDf5Z9XFTxuqFPnybr7P5Ynmc54aJAoJbpZFN ILRTPWqJZuM48e2TqGNBsnA9KyAItSgKjTcW5HmDJDaPybw9R+7waM4Cq/AOGxBy8A9C0cPvr8+b1 nRMn1a+G0/6zKfjGyz7N0MhaOhkAjYqVhiIel9nMuGLmM+/j0YksZAQPlDXPzu4Yhw7ZzFrOhLbMO 5iPUXz2Vg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48096) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLpzI-0001iR-BC; Thu, 02 Sep 2021 17:54:52 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1mLpzH-00081q-Ns; Thu, 02 Sep 2021 17:54:51 +0100 Date: Thu, 2 Sep 2021 17:54:51 +0100 From: "Russell King (Oracle)" To: Kees Cook Cc: Keith Packard , linux-kernel@vger.kernel.org, Abbott Liu , Alexander Sverdlin , Al Viro , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Arnd Bergmann , Bjorn Andersson , Florian Fainelli , Geert Uytterhoeven , Hartley Sweeten , Jens Axboe , Jian Cai , Joe Perches , Linus Walleij , linux-arm-kernel@lists.infradead.org, Maninder Singh , Manivannan Sadhasivam , Marc Zyngier , Masahiro Yamada , Mike Rapoport , Nick Desaulniers , Nick Desaulniers , Nicolas Pitre , Peter Zijlstra , Thomas Gleixner , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Valentin Schneider , Vaneet Narang , "Wolfram Sang (Renesas)" , YiFei Zhu , Keith Packard , linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/2]: ARM: Enable THREAD_INFO_IN_TASK Message-ID: <20210902165451.GJ22278@shell.armlinux.org.uk> References: <20210902155429.3987201-1-keithp@keithp.com> <202109020904.976207C@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202109020904.976207C@keescook> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_095501_453764_C3DD45FC X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 02, 2021 at 09:07:42AM -0700, Kees Cook wrote: > On Thu, Sep 02, 2021 at 08:54:26AM -0700, Keith Packard wrote: > > Placing thread_info in the kernel stack leaves it vulnerable to stack > > overflow attacks. This short series addresses that by using the > > existing THREAD_INFO_IN_TASK infrastructure. > > Very cool! Thanks for working on this. If you want, you can refer to the > KSPP bug for this too: > https://github.com/KSPP/linux/issues/1 Not so fast. It's buggy. I've rejected this "solution" before. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel