From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC01C433F5 for ; Thu, 2 Sep 2021 17:51:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3110D610CC for ; Thu, 2 Sep 2021 17:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346640AbhIBRwo (ORCPT ); Thu, 2 Sep 2021 13:52:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbhIBRwj (ORCPT ); Thu, 2 Sep 2021 13:52:39 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F26CC061575 for ; Thu, 2 Sep 2021 10:51:41 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id d5so1899562pjx.2 for ; Thu, 02 Sep 2021 10:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w3erfZ98bTWqGgs/cNXgGGDKhIj2fFDLW/9VUyS1D5Y=; b=HZ7R/ImWm3dIk5AWdIoBe7M/Tf9kkV2hX8X7BbK3WRd+oqyAyirxcg45CG9Sbx4TOj GRXBLi1xZEYDWDLp5O/EcKEG5ADd1ZSr3BK5GJGWg5XuZlXzNNB1+gX7f5I+x32N5T5x 8tKPjhHhlMV7GqVHaimGepx+DA7Jl2U/cMWSMoJj+z4qa++fLBiiQ5K2YqsMe5XU02ON Vd2MOeOr1UvL+7rkACj/mPZMbmjoTQirbftthXhutyjgkk8gg/zuS8OuvlU4RwJEz+mn FT6DP0/Q0puMUucUngQUovv2gBNmoQBlP48H3W3HmnoaNS2n4NsIoxAbvRNUSlPxzEMP 28pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w3erfZ98bTWqGgs/cNXgGGDKhIj2fFDLW/9VUyS1D5Y=; b=sHOtcBIsQJnJFuH+hVop9dtoVxR54XHpV8oPgO5jtKChpgJQMlVqUqBsuFFZTF8NXA 6kcM0iy8UrsjVeCwEdHQENQlcF6/R3IIoMz9zAQaqoDBK67+5eufwVnjt1QY6JQUqL+k c7qh5jBCtF9YaVrrU/Cf9nJlo/MCjjo72OFOM9MRoI3XAJ91/B1tmPMZsteKDL6EsSbo j61KoMa1KD5I5SSE6S9lEBzhQzkYC7lY3JOh7Wmxw5zFRolD0NZRIGEw3VElYFpx6KZc 39hvY5RW5fszqZUh6MtH3XmhWQeqKKEK2/g2Skv/Uzhoizxnr75Ah6KkFaWUHVfwzRkN 0Aww== X-Gm-Message-State: AOAM532e9vm0a5PBgYjKj6/7Gp6GyuvmDAu/dU43pW9iIbKV6aewYdBn pxiZa3jtbAMepv+YJqg8WBaiKw== X-Google-Smtp-Source: ABdhPJxz2D16swtH7T1EhCN8vRgROTUqu5EuC82EPgq1tZIkVYwUellFUFh0WQOrOIZKA41y3B4yMA== X-Received: by 2002:a17:90a:b785:: with SMTP id m5mr5306630pjr.213.1630605100717; Thu, 02 Sep 2021 10:51:40 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id x13sm2973468pjh.30.2021.09.02.10.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 10:51:39 -0700 (PDT) Date: Thu, 2 Sep 2021 11:51:37 -0600 From: Mathieu Poirier To: Qi Liu Cc: suzuki.poulose@arm.com, mike.leach@linaro.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com Subject: Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device Message-ID: <20210902175137.GC1078000@p14s> References: <20210719111737.47891-1-liuqi115@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719111737.47891-1-liuqi115@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 19, 2021 at 07:17:35PM +0800, Qi Liu wrote: > This patchset add support for SMB(System Memory Buffer) device, SMB > obtains CPU instructions from Coresight ETM device and stores these > messages in system memory. > SMB is developed by Ultrasoc technology, which is acquired by Siemens, > and we still use "Ultrasoc" to name document and driver. > > Change since RFC: > - Move ultrasoc driver to drivers/hwtracing/coresight. > - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in > basic tracing function. > - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core. > - Address the comments from Mathieu and Suzuki. > - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html > > Qi Liu (2): > Documentation: tracing: Documentation for ultrasoc SMB drivers > coresight: ultrasoc: Add System Memory Buffer driver > > .../trace/coresight/ultrasoc-trace.rst | 193 +++++ > MAINTAINERS | 7 + > drivers/hwtracing/coresight/Kconfig | 3 + > drivers/hwtracing/coresight/Makefile | 2 + > drivers/hwtracing/coresight/ultrasoc/Kconfig | 12 + > drivers/hwtracing/coresight/ultrasoc/Makefile | 6 + > .../coresight/ultrasoc/ultrasoc-smb.c | 722 ++++++++++++++++++ > .../coresight/ultrasoc/ultrasoc-smb.h | 142 ++++ > 8 files changed, 1087 insertions(+) I have started to review this set. Comments will follow shortly. Thanks, Mathieu > create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h > > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A183FC433EF for ; Thu, 2 Sep 2021 17:54:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 685566054E for ; Thu, 2 Sep 2021 17:54:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 685566054E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yhgzvIfPbX2ZPmrojHzg1n27H1oXxBLmP/A1zgrn1qE=; b=tk90p560OzU6XH ultMwhq9NSeGKim0jCke74IW/1r69c0VRF/evkWlbH0bJHkabt8+p6Xn0tOSmUcociIMPURgrz0m7 8qah+tQOxEFNFVEKy7lrv7pBpbBwPEWX5j742Hip7Ivk2OPYIA0uuryUTeV3HzOtWRjzWuXVByKZr kwD34+P1cTOvBftfPp29nZSgvR4qnPPq6LkLcbRTyclLUwCcAe95iacdY5huHwfZ0tDBsYoLO8lsk xq0fXovR3M/c9WsugE3wAVz6ixHZta4blsKQfpG/8Z0ElTJ/p7n/qeWJlDoPxn1HAVz4YYa8FMjUU MzU12pcfEjDQFe9pA/wA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLqsR-00ACdZ-EQ; Thu, 02 Sep 2021 17:51:52 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLqsI-00ACbp-52 for linux-arm-kernel@lists.infradead.org; Thu, 02 Sep 2021 17:51:44 +0000 Received: by mail-pj1-x1036.google.com with SMTP id u13-20020a17090abb0db0290177e1d9b3f7so2022864pjr.1 for ; Thu, 02 Sep 2021 10:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w3erfZ98bTWqGgs/cNXgGGDKhIj2fFDLW/9VUyS1D5Y=; b=HZ7R/ImWm3dIk5AWdIoBe7M/Tf9kkV2hX8X7BbK3WRd+oqyAyirxcg45CG9Sbx4TOj GRXBLi1xZEYDWDLp5O/EcKEG5ADd1ZSr3BK5GJGWg5XuZlXzNNB1+gX7f5I+x32N5T5x 8tKPjhHhlMV7GqVHaimGepx+DA7Jl2U/cMWSMoJj+z4qa++fLBiiQ5K2YqsMe5XU02ON Vd2MOeOr1UvL+7rkACj/mPZMbmjoTQirbftthXhutyjgkk8gg/zuS8OuvlU4RwJEz+mn FT6DP0/Q0puMUucUngQUovv2gBNmoQBlP48H3W3HmnoaNS2n4NsIoxAbvRNUSlPxzEMP 28pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w3erfZ98bTWqGgs/cNXgGGDKhIj2fFDLW/9VUyS1D5Y=; b=I9pljgvgP5T5Cr9ZxbqWCPOtUlJbSAmqsHKCTVZKZfgZjatfrrFFJD+3LZ60rhb72v koXGR4UJSKeHs6t5qelfJYqsOeCQ4dzNmhkPCUqi1KVZM7V0UFirwyuSzyJ3G6KiicsV 8vdi24FLTU3nMV6XMTGoag/i9VRrrxdtPOhFaA19B0MWOJ7XLcorBm8LcTcxuqEoNRid c7dgbg4nWpg5AgxNApzAoEg1X8l9bZp24DPTLSzFkGeCX4cvikdoEYaXjd66e/cRQnT0 xv/z+ZwL4tkouqw4LXJIFPXVynwrEF3QRI8PZrIVnJyuchBJCiQzOVbO0FZTzJIlYLq6 5O7g== X-Gm-Message-State: AOAM530EO6ZcwEbJ6fRSZ9nu3VXjzc65S/98hE70LZfORIEID3f6jVUx VV73K7XjOwTzn3wNUjJC+vqobg== X-Google-Smtp-Source: ABdhPJxz2D16swtH7T1EhCN8vRgROTUqu5EuC82EPgq1tZIkVYwUellFUFh0WQOrOIZKA41y3B4yMA== X-Received: by 2002:a17:90a:b785:: with SMTP id m5mr5306630pjr.213.1630605100717; Thu, 02 Sep 2021 10:51:40 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id x13sm2973468pjh.30.2021.09.02.10.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 10:51:39 -0700 (PDT) Date: Thu, 2 Sep 2021 11:51:37 -0600 From: Mathieu Poirier To: Qi Liu Cc: suzuki.poulose@arm.com, mike.leach@linaro.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com Subject: Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device Message-ID: <20210902175137.GC1078000@p14s> References: <20210719111737.47891-1-liuqi115@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210719111737.47891-1-liuqi115@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_105142_334152_AB7415A0 X-CRM114-Status: GOOD ( 18.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 19, 2021 at 07:17:35PM +0800, Qi Liu wrote: > This patchset add support for SMB(System Memory Buffer) device, SMB > obtains CPU instructions from Coresight ETM device and stores these > messages in system memory. > SMB is developed by Ultrasoc technology, which is acquired by Siemens, > and we still use "Ultrasoc" to name document and driver. > > Change since RFC: > - Move ultrasoc driver to drivers/hwtracing/coresight. > - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in > basic tracing function. > - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core. > - Address the comments from Mathieu and Suzuki. > - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html > > Qi Liu (2): > Documentation: tracing: Documentation for ultrasoc SMB drivers > coresight: ultrasoc: Add System Memory Buffer driver > > .../trace/coresight/ultrasoc-trace.rst | 193 +++++ > MAINTAINERS | 7 + > drivers/hwtracing/coresight/Kconfig | 3 + > drivers/hwtracing/coresight/Makefile | 2 + > drivers/hwtracing/coresight/ultrasoc/Kconfig | 12 + > drivers/hwtracing/coresight/ultrasoc/Makefile | 6 + > .../coresight/ultrasoc/ultrasoc-smb.c | 722 ++++++++++++++++++ > .../coresight/ultrasoc/ultrasoc-smb.h | 142 ++++ > 8 files changed, 1087 insertions(+) I have started to review this set. Comments will follow shortly. Thanks, Mathieu > create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel