Re: [PATCH] ASoC: SOF: Handle control change notification from firmware

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] ASoC: SOF: Handle control change notification from firmware
Date: Thu, 02 Sep 2021 22:00:03 +0800	[thread overview]
Message-ID: <202109022155.AWnnNhY4-lkp@intel.com> (raw)
In-Reply-To: <20210902115328.28478-1-peter.ujfalusi@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2971 bytes --]

Hi Peter,

I love your patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on v5.14 next-20210902]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Peter-Ujfalusi/ASoC-SOF-Handle-control-change-notification-from-firmware/20210902-195456
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: openrisc-randconfig-r011-20210831 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e5cd7dd552fbaf85b196f59e528423f41d23347b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Peter-Ujfalusi/ASoC-SOF-Handle-control-change-notification-from-firmware/20210902-195456
        git checkout e5cd7dd552fbaf85b196f59e528423f41d23347b
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=openrisc SHELL=/bin/bash sound/soc/sof/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   sound/soc/sof/ipc.c: In function 'ipc_comp_notification':
>> sound/soc/sof/ipc.c:387:21: error: void value not ignored as it ought to be
     387 |                 ret = snd_sof_ipc_msg_data(sdev, NULL, cdata, hdr->size);
         |                     ^

vim +387 sound/soc/sof/ipc.c

   371	
   372	static void ipc_comp_notification(struct snd_sof_dev *sdev,
   373					  struct sof_ipc_cmd_hdr *hdr)
   374	{
   375		u32 msg_type = hdr->cmd & SOF_CMD_TYPE_MASK;
   376		struct sof_ipc_ctrl_data *cdata;
   377		int ret;
   378	
   379		switch (msg_type) {
   380		case SOF_IPC_COMP_GET_VALUE:
   381		case SOF_IPC_COMP_GET_DATA:
   382			cdata = kmalloc(hdr->size, GFP_KERNEL);
   383			if (!cdata)
   384				return;
   385	
   386			/* read back full message */
 > 387			ret = snd_sof_ipc_msg_data(sdev, NULL, cdata, hdr->size);
   388			if (ret < 0) {
   389				dev_err(sdev->dev,
   390					"error: failed to read component event: %d\n", ret);
   391				goto err;
   392			}
   393			break;
   394		default:
   395			dev_err(sdev->dev, "error: unhandled component message %#x\n", msg_type);
   396			return;
   397		}
   398	
   399		snd_sof_control_notify(sdev, cdata);
   400	
   401	err:
   402		kfree(cdata);
   403	}
   404	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31633 bytes --]