From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5659A72 for ; Fri, 3 Sep 2021 09:10:45 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 5CD493200905; Fri, 3 Sep 2021 05:10:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 03 Sep 2021 05:10:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=ox+I/Ry1v/j82vqbJpoMct9xYn8 vhfN0iM0y0R/9Wa4=; b=VPZfi/EnygXML/q/kpH7FBvJeu9/C5QPnKNHhEnomws sjlGDFlegXG2TQBPfh3/NkFuZEejkaktEnLBvFyIR87u9TZfRwSaeRegOlpFceNl 32s6LfM0wCntk6l65wCuFaPC2pFDSyHwkDQfcSGxDxu926aIlEzW84UIh/SlTgFr O1L1zBdEIYAdgdXSUH1jBtsVLUfIEvYUYWhouQ1l7FGPvGmc/1BMSVTtBP886Srq oiGyPVcHldqDk00Jrer29EEnMjO+BoRm4wI4VQyE+NqCTf+a33T9mlbTt1TlS1Sq DD8/+Rt0ANQh7dwqIOUm371VtIbTeuC/GimUqh7zvHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ox+I/R y1v/j82vqbJpoMct9xYn8vhfN0iM0y0R/9Wa4=; b=bvloNvgKdH/DDTrAB9De1r wsZqy8CrKk8GNm/uTeL+27iyu48KHio0B6hJPz//np8BlZOElL1WhnLCpDk/ElWX toWwilmaA4ZWeWZp1vv/lQFL9cQ2nI92zToc47r45I//VN3zMsppUY9cEdFIw7tE snAJbIXsUKVJnva98ZQgE7qu0HzQC4CY6Zs6yGmXM9iEmNKd8S9ueVXZao5enLSq wVtHmk3lxmI7n5t1ppKrUYE7LOh3U/PG9tZm+/deVZIHUCNPlezp/opg0gCgg4iz w6ge/rJeWgazBjVkGpFBv7d4NhGOUHJANYyXPgDqnom/ehb7BHqSwJeaJFFF1iOA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddvjedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Sep 2021 05:10:42 -0400 (EDT) Date: Fri, 3 Sep 2021 11:10:40 +0200 From: Maxime Ripard To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] clk: sunxi-ng: Rename files to match Kconfig and drivers Message-ID: <20210903091040.2bngsvhem2ftzhaz@gilmour> References: <20210901050526.45673-1-samuel@sholland.org> <20210901050526.45673-5-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ejwkc5wmabu555zl" Content-Disposition: inline In-Reply-To: <20210901050526.45673-5-samuel@sholland.org> --ejwkc5wmabu555zl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Sep 01, 2021 at 12:05:22AM -0500, Samuel Holland wrote: > When the drivers are built as modules, the file name will become the > module name. Rename the files so everything matches: the Kconfig symbol, > the platform driver name (as seen in sysfs), and the module name. >=20 > Signed-off-by: Samuel Holland I'm not a big fan of big renames like this, it makes merging and backporting patches harder in the long term. I assume you did this to make the module autoloading work? If so, using MODULE_ALIAS would be less intrusive Maxime --ejwkc5wmabu555zl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYTHmkAAKCRDj7w1vZxhR xf4xAP90rWbPp24J+BEJxdB2On7UfpvhIiYfWFYBbYKAlJfsRQD7B8nA9clu2f1u JaR0qk9WskxjgGvi6R8jMVEelzBTsAg= =sai4 -----END PGP SIGNATURE----- --ejwkc5wmabu555zl-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D30C433EF for ; Fri, 3 Sep 2021 09:12:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E80CA60F56 for ; Fri, 3 Sep 2021 09:12:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E80CA60F56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=00CyjFL00bne8ISPJRiBGG/qmOqdo2Au4kvuknOO6dI=; b=xuXtlXW5Ay7Jo6TB8BuVygcRNR +LGG1+GMTMafgySm/JftTqwvEWoAfA6KLTgQkZs3HN9I5qV2hzp4f/CazQdOF/iVMR6VcPfWDmmJZ 7q1Av+Qe0N22GNE2KQd+ICIEDWck1hJMNBejRAuTS2Uh1LeChhd4qjwvs/ZfxsoC2FXwJfhzaxI4Y YNaBsokscqywVin+I/Ig/2Ctia3dZql2nVe3/PgynwgIvZYQmuPyTJcXD4fW4sPvHvdT6VawPfX86 +B0E0dSKwkL924JrsJHQCxa8tAAYGeK9crCrHRRBVE1B3DF3tP5RwwOYVTrUXy0YqEnYj4QnLA10R UZd5Z1eQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mM5Dn-00BOZ1-7f; Fri, 03 Sep 2021 09:10:51 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mM5Di-00BOXb-J6 for linux-arm-kernel@lists.infradead.org; Fri, 03 Sep 2021 09:10:47 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 5CD493200905; Fri, 3 Sep 2021 05:10:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 03 Sep 2021 05:10:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=ox+I/Ry1v/j82vqbJpoMct9xYn8 vhfN0iM0y0R/9Wa4=; b=VPZfi/EnygXML/q/kpH7FBvJeu9/C5QPnKNHhEnomws sjlGDFlegXG2TQBPfh3/NkFuZEejkaktEnLBvFyIR87u9TZfRwSaeRegOlpFceNl 32s6LfM0wCntk6l65wCuFaPC2pFDSyHwkDQfcSGxDxu926aIlEzW84UIh/SlTgFr O1L1zBdEIYAdgdXSUH1jBtsVLUfIEvYUYWhouQ1l7FGPvGmc/1BMSVTtBP886Srq oiGyPVcHldqDk00Jrer29EEnMjO+BoRm4wI4VQyE+NqCTf+a33T9mlbTt1TlS1Sq DD8/+Rt0ANQh7dwqIOUm371VtIbTeuC/GimUqh7zvHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ox+I/R y1v/j82vqbJpoMct9xYn8vhfN0iM0y0R/9Wa4=; b=bvloNvgKdH/DDTrAB9De1r wsZqy8CrKk8GNm/uTeL+27iyu48KHio0B6hJPz//np8BlZOElL1WhnLCpDk/ElWX toWwilmaA4ZWeWZp1vv/lQFL9cQ2nI92zToc47r45I//VN3zMsppUY9cEdFIw7tE snAJbIXsUKVJnva98ZQgE7qu0HzQC4CY6Zs6yGmXM9iEmNKd8S9ueVXZao5enLSq wVtHmk3lxmI7n5t1ppKrUYE7LOh3U/PG9tZm+/deVZIHUCNPlezp/opg0gCgg4iz w6ge/rJeWgazBjVkGpFBv7d4NhGOUHJANYyXPgDqnom/ehb7BHqSwJeaJFFF1iOA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddvjedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Sep 2021 05:10:42 -0400 (EDT) Date: Fri, 3 Sep 2021 11:10:40 +0200 From: Maxime Ripard To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] clk: sunxi-ng: Rename files to match Kconfig and drivers Message-ID: <20210903091040.2bngsvhem2ftzhaz@gilmour> References: <20210901050526.45673-1-samuel@sholland.org> <20210901050526.45673-5-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20210901050526.45673-5-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210903_021046_698045_6DDCCC2B X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6114779328002357355==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6114779328002357355== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ejwkc5wmabu555zl" Content-Disposition: inline --ejwkc5wmabu555zl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Sep 01, 2021 at 12:05:22AM -0500, Samuel Holland wrote: > When the drivers are built as modules, the file name will become the > module name. Rename the files so everything matches: the Kconfig symbol, > the platform driver name (as seen in sysfs), and the module name. >=20 > Signed-off-by: Samuel Holland I'm not a big fan of big renames like this, it makes merging and backporting patches harder in the long term. I assume you did this to make the module autoloading work? If so, using MODULE_ALIAS would be less intrusive Maxime --ejwkc5wmabu555zl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYTHmkAAKCRDj7w1vZxhR xf4xAP90rWbPp24J+BEJxdB2On7UfpvhIiYfWFYBbYKAlJfsRQD7B8nA9clu2f1u JaR0qk9WskxjgGvi6R8jMVEelzBTsAg= =sai4 -----END PGP SIGNATURE----- --ejwkc5wmabu555zl-- --===============6114779328002357355== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6114779328002357355==--