From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21526C433F5 for ; Fri, 3 Sep 2021 18:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0440661051 for ; Fri, 3 Sep 2021 18:54:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351315AbhICSze (ORCPT ); Fri, 3 Sep 2021 14:55:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:44954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350591AbhICSzb (ORCPT ); Fri, 3 Sep 2021 14:55:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C6EEA61051; Fri, 3 Sep 2021 18:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630695270; bh=k0qqhjIBTc+gyB6NzqxwhhFn9y/tnKZkCVBCXngFTi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HRnrrB2Jph7uelGBkGR4cg8QVuct3/B8w1s6Z0i9VbiI/DtTVFnp+DrP1Xub+jM70 lmogrtDA/ZqdzzOc+e2aXU9GM0i/HCLA6VN2gnpIlzRLP1JMg9aDZ+aHd15ySB2lHH fyPyxnLYOm+h1GW7euhDaleRRE9GTNOF1Nov7nbC60eUJHOn0bFAwH0OFQKNiJHiJX mBM+xvs8AA8K3HtMs5yrVF5MNu/LlNNa+VD9UOWY+eGQPhDTsi5MEDW08a8uVTrD7V tgQOmK41k0WgmvOpPT8nPUZaHHULhWTOKci1vhBpn9R7LZGpM0l4jgxNqd6kr3UWsL WYOYmAKFZW7hw== Date: Fri, 3 Sep 2021 11:54:30 -0700 From: "Darrick J. Wong" To: Andreas Gruenbacher Cc: Linus Torvalds , Alexander Viro , Christoph Hellwig , Jan Kara , Matthew Wilcox , cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH v7 15/19] iomap: Support partial direct I/O on user copy failures Message-ID: <20210903185430.GE9892@magnolia> References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-16-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210827164926.1726765-16-agruenba@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 27, 2021 at 06:49:22PM +0200, Andreas Gruenbacher wrote: > In iomap_dio_rw, when iomap_apply returns an -EFAULT error and the > IOMAP_DIO_PARTIAL flag is set, complete the request synchronously and > return a partial result. This allows the caller to deal with the page > fault and retry the remainder of the request. > > Signed-off-by: Andreas Gruenbacher Pretty straightforward. Reviewed-by: Darrick J. Wong --D > --- > fs/iomap/direct-io.c | 6 ++++++ > include/linux/iomap.h | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 8054f5d6c273..ba88fe51b77a 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -561,6 +561,12 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > ret = iomap_apply(inode, pos, count, iomap_flags, ops, dio, > iomap_dio_actor); > if (ret <= 0) { > + if (ret == -EFAULT && dio->size && > + (dio_flags & IOMAP_DIO_PARTIAL)) { > + wait_for_completion = true; > + ret = 0; > + } > + > /* magic error code to fall back to buffered I/O */ > if (ret == -ENOTBLK) { > wait_for_completion = true; > diff --git a/include/linux/iomap.h b/include/linux/iomap.h > index 479c1da3e221..bcae4814b8e3 100644 > --- a/include/linux/iomap.h > +++ b/include/linux/iomap.h > @@ -267,6 +267,13 @@ struct iomap_dio_ops { > */ > #define IOMAP_DIO_OVERWRITE_ONLY (1 << 1) > > +/* > + * When a page fault occurs, return a partial synchronous result and allow > + * the caller to retry the rest of the operation after dealing with the page > + * fault. > + */ > +#define IOMAP_DIO_PARTIAL (1 << 2) > + > ssize_t iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > const struct iomap_ops *ops, const struct iomap_dio_ops *dops, > unsigned int dio_flags); > -- > 2.26.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE689C433EF for ; Fri, 3 Sep 2021 18:54:39 +0000 (UTC) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 848BE60EC0 for ; Fri, 3 Sep 2021 18:54:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 848BE60EC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=oss.oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 183ITirG008914; Fri, 3 Sep 2021 18:54:38 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3aue9fsy07-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 Sep 2021 18:54:38 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 183IUal3147735; Fri, 3 Sep 2021 18:54:37 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3030.oracle.com with ESMTP id 3ate07vxus-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Fri, 03 Sep 2021 18:54:36 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mMEKh-00076d-Oa; Fri, 03 Sep 2021 11:54:35 -0700 Received: from aserp3030.oracle.com ([141.146.126.71]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mMEKf-00076N-DK for ocfs2-devel@oss.oracle.com; Fri, 03 Sep 2021 11:54:33 -0700 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 183ITu8N181133 for ; Fri, 3 Sep 2021 18:54:33 GMT Received: from mx0a-00069f01.pphosted.com (mx0a-00069f01.pphosted.com [205.220.165.26]) by aserp3030.oracle.com with ESMTP id 3atdyyup5k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 03 Sep 2021 18:54:33 +0000 Received: from pps.filterd (m0246575.ppops.net [127.0.0.1]) by mx0b-00069f01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 183GhkSK019779 for ; Fri, 3 Sep 2021 18:54:32 GMT Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx0b-00069f01.pphosted.com with ESMTP id 3au7whkvsx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 03 Sep 2021 18:54:31 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C6EEA61051; Fri, 3 Sep 2021 18:54:30 +0000 (UTC) Date: Fri, 3 Sep 2021 11:54:30 -0700 From: "Darrick J. Wong" To: Andreas Gruenbacher Message-ID: <20210903185430.GE9892@magnolia> References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-16-agruenba@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210827164926.1726765-16-agruenba@redhat.com> X-Source-IP: 198.145.29.99 X-ServerName: mail.kernel.org X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 mx include:_spf.kernel.org ~all X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10096 signatures=668682 X-Proofpoint-Spam-Reason: safe X-Spam: OrgSafeList X-SpamRule: orgsafelist Cc: cluster-devel@redhat.com, Jan Kara , linux-kernel@vger.kernel.org, Christoph Hellwig , Alexander Viro , linux-fsdevel@vger.kernel.org, Linus Torvalds , ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH v7 15/19] iomap: Support partial direct I/O on user copy failures X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10096 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109030110 X-Proofpoint-GUID: p6tygKdxgej71vgNNxJmsqja4_vCquhi X-Proofpoint-ORIG-GUID: p6tygKdxgej71vgNNxJmsqja4_vCquhi On Fri, Aug 27, 2021 at 06:49:22PM +0200, Andreas Gruenbacher wrote: > In iomap_dio_rw, when iomap_apply returns an -EFAULT error and the > IOMAP_DIO_PARTIAL flag is set, complete the request synchronously and > return a partial result. This allows the caller to deal with the page > fault and retry the remainder of the request. > > Signed-off-by: Andreas Gruenbacher Pretty straightforward. Reviewed-by: Darrick J. Wong --D > --- > fs/iomap/direct-io.c | 6 ++++++ > include/linux/iomap.h | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 8054f5d6c273..ba88fe51b77a 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -561,6 +561,12 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > ret = iomap_apply(inode, pos, count, iomap_flags, ops, dio, > iomap_dio_actor); > if (ret <= 0) { > + if (ret == -EFAULT && dio->size && > + (dio_flags & IOMAP_DIO_PARTIAL)) { > + wait_for_completion = true; > + ret = 0; > + } > + > /* magic error code to fall back to buffered I/O */ > if (ret == -ENOTBLK) { > wait_for_completion = true; > diff --git a/include/linux/iomap.h b/include/linux/iomap.h > index 479c1da3e221..bcae4814b8e3 100644 > --- a/include/linux/iomap.h > +++ b/include/linux/iomap.h > @@ -267,6 +267,13 @@ struct iomap_dio_ops { > */ > #define IOMAP_DIO_OVERWRITE_ONLY (1 << 1) > > +/* > + * When a page fault occurs, return a partial synchronous result and allow > + * the caller to retry the rest of the operation after dealing with the page > + * fault. > + */ > +#define IOMAP_DIO_PARTIAL (1 << 2) > + > ssize_t iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > const struct iomap_ops *ops, const struct iomap_dio_ops *dops, > unsigned int dio_flags); > -- > 2.26.3 > _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darrick J. Wong Date: Fri, 3 Sep 2021 11:54:30 -0700 Subject: [Cluster-devel] [PATCH v7 15/19] iomap: Support partial direct I/O on user copy failures In-Reply-To: <20210827164926.1726765-16-agruenba@redhat.com> References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-16-agruenba@redhat.com> Message-ID: <20210903185430.GE9892@magnolia> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Aug 27, 2021 at 06:49:22PM +0200, Andreas Gruenbacher wrote: > In iomap_dio_rw, when iomap_apply returns an -EFAULT error and the > IOMAP_DIO_PARTIAL flag is set, complete the request synchronously and > return a partial result. This allows the caller to deal with the page > fault and retry the remainder of the request. > > Signed-off-by: Andreas Gruenbacher Pretty straightforward. Reviewed-by: Darrick J. Wong --D > --- > fs/iomap/direct-io.c | 6 ++++++ > include/linux/iomap.h | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 8054f5d6c273..ba88fe51b77a 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -561,6 +561,12 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > ret = iomap_apply(inode, pos, count, iomap_flags, ops, dio, > iomap_dio_actor); > if (ret <= 0) { > + if (ret == -EFAULT && dio->size && > + (dio_flags & IOMAP_DIO_PARTIAL)) { > + wait_for_completion = true; > + ret = 0; > + } > + > /* magic error code to fall back to buffered I/O */ > if (ret == -ENOTBLK) { > wait_for_completion = true; > diff --git a/include/linux/iomap.h b/include/linux/iomap.h > index 479c1da3e221..bcae4814b8e3 100644 > --- a/include/linux/iomap.h > +++ b/include/linux/iomap.h > @@ -267,6 +267,13 @@ struct iomap_dio_ops { > */ > #define IOMAP_DIO_OVERWRITE_ONLY (1 << 1) > > +/* > + * When a page fault occurs, return a partial synchronous result and allow > + * the caller to retry the rest of the operation after dealing with the page > + * fault. > + */ > +#define IOMAP_DIO_PARTIAL (1 << 2) > + > ssize_t iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > const struct iomap_ops *ops, const struct iomap_dio_ops *dops, > unsigned int dio_flags); > -- > 2.26.3 >