From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3511306779933643908==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Sat, 04 Sep 2021 21:22:28 +0800 Message-ID: <20210904132228.GA110474@23464b5f6056> In-Reply-To: <202109042126.8QUDTtdE-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============3511306779933643908== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Chanwoo Choi CC: Bartlomiej Zolnierkiewicz CC: Alessandro Zummo CC: Alexandre Belloni CC: linux-kernel(a)vger.kernel.org CC: linux-rtc(a)vger.kernel.org From: kernel test robot drivers/rtc/rtc-max77686.c:779:7-27: WARNING: Threaded IRQ with no primary = handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: f1583cb1be35c23df60b1c39e3e7e6704d749d0b commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 14 hours ago :::::: commit date: 4 months ago Please take the patch only if it's a positive warning. Thanks! rtc-max77686.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -776,7 +776,8 @@ static int max77686_rtc_probe(struct pla goto err_rtc; } = - ret =3D request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0, + ret =3D request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, + IRQF_ONESHOT, "rtc-alarm1", info); if (ret < 0) { dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", --===============3511306779933643908==--