From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D4AC433F5 for ; Sat, 4 Sep 2021 14:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CCDF6056B for ; Sat, 4 Sep 2021 14:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236564AbhIDOGT convert rfc822-to-8bit (ORCPT ); Sat, 4 Sep 2021 10:06:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:50018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236402AbhIDOGP (ORCPT ); Sat, 4 Sep 2021 10:06:15 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B208B60F9C; Sat, 4 Sep 2021 14:05:10 +0000 (UTC) Date: Sat, 4 Sep 2021 15:08:34 +0100 From: Jonathan Cameron To: Miquel Raynal Cc: "Sa, Nuno" , Lars-Peter Clausen , Thomas Petazzoni , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 11/16] iio: adc: max1027: Separate the IRQ handler from the read logic Message-ID: <20210904150834.7002f023@jic23-huawei> In-Reply-To: <20210902105519.5891a90f@xps13> References: <20210818111139.330636-1-miquel.raynal@bootlin.com> <20210818111139.330636-12-miquel.raynal@bootlin.com> <20210902105519.5891a90f@xps13> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Sep 2021 10:55:19 +0200 Miquel Raynal wrote: > Hi Nuno, > > "Sa, Nuno" wrote on Fri, 20 Aug 2021 07:23:33 > +0000: > > > > -----Original Message----- > > > From: Miquel Raynal > > > Sent: Wednesday, August 18, 2021 1:12 PM > > > To: Jonathan Cameron ; Lars-Peter Clausen > > > > > > Cc: Thomas Petazzoni ; linux- > > > iio@vger.kernel.org; linux-kernel@vger.kernel.org; Miquel Raynal > > > > > > Subject: [PATCH 11/16] iio: adc: max1027: Separate the IRQ handler > > > from the read logic > > > > > > [External] > > > > > > Create a max1027_read_scan() helper which will make clearer the > > > future IRQ > > > handler updates (no functional change). > > > > > > Signed-off-by: Miquel Raynal > > > --- > > > drivers/iio/adc/max1027.c | 27 +++++++++++++++++++++------ > > > 1 file changed, 21 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c > > > index 83526f3d7d3a..afc3ce69f7ea 100644 > > > --- a/drivers/iio/adc/max1027.c > > > +++ b/drivers/iio/adc/max1027.c > > > @@ -427,19 +427,18 @@ static int > > > max1027_set_cnvst_trigger_state(struct iio_trigger *trig, bool state) > > > return 0; > > > } > > > > > > -static irqreturn_t max1027_trigger_handler(int irq, void *private) > > > +static int max1027_read_scan(struct iio_dev *indio_dev) > > > { > > > - struct iio_poll_func *pf = private; > > > - struct iio_dev *indio_dev = pf->indio_dev; > > > struct max1027_state *st = iio_priv(indio_dev); > > > unsigned int scanned_chans = fls(*indio_dev- > > > >active_scan_mask); > > > u16 *buf = st->buffer; > > > unsigned int bit; > > > - > > > - pr_debug("%s(irq=%d, private=0x%p)\n", __func__, irq, > > > private); > > > + int ret; > > > > > > /* fill buffer with all channel */ > > > - spi_read(st->spi, st->buffer, scanned_chans * 2); > > > + ret = spi_read(st->spi, st->buffer, scanned_chans * 2); > > > + if (ret < 0) > > > + return ret; > > > > > > /* Only keep the channels selected by the user */ > > > for_each_set_bit(bit, indio_dev->active_scan_mask, > > > @@ -451,6 +450,22 @@ static irqreturn_t max1027_trigger_handler(int > > > irq, void *private) > > > > > > iio_push_to_buffers(indio_dev, st->buffer); > > > > > > + return 0; > > > +} > > > + > > > +static irqreturn_t max1027_trigger_handler(int irq, void *private) > > > +{ > > > + struct iio_poll_func *pf = private; > > > + struct iio_dev *indio_dev = pf->indio_dev; > > > + int ret; > > > + > > > + pr_debug("%s(irq=%d, private=0x%p)\n", __func__, irq, > > > private); > > > + > > > > This should be more consistent... use 'dev_err()'. I would also > > argue to use the spi dev as the driver state structure holds a > > pointer to it... > > I honestly don't see the point of these debug messages (there is > another useless pr_debug in probe). I kept it here as I am just moving > code around without any changes, but if you don't like it (me neither) > I'll add a simple patch dropping them. Go for it :) > > Thanks, > Miquèl