From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 651BDC433F5 for ; Mon, 6 Sep 2021 10:45:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE38960BD3 for ; Mon, 6 Sep 2021 10:45:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EE38960BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNC7e-0006E4-1Y for qemu-devel@archiver.kernel.org; Mon, 06 Sep 2021 06:45:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNC6A-0004fz-DO for qemu-devel@nongnu.org; Mon, 06 Sep 2021 06:43:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNC68-0005ju-Or for qemu-devel@nongnu.org; Mon, 06 Sep 2021 06:43:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630925011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ydqzmpwIS7w421UnF6h3bFe+Afko4IEnGxAHt+H+82o=; b=b4J2YUHOQqYRG+psoc24G3Poaf5im/8BqqHkepiiRrNxuVmGYzhHrgDZ6Uzye3QU0R3MUr C0+vgdJayLVNefsFHoRE1ZQEUQu7sPekLdO+KNTmSHgdFNlmlMwnaiag6DuS8wyYuGVV4f VHyqq9QTrdEaPUOhnEFFzhl41QzbBEg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-WwpQsdEANmGodZfCQQu5ZA-1; Mon, 06 Sep 2021 06:43:30 -0400 X-MC-Unique: WwpQsdEANmGodZfCQQu5ZA-1 Received: by mail-wm1-f70.google.com with SMTP id 5-20020a1c00050000b02902e67111d9f0so2183928wma.4 for ; Mon, 06 Sep 2021 03:43:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ydqzmpwIS7w421UnF6h3bFe+Afko4IEnGxAHt+H+82o=; b=PAAMagyUVXhJzTQjZEh9rAOjagPTDtqpYN8fVfbkIN8i3u/mFNn6Ld1yTQOJvImweC FNSbiFxoneeTmZ+25T2PdqaTdJJTshvOayZ/vmHkl7hOW9zm3vFFKKGQJkxbUu8p0njZ d3I0KzGE+Wdiu91Sg/GxLTiYezs4lLhvj1d9gMVp5R3XbUTsXpXFhT91Juqeiin92Jnf dl9kPhWL2AwCju3rVoKBEWoyHQoOgbqR2/GJAToKAL9DqgTUOxC55V0rbKGXsfncpDcL OW3QeizZq1IfPB5Jr8xCWO56ZKgQsy+cer/V1yuqkRLMlBIRx+TuJA2mOnfEXyDaAtow wrDQ== X-Gm-Message-State: AOAM532JmfOxMqI3+UzVYRrLZaWZwDWl4sJxI7ZE8LhxsSnCDc1V5RIp P+Ocsd0XSeSSrryqKvaVmSr/NcsGBb/QtG2qGYK2sZf2X7h2i2qzPo6Yph6sEDFwcJaTQLQe3nW g1cFbRaKrSq2OGDWdboDeaf/4HGXrPYZdvJs6FuzeLEHWDrsg7+nIWP7HjQzYk60B X-Received: by 2002:adf:ce85:: with SMTP id r5mr12649801wrn.323.1630925009293; Mon, 06 Sep 2021 03:43:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHy4hCuzzCoHmbyOxXuF8aQv4fJfICXV4BR/P+IflP/4frkx1GgFT9uF0tP+AARXyUtB+1Jg== X-Received: by 2002:adf:ce85:: with SMTP id r5mr12649777wrn.323.1630925009082; Mon, 06 Sep 2021 03:43:29 -0700 (PDT) Received: from x1w.. (21.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.21]) by smtp.gmail.com with ESMTPSA id c15sm6889020wmr.8.2021.09.06.03.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 03:43:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 2/3] hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all() Date: Mon, 6 Sep 2021 12:43:17 +0200 Message-Id: <20210906104318.1569967-3-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210906104318.1569967-1-philmd@redhat.com> References: <20210906104318.1569967-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.391, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Jason Wang , Cornelia Huck , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" vring_get_region_caches() must be called with the RCU read lock acquired. virtqueue_packed_drop_all() does not, and uses the 'caches' pointer. Fix that by using the RCU_READ_LOCK_GUARD() macro. Reported-by: Stefano Garzarella Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/virtio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 97f60017466..7d3bf9091ee 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -1704,6 +1704,8 @@ static unsigned int virtqueue_packed_drop_all(VirtQueue *vq) VirtIODevice *vdev = vq->vdev; VRingPackedDesc desc; + RCU_READ_LOCK_GUARD(); + caches = vring_get_region_caches(vq); if (!caches) { return 0; -- 2.31.1