From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94ECB3FC7 for ; Mon, 6 Sep 2021 18:54:30 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id x11so15170345ejv.0 for ; Mon, 06 Sep 2021 11:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p6Mu2rmKCPwNJW+9zwnqhgEVtP2V6TMjoxJ0ql5/F1I=; b=SoRDw5MME8u/nH+eRY+ImHFCaKPG3MlFoOIoNVNS6BY+B/nzEBwYJW3LmI/2AwDC5s wNMLROjzBA0OzsB2YgrofIHJor3PezOZjdfvAhwho87Vxl0LtgNtRt24dJdU0Dyp3W2f DFtvaoMRxZ+noJAnlFeVoVkjhWoH+gz+zsj4c0hZ7w0a0aqbsRn/UlHWCLUuhS/iEgXb ItWbECwgCNNtEoWn5V5zxpKwCC5Z6LXSf18idRxHor907uyMziCCjThefw+Zszj7fgf6 eh2K3K9l4ggoKe16vm7Sq33Z1K8qaSjDs1eLNqsPsYm4hmwCrsoam8B2tvvdjMCUyLHR FSXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p6Mu2rmKCPwNJW+9zwnqhgEVtP2V6TMjoxJ0ql5/F1I=; b=rgdBx7kHAncpaCo7yvYwwpvu1CH9sRlBJt4lxLcYnI/iuUK3ukjqS7zWkffOG3ZA9O hZrM32NjBzgz6iw4NppuX2x4BSImQ8F6QCBgtZv0ie3xfnzXv3IDH6I4yyZE7Pn0nyLJ 3Ne6rd0OaHERzsGK5dQbSaB2SH6I0vgLkEJk0aJGOOeJkXmw80qOcR7fPW0kzsMAOlik t5eTHyvvuBcjaIIXHf+dlOFCz2RlqKDaTrpbUuzN3QKKJuOlsDpudfV3T/oUqMtxPk2M XuXXcU4vktTNXWDg9hakkBAt102x8sneDyxr3TvRFw0LrKXsx2DF6Q4zxSXqw1jcWHhc K0cA== X-Gm-Message-State: AOAM531mprdJq8loDhxjMcOZzRLMFO1e6qDQakdCI6/9To9Lgmg//e4m LoBQyEMkr5z124+K1+GTUs0= X-Google-Smtp-Source: ABdhPJwuORQc5BSzTNOzlONv6HzgA7IvZ/3UMXRaufSmzzYp42/H83B/bayEEHgelvuoVMCfQg00yA== X-Received: by 2002:a17:906:2413:: with SMTP id z19mr13890688eja.57.1630954469082; Mon, 06 Sep 2021 11:54:29 -0700 (PDT) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::8fe1]) by smtp.gmail.com with ESMTPSA id kk2sm4329128ejc.114.2021.09.06.11.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 11:54:28 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v2 36/40] staging: r8188eu: remove hal_notch_filter from hal_ops Date: Mon, 6 Sep 2021 20:53:23 +0200 Message-Id: <20210906185327.10326-37-straube.linux@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210906185327.10326-1-straube.linux@gmail.com> References: <20210906185327.10326-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove hal_notch_filter from hal_ops and remove its wrapper rtw_hal_notch_filter(). Call hal_notch_filter_8188e() directly instead. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/hal_intf.c | 8 +------- drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 4 +--- drivers/staging/r8188eu/include/hal_intf.h | 6 ++---- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/staging/r8188eu/hal/hal_intf.c b/drivers/staging/r8188eu/hal/hal_intf.c index 4a9820c2b36e..4394c6825f1a 100644 --- a/drivers/staging/r8188eu/hal/hal_intf.c +++ b/drivers/staging/r8188eu/hal/hal_intf.c @@ -24,7 +24,7 @@ uint rtw_hal_init(struct adapter *adapt) adapt->hw_init_completed = true; if (adapt->registrypriv.notch_filter == 1) - rtw_hal_notch_filter(adapt, 1); + hal_notch_filter_8188e(adapt, 1); } else { adapt->hw_init_completed = false; DBG_88E("rtw_hal_init: hal__init fail\n"); @@ -201,9 +201,3 @@ int rtw_hal_iol_cmd(struct adapter *adapter, struct xmit_frame *xmit_frame, bndy_cnt); return _FAIL; } - -void rtw_hal_notch_filter(struct adapter *adapter, bool enable) -{ - if (adapter->HalFunc.hal_notch_filter) - adapter->HalFunc.hal_notch_filter(adapter, enable); -} diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c index f87cfa0e404a..9a76e9aaa2d0 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -1748,7 +1748,7 @@ void rtl8188e_clone_haldata(struct adapter *dst_adapter, struct adapter *src_ada memcpy(dst_adapter->HalData, src_adapter->HalData, dst_adapter->hal_data_sz); } -static void hal_notch_filter_8188e(struct adapter *adapter, bool enable) +void hal_notch_filter_8188e(struct adapter *adapter, bool enable) { if (enable) { DBG_88E("Enable notch filter\n"); @@ -1768,8 +1768,6 @@ void rtl8188e_set_hal_ops(struct hal_ops *pHalFunc) pHalFunc->write_rfreg = &rtl8188e_PHY_SetRFReg; pHalFunc->IOL_exec_cmds_sync = &rtl8188e_IOL_exec_cmds_sync; - - pHalFunc->hal_notch_filter = &hal_notch_filter_8188e; } u8 GetEEPROMSize8188E(struct adapter *padapter) diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h index fdde4b2b8ec4..35201286704f 100644 --- a/drivers/staging/r8188eu/include/hal_intf.h +++ b/drivers/staging/r8188eu/include/hal_intf.h @@ -172,8 +172,6 @@ struct hal_ops { int (*IOL_exec_cmds_sync)(struct adapter *padapter, struct xmit_frame *frame, u32 max_wait, u32 bndy_cnt); - - void (*hal_notch_filter)(struct adapter *adapter, bool enable); }; #define RF_CHANGE_BY_INIT 0 @@ -207,6 +205,8 @@ u16 rtl8188e_EfuseGetCurrentSize(struct adapter *pAdapter, u8 efuseType, bool bP int rtl8188e_Efuse_PgPacketRead(struct adapter *pAdapter, u8 offset, u8 *data, bool bPseudoTest); int rtl8188e_Efuse_PgPacketWrite(struct adapter *pAdapter, u8 offset, u8 word_en, u8 *data, bool bPseudoTest); +void hal_notch_filter_8188e(struct adapter *adapter, bool enable); + void rtw_hal_free_data(struct adapter *padapter); uint rtw_hal_init(struct adapter *padapter); uint rtw_hal_deinit(struct adapter *padapter); @@ -249,8 +249,6 @@ void rtw_hal_write_rfreg(struct adapter *padapter, int rtw_hal_iol_cmd(struct adapter *adapter, struct xmit_frame *xmit_frame, u32 max_wating_ms, u32 bndy_cnt); -void rtw_hal_notch_filter(struct adapter *adapter, bool enable); - void indicate_wx_scan_complete_event(struct adapter *padapter); u8 rtw_do_join(struct adapter *padapter); -- 2.33.0