From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Steve French <sfrench@samba.org>,
Hyunchul Lee <hyc.lee@gmail.com>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ksmbd: remove unnecessary conditions
Date: Tue, 7 Sep 2021 11:54:30 +0300 [thread overview]
Message-ID: <20210907085430.GM1957@kadam> (raw)
In-Reply-To: <YTcdbOgmB7758K+/@google.com>
On Tue, Sep 07, 2021 at 05:06:04PM +0900, Sergey Senozhatsky wrote:
> On (21/09/07 10:34), Dan Carpenter wrote:
> >
> > id = le32_to_cpu(psid->sub_auth[psid->num_subauth - 1]);
> > - if (id >= 0) {
> > - /*
> > - * Translate raw sid into kuid in the server's user
> > - * namespace.
> > - */
> > - uid = make_kuid(&init_user_ns, id);
> > -
> > - /* If this is an idmapped mount, apply the idmapping. */
> > - uid = kuid_from_mnt(user_ns, uid);
> > - if (uid_valid(uid)) {
> > - fattr->cf_uid = uid;
> > - rc = 0;
> > - }
> > + /*
> > + * Translate raw sid into kuid in the server's user
> > + * namespace.
> > + */
> > + uid = make_kuid(&init_user_ns, id);
>
> Can make_kuid() return INVALID_UID? IOW, uid_valid(uid) here as well?
No need to check twice. We're going to check at the end.
>
> > +
> > + /* If this is an idmapped mount, apply the idmapping. */
> > + uid = kuid_from_mnt(user_ns, uid);
> > + if (uid_valid(uid)) {
^^^^^^^^^^^^^^
The check here is sufficient.
regards,
dan carpenter
next prev parent reply other threads:[~2021-09-07 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 7:34 [PATCH] ksmbd: remove unnecessary conditions Dan Carpenter
2021-09-07 8:06 ` Sergey Senozhatsky
2021-09-07 8:54 ` Dan Carpenter [this message]
2021-09-07 9:04 ` Sergey Senozhatsky
2021-09-07 9:14 ` Dan Carpenter
2021-09-07 9:59 ` Sergey Senozhatsky
2021-09-07 10:17 ` Dan Carpenter
2021-09-07 10:34 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907085430.GM1957@kadam \
--to=dan.carpenter@oracle.com \
--cc=hyc.lee@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.