From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Dave Chinner <david@fromorbit.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
Naohiro Aota <Naohiro.Aota@wdc.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH] common/rc: Check SCRATCH_DEV in _require_dm_target()
Date: Tue, 7 Sep 2021 09:28:44 +0000 [thread overview]
Message-ID: <20210907092843.ludgrxfo34xud3ue@shindev> (raw)
In-Reply-To: <20210907081556.GE1756565@dread.disaster.area>
On Sep 07, 2021 / 18:15, Dave Chinner wrote:
> On Tue, Sep 07, 2021 at 04:41:16PM +0900, Shin'ichiro Kawasaki wrote:
> > When SCRATCH_DEV is not set and the test case does not call
> > _require_scratch*() before _require_dm_target(), _require_block_device()
>
> That is the bug that needs fixing.
Thanks for the comment. Do you mean the test cases (generic/628 and generic/629)
need fix to call _require_scratch*() before _require_dm_target()? I think that
fix approach will leave the possibility that the newly added test cases in the
future may have the same failure. IMO, the patch posted will be more effective
to prevent the failures.
--
Best Regards,
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2021-09-07 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 7:41 [PATCH] common/rc: Check SCRATCH_DEV in _require_dm_target() Shin'ichiro Kawasaki
2021-09-07 8:15 ` Dave Chinner
2021-09-07 9:28 ` Shinichiro Kawasaki [this message]
2021-09-07 10:36 ` Dave Chinner
2021-09-08 2:57 ` Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907092843.ludgrxfo34xud3ue@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.