All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>
Subject: Re: [PATCH] btrfs: zoned: fix double counting of split ordered extent
Date: Tue, 7 Sep 2021 13:18:44 +0200	[thread overview]
Message-ID: <20210907111843.GJ3379@twin.jikos.cz> (raw)
In-Reply-To: <20210906150428.2399128-1-naohiro.aota@wdc.com>

On Tue, Sep 07, 2021 at 12:04:28AM +0900, Naohiro Aota wrote:
> btrfs_add_ordered_extent_*() add num_bytes to fs_info->ordered_bytes.
> Then, splitting an ordered extent will call btrfs_add_ordered_extent_*()
> again for split extents, leading to double counting of the region of
> a split extent. These leaked bytes are finally reported at unmount time
> as follow.
> 
> BTRFS info (device dm-1): at unmount dio bytes count 364544
> 
> This commit fixes the double counting by subtracting split extent's size
> from fs_info->ordered_bytes.
> 
> Fixes: d22002fd37bd ("btrfs: zoned: split ordered extent when bio is sent")
> Cc: stable@vger.kernel.org # 5.12+
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>

Added to misc-next, thanks.

      parent reply	other threads:[~2021-09-07 11:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 15:04 [PATCH] btrfs: zoned: fix double counting of split ordered extent Naohiro Aota
2021-09-07  8:00 ` Johannes Thumshirn
2021-09-07 11:18 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907111843.GJ3379@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.