From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC76C433F5 for ; Tue, 7 Sep 2021 12:18:40 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F49560F45 for ; Tue, 7 Sep 2021 12:18:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F49560F45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5AD65100EB835; Tue, 7 Sep 2021 05:18:35 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=185.125.188.123; helo=smtp-relay-internal-1.canonical.com; envelope-from=krzysztof.kozlowski@canonical.com; receiver= Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BAF39100EB82F for ; Tue, 7 Sep 2021 05:18:32 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id C3D0E40779 for ; Tue, 7 Sep 2021 12:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631017111; bh=alAZCnXDBZFqFGCWdjT1NtYwVcFPW4mHC6+AQVNQmag=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=trlr4oC8LLuY5GeQkmvHgbJsYUtlqK9BukxXXgZehcZTvW+lLylO5H1FoHfVU4RHQ qIAb7rHlZFUJpfMJuHiwXDYuDjjdWh1S0TeH6qjenACrNrzK2JJdwuRtUjLa0vh4Z7 PdVmQEJz8PFLICWDV1BkzqRHkM9deQdBgPYvdrlHngODvLJxksmuJhe8rivaeuCod3 34LP/rzzXApaDTTc8nvyAD/xoeDhGnVjjncnRFaKSGr6jh9moGDyUqGrJax0j+tDIL KabZ+QGFTrv0SML9Uk+unL1eM6+kSoMmjRxkwStkkSwNzq97krA5Ikz/qvd+7PeEok bsEIbaJyLIVLw== Received: by mail-wm1-f71.google.com with SMTP id p5-20020a7bcc85000000b002e7563efc4cso1035233wma.4 for ; Tue, 07 Sep 2021 05:18:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=alAZCnXDBZFqFGCWdjT1NtYwVcFPW4mHC6+AQVNQmag=; b=Zt+yKngggbAAJoUWr9PHAqiq/woGlufAZdNTW+ULCPb8KHMbBY576EGe39+qezg7cZ AgJZOxWUVD82B26UX8JIlPnvdicx9gr1qOBX7zBy+RJPB79Vd903kc/7z9772anebAKt 22M9FYkj7LQNNCrW95XFovdK1si+uUVMAkzEySQkvK70WSfROkqJAaSCXqE/YzRtxE3n YzIpn7BtjaEIDLxhJLgfn0+wuDzjqk27HnLXV6zTxVJZvTY5oP/rNywhMuEgvSgKzQzO FJBXe702RwF96gqXRsVmHHNqZiRtG2/nx+pxmqfvZHjaPdzOEe1Pnh2P8Lk3CesAjUoD 3x0A== X-Gm-Message-State: AOAM531IhwYKFL+WdMGXQCrg4vQdGvlLaP8Qk0kSC+VZ/+Z4WvQI5fTy CiKLrQPoD9FJbRF8H+7KNDrANAsqwBoYYdZPgSjcXskzHD76jWd8A2STgsd4/OKi7BuXWKuOfXg J4HAWQLAU/K4L876U71+xLnJMIvhq004mEQ== X-Received: by 2002:a7b:c4d2:: with SMTP id g18mr3717614wmk.135.1631017111458; Tue, 07 Sep 2021 05:18:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSzLNNlEK8DFo/MnzQggQYeVU3xGdFUyuK/8MdNZjNchdqevSP20XoztHRWZaK3JDeEdaRWA== X-Received: by 2002:a7b:c4d2:: with SMTP id g18mr3717597wmk.135.1631017111286; Tue, 07 Sep 2021 05:18:31 -0700 (PDT) Received: from kozik-lap.lan ([79.98.113.47]) by smtp.gmail.com with ESMTPSA id m3sm13525216wrg.45.2021.09.07.05.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 05:18:30 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Krzysztof Opasiak , Mark Greer , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Date: Tue, 7 Sep 2021 14:18:09 +0200 Message-Id: <20210907121816.37750-9-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210907121816.37750-1-krzysztof.kozlowski@canonical.com> References: <20210907121816.37750-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Message-ID-Hash: V7KKGQ7ALYL46N46TASIASE7VGITGAMH X-Message-ID-Hash: V7KKGQ7ALYL46N46TASIASE7VGITGAMH X-MailFrom: krzysztof.kozlowski@canonical.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.1.1 Precedence: list Subject: [linux-nfc] [PATCH 08/15] nfc: pn544: drop unneeded memory allocation fail messages List-Id: NFC on Linux Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit nfc_mei_phy_alloc() already prints an error message on memory allocation failure. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/pn544/mei.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/nfc/pn544/mei.c b/drivers/nfc/pn544/mei.c index a519fa0a53e2..c493f2dbd0e2 100644 --- a/drivers/nfc/pn544/mei.c +++ b/drivers/nfc/pn544/mei.c @@ -23,10 +23,8 @@ static int pn544_mei_probe(struct mei_cl_device *cldev, int r; phy = nfc_mei_phy_alloc(cldev); - if (!phy) { - pr_err("Cannot allocate memory for pn544 mei phy.\n"); + if (!phy) return -ENOMEM; - } r = pn544_hci_probe(phy, &mei_phy_ops, LLC_NOP_NAME, MEI_NFC_HEADER_SIZE, 0, MEI_NFC_MAX_HCI_PAYLOAD, -- 2.30.2 _______________________________________________ Linux-nfc mailing list -- linux-nfc@lists.01.org To unsubscribe send an email to linux-nfc-leave@lists.01.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8DEC433F5 for ; Tue, 7 Sep 2021 12:19:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7CD5610F8 for ; Tue, 7 Sep 2021 12:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344582AbhIGMUR (ORCPT ); Tue, 7 Sep 2021 08:20:17 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:33682 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344303AbhIGMTu (ORCPT ); Tue, 7 Sep 2021 08:19:50 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1373140793 for ; Tue, 7 Sep 2021 12:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631017112; bh=alAZCnXDBZFqFGCWdjT1NtYwVcFPW4mHC6+AQVNQmag=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ahWsmlix5qZu4PCN4E6up4Tnegthwc6b8exu+qOav9qLBEGmq/y6C1KlZHjcKvJqX DopLZU0qot2emyWiCT9XcfTfJcwkXBfXAPPIp7v7r64FcdCoUQ2ueZJ6Jxc0qs3EcS dyXMEIGI1Dhmnu4R/s6hqZXj7VUaRxlmu5Kon7JQmLOECXLzUivA1SlCafatGZpw/R 4ak4+stoe4VGLhZFP+4BSWPdmmRT80VjJqUm7b9s4yylVxM/19RNpXJJLZXbsBo6bO QOqUEFfiyaS53aahakom2krSGYSqy8m80TUxJO6Isab2q4OlcrUVY48cFFFrPPu0bB EBzGgcvXeebxA== Received: by mail-wm1-f70.google.com with SMTP id y188-20020a1c7dc5000000b002e80e0b2f87so1120044wmc.1 for ; Tue, 07 Sep 2021 05:18:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=alAZCnXDBZFqFGCWdjT1NtYwVcFPW4mHC6+AQVNQmag=; b=X8Dipx8tY17wg+AkK/D5M42zdliVefa+mJvfqUYlCnrS2srs5jai2t5uhuTJHPkWl2 ZIrJhqDBRnR3la1G88fYB1juEgEfhLjBIXHcZjbG3yFAFh6U0Hf8PcMQWLa3XRd0unpF eNmLlauB7T7KLarS/HGWBYREO3BDFdBAMIdr+msEA0OuGn/LDJUrueu+suC0Bt2kX4qy s7yCKFLWOTktry4DbSYqAf7SFFqWkYv4BEMwgr3tn84KLI4GVM3aTffwLgb3X4iMwd6q Hb0nw7TeQhHwax6y2HzmYFcbgYrJbMuZqUpl9HwcQnfQF7E+YkemsG/TorH44bGvNr8x 4jcA== X-Gm-Message-State: AOAM531STmMgxnoSF92pXm88CMEBEqqYW2XetqyVEImHPE1HaVFKnnzW HUtJlK34QjoFa7/lzRBvaWFv9HzZmjJ1AU1Mhv0BZ4F4Mu90V1JRCrKF3UoLwOGDLhkY8IVcdjh AJx4Q72j+WqmilUDCmo0AcS8wlx6BQTQJNlDLIeQEtRTJ X-Received: by 2002:a7b:c4d2:: with SMTP id g18mr3717613wmk.135.1631017111458; Tue, 07 Sep 2021 05:18:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSzLNNlEK8DFo/MnzQggQYeVU3xGdFUyuK/8MdNZjNchdqevSP20XoztHRWZaK3JDeEdaRWA== X-Received: by 2002:a7b:c4d2:: with SMTP id g18mr3717597wmk.135.1631017111286; Tue, 07 Sep 2021 05:18:31 -0700 (PDT) Received: from kozik-lap.lan ([79.98.113.47]) by smtp.gmail.com with ESMTPSA id m3sm13525216wrg.45.2021.09.07.05.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 05:18:30 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Krzysztof Opasiak , Mark Greer , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: [PATCH 08/15] nfc: pn544: drop unneeded memory allocation fail messages Date: Tue, 7 Sep 2021 14:18:09 +0200 Message-Id: <20210907121816.37750-9-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210907121816.37750-1-krzysztof.kozlowski@canonical.com> References: <20210907121816.37750-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org nfc_mei_phy_alloc() already prints an error message on memory allocation failure. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/pn544/mei.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/nfc/pn544/mei.c b/drivers/nfc/pn544/mei.c index a519fa0a53e2..c493f2dbd0e2 100644 --- a/drivers/nfc/pn544/mei.c +++ b/drivers/nfc/pn544/mei.c @@ -23,10 +23,8 @@ static int pn544_mei_probe(struct mei_cl_device *cldev, int r; phy = nfc_mei_phy_alloc(cldev); - if (!phy) { - pr_err("Cannot allocate memory for pn544 mei phy.\n"); + if (!phy) return -ENOMEM; - } r = pn544_hci_probe(phy, &mei_phy_ops, LLC_NOP_NAME, MEI_NFC_HEADER_SIZE, 0, MEI_NFC_MAX_HCI_PAYLOAD, -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7644608455600659232==" MIME-Version: 1.0 From: Krzysztof Kozlowski To: linux-nfc@lists.01.org Subject: [PATCH 08/15] nfc: pn544: drop unneeded memory allocation fail messages Date: Tue, 07 Sep 2021 14:18:09 +0200 Message-ID: <20210907121816.37750-9-krzysztof.kozlowski@canonical.com> In-Reply-To: <20210907121816.37750-1-krzysztof.kozlowski@canonical.com> List-Id: --===============7644608455600659232== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable nfc_mei_phy_alloc() already prints an error message on memory allocation failure. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/pn544/mei.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/nfc/pn544/mei.c b/drivers/nfc/pn544/mei.c index a519fa0a53e2..c493f2dbd0e2 100644 --- a/drivers/nfc/pn544/mei.c +++ b/drivers/nfc/pn544/mei.c @@ -23,10 +23,8 @@ static int pn544_mei_probe(struct mei_cl_device *cldev, int r; = phy =3D nfc_mei_phy_alloc(cldev); - if (!phy) { - pr_err("Cannot allocate memory for pn544 mei phy.\n"); + if (!phy) return -ENOMEM; - } = r =3D pn544_hci_probe(phy, &mei_phy_ops, LLC_NOP_NAME, MEI_NFC_HEADER_SIZE, 0, MEI_NFC_MAX_HCI_PAYLOAD, -- = 2.30.2 --===============7644608455600659232==--