From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: replace BUG_ON() in btrfs_csum_one_bio() with proper error handling
Date: Tue, 7 Sep 2021 16:13:22 +0200 [thread overview]
Message-ID: <20210907141321.GP3379@twin.jikos.cz> (raw)
In-Reply-To: <20210816235540.9475-1-wqu@suse.com>
On Tue, Aug 17, 2021 at 07:55:40AM +0800, Qu Wenruo wrote:
> There is a BUG_ON() in btrfs_csum_one_bio() to catch code logic error.
>
> It has indeed caught several bugs during subpage development.
>
> But the BUG_ON() itself will bring down the whole system which is
> sometimes overkilled.
>
> Replace it with a WARN() and exit gracefully, so that it won't crash the
> whole system while we can still catch the code logic error.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> Changelog:
> v2:
> - Re-send as an independent patch
> - Add WARN() to catch the code logic error
Added to misc-next, without changes. The way with separate condition and
WARN is ok for now.
prev parent reply other threads:[~2021-09-07 14:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 23:55 [PATCH v2] btrfs: replace BUG_ON() in btrfs_csum_one_bio() with proper error handling Qu Wenruo
2021-08-17 7:55 ` Nikolay Borisov
2021-08-17 8:03 ` Nikolay Borisov
2021-08-17 8:10 ` Qu Wenruo
2021-08-18 23:00 ` David Sterba
2021-08-19 1:08 ` Qu Wenruo
2021-08-19 12:23 ` David Sterba
2021-08-19 12:34 ` Qu Wenruo
2021-09-07 14:13 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907141321.GP3379@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.