From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Paolo Valente <paolo.valente@linaro.org>,
Ming Lei <ming.lei@redhat.com>,
Niklas Cassel <Niklas.Cassel@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] don't call io scheduler callbacks for passthrough requests
Date: Tue, 7 Sep 2021 14:21:54 +0000 [thread overview]
Message-ID: <20210907142145.112096-1-Niklas.Cassel@wdc.com> (raw)
From: Niklas Cassel <niklas.cassel@wdc.com>
Recently, there were some extra "dummy" data added into mq-deadline
rq->elv.priv, that was added for the solve purpose of working around
quirky behavior in blk-mq (which called the scheduler callbacks even
for requests that bypassed the scheduler).
Fix blk-mq to not call the I/O scheduler callbacks for passthrough requests,
since they will later bypass the I/O scheduler anyway.
This way, we can remove unnecessary logic in mq-deadline that was added to
deal with this quirky behavior.
BFQ should be able to perform a similar cleanup, if they wish, and should
then be able to drop this comment from the code:
https://github.com/torvalds/linux/blob/v5.14/block/bfq-iosched.c#L6456-L6462
Considering that I'm quite unfamiliar with the BFQ code, I'd rather
someone who is a bit more familiar with BFQ performs that cleanup.
Kind regards,
Niklas
Niklas Cassel (2):
blk-mq: don't call callbacks for requests that bypassed the scheduler
Revert "mq-deadline: Fix request accounting"
block/blk-mq.c | 7 ++++++-
block/mq-deadline.c | 16 +++++-----------
2 files changed, 11 insertions(+), 12 deletions(-)
--
2.31.1
next reply other threads:[~2021-09-07 14:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 14:21 Niklas Cassel [this message]
2021-09-07 14:21 ` [PATCH 1/2] blk-mq: don't call callbacks for requests that bypassed the scheduler Niklas Cassel
2021-09-07 14:29 ` Ming Lei
2021-09-07 14:21 ` [PATCH 2/2] Revert "mq-deadline: Fix request accounting" Niklas Cassel
2021-09-07 14:54 ` Bart Van Assche
2021-09-07 16:07 ` Niklas Cassel
2021-09-07 16:49 ` Bart Van Assche
2021-09-07 15:15 ` Bart Van Assche
2021-09-07 16:28 ` Niklas Cassel
2021-09-07 17:12 ` Bart Van Assche
2021-09-08 11:57 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907142145.112096-1-Niklas.Cassel@wdc.com \
--to=niklas.cassel@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.