From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CB5A72 for ; Tue, 7 Sep 2021 17:43:29 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AF3A45C01B7; Tue, 7 Sep 2021 13:43:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 07 Sep 2021 13:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=z krYxpxmyK+adj+hCKejbSyS7Z1m9laTt+mMUb/p9ww=; b=Z+oZusxgQLEjF/bo6 RYFNLbH9FEKQSvdBdAkAyzYUMDDO2sc6szJ/GT57HChLT3uS4AP/8auuK9Si98Yb 3csQazCMiS0v6Jrb7w+uTbYZvrW7k2oIn9SHkpUeZKCsO7LYb3+V+U49YbTCnJo+ BP1sZaYbuwqoCqm4NPQtdvr3cSz+W1oVYRIwaY3AfBRN8NvoVlHB5tHQEoiTmBVp kHSlTd1ih2q7GptCZaCpy2X0yRrZF0kASmKomYYiPTBNEJPvpVaWLSRiWXA/Ko3t Z3dxckVUgXrer+kwxZzZJC2cCo51tBfBYZ+LFPFhCON932KokLrh0N5Bs8ckBE1V HwtHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=zkrYxpxmyK+adj+hCKejbSyS7Z1m9laTt+mMUb/p9 ww=; b=AwhVB5Hrv+dwdXAbibD2+Ww2oMXujC+0Gah1GBo6AA+FaDJNZVRzoMwDD mjnVOgbXf9+jGVsTeNDpjsE6hcKSdiKL8vRBtVehVWzn8hD7j5kfAPfEOxAuNy/9 Ras61q5EjnT4fzEfo5XsT9NCQ9C0JotPBrekyaEagKV4isA5uonExqZULONv5ThU 6OsjglmYfJZZh8df0oNMgiqk2bllRMnJyd2oao+X6vk2paG/+IgSs1FB4J3zoQaD n95T8eVTx+3mzsIq0rTX+ouyOgFgLzBKwebW2dXZ2POK2LGJZ1f0sS4faWrf49Xz GhK2JRwu+tnkQBScsdsTA1arkD3tQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefhedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeel udegvddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Sep 2021 13:43:26 -0400 (EDT) Date: Tue, 7 Sep 2021 19:43:24 +0200 From: Maxime Ripard To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] clk: sunxi-ng: Rename files to match Kconfig and drivers Message-ID: <20210907174324.lho3vdl2z6uealnf@gilmour> References: <20210901050526.45673-1-samuel@sholland.org> <20210901050526.45673-5-samuel@sholland.org> <20210903091040.2bngsvhem2ftzhaz@gilmour> <1d269ff8-9219-cc0a-fda7-236bfd4b4510@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1d269ff8-9219-cc0a-fda7-236bfd4b4510@sholland.org> Hi, On Fri, Sep 03, 2021 at 03:57:14PM -0500, Samuel Holland wrote: > Hi Maxime, >=20 > On 9/3/21 4:10 AM, Maxime Ripard wrote: > > Hi, > >=20 > > On Wed, Sep 01, 2021 at 12:05:22AM -0500, Samuel Holland wrote: > >> When the drivers are built as modules, the file name will become the > >> module name. Rename the files so everything matches: the Kconfig symbo= l, > >> the platform driver name (as seen in sysfs), and the module name. > >> > >> Signed-off-by: Samuel Holland > >=20 > > I'm not a big fan of big renames like this, it makes merging and > > backporting patches harder in the long term. >=20 > I can split this into two commits, first the .c files and then the .h > files, so everything is a 100% rename, if that makes a difference. >=20 > > I assume you did this to make the module autoloading work? If so, using > > MODULE_ALIAS would be less intrusive >=20 > Autoloading should work anyway, since there is a module alias for the > compatible string. This change is more about the principle of least > surprise. The compatible is allwinner,sun50i-a64-ccu, the Kconfig symbol > is SUN50I_A64_CCU, the driver name (in /sys/bus/platform/drivers) is > sun50i_a64_ccu, but yet the module name is ccu-sun50i-a64??? We can't really do much for the compatible, and it's the standard practice there anyway. However, it looks much more common for Kconfig to have a pattern like $FRAMEWORK_$SOC, so maybe we could just rename the Kconfig (and drivers name) to CCU_SUN50I_A64? It's not been exposed to the defconfig so far anyway, so we can change them without any real harm > Once we allow building modules, the names are ABI, and this > inconsistency will bother me until the end of time :) >=20 > If there is a way to completely rename the module without renaming the > files (not adding an alias), then that would be enough for me. Otherwise, yeah, we can do what Stephen suggested Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC3BC433FE for ; Tue, 7 Sep 2021 17:46:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 744A56069E for ; Tue, 7 Sep 2021 17:46:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 744A56069E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Y9f6di4tJ65jG/o6o1JlmQJe+oQUi3g7Wo/InMSz0w=; b=Vh9udUQYU0bwft Ip8IHJki0VEeF2cZjJvKz6zV733BPyRSgfo962wpFjsinUpaTfdggAtJXw/VjSvpC016IG3g7IgCD c/UG7t0oVuQAX1xzW42ZfhROWN1eC7aTNbhJt2Wt0/q2xwvBC1cW+r0IGJLZP1OcJ4LmUZZ+c6940 eai1u45PwsreqQWiHiQV99YbJIv5dc+gDdG3pSmtgxEne4NYkAKQGIfqclgJmerWyvIUygItt+6zw I4A/DSCczX1eX5vaERzlidZl3bGaw33x3JsPhqyijaoaXyE2tNi5Qg1PGIPlo34/LX7dOrWWqN3Sn YxVADtdkt8IvkSANpUdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNf8F-004N7s-Fg; Tue, 07 Sep 2021 17:43:39 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNf8B-004N71-FF for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 17:43:37 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AF3A45C01B7; Tue, 7 Sep 2021 13:43:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 07 Sep 2021 13:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=z krYxpxmyK+adj+hCKejbSyS7Z1m9laTt+mMUb/p9ww=; b=Z+oZusxgQLEjF/bo6 RYFNLbH9FEKQSvdBdAkAyzYUMDDO2sc6szJ/GT57HChLT3uS4AP/8auuK9Si98Yb 3csQazCMiS0v6Jrb7w+uTbYZvrW7k2oIn9SHkpUeZKCsO7LYb3+V+U49YbTCnJo+ BP1sZaYbuwqoCqm4NPQtdvr3cSz+W1oVYRIwaY3AfBRN8NvoVlHB5tHQEoiTmBVp kHSlTd1ih2q7GptCZaCpy2X0yRrZF0kASmKomYYiPTBNEJPvpVaWLSRiWXA/Ko3t Z3dxckVUgXrer+kwxZzZJC2cCo51tBfBYZ+LFPFhCON932KokLrh0N5Bs8ckBE1V HwtHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=zkrYxpxmyK+adj+hCKejbSyS7Z1m9laTt+mMUb/p9 ww=; b=AwhVB5Hrv+dwdXAbibD2+Ww2oMXujC+0Gah1GBo6AA+FaDJNZVRzoMwDD mjnVOgbXf9+jGVsTeNDpjsE6hcKSdiKL8vRBtVehVWzn8hD7j5kfAPfEOxAuNy/9 Ras61q5EjnT4fzEfo5XsT9NCQ9C0JotPBrekyaEagKV4isA5uonExqZULONv5ThU 6OsjglmYfJZZh8df0oNMgiqk2bllRMnJyd2oao+X6vk2paG/+IgSs1FB4J3zoQaD n95T8eVTx+3mzsIq0rTX+ouyOgFgLzBKwebW2dXZ2POK2LGJZ1f0sS4faWrf49Xz GhK2JRwu+tnkQBScsdsTA1arkD3tQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefhedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeel udegvddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Sep 2021 13:43:26 -0400 (EDT) Date: Tue, 7 Sep 2021 19:43:24 +0200 From: Maxime Ripard To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] clk: sunxi-ng: Rename files to match Kconfig and drivers Message-ID: <20210907174324.lho3vdl2z6uealnf@gilmour> References: <20210901050526.45673-1-samuel@sholland.org> <20210901050526.45673-5-samuel@sholland.org> <20210903091040.2bngsvhem2ftzhaz@gilmour> <1d269ff8-9219-cc0a-fda7-236bfd4b4510@sholland.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1d269ff8-9219-cc0a-fda7-236bfd4b4510@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_104335_806061_99386BF0 X-CRM114-Status: GOOD ( 26.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, Sep 03, 2021 at 03:57:14PM -0500, Samuel Holland wrote: > Hi Maxime, > > On 9/3/21 4:10 AM, Maxime Ripard wrote: > > Hi, > > > > On Wed, Sep 01, 2021 at 12:05:22AM -0500, Samuel Holland wrote: > >> When the drivers are built as modules, the file name will become the > >> module name. Rename the files so everything matches: the Kconfig symbol, > >> the platform driver name (as seen in sysfs), and the module name. > >> > >> Signed-off-by: Samuel Holland > > > > I'm not a big fan of big renames like this, it makes merging and > > backporting patches harder in the long term. > > I can split this into two commits, first the .c files and then the .h > files, so everything is a 100% rename, if that makes a difference. > > > I assume you did this to make the module autoloading work? If so, using > > MODULE_ALIAS would be less intrusive > > Autoloading should work anyway, since there is a module alias for the > compatible string. This change is more about the principle of least > surprise. The compatible is allwinner,sun50i-a64-ccu, the Kconfig symbol > is SUN50I_A64_CCU, the driver name (in /sys/bus/platform/drivers) is > sun50i_a64_ccu, but yet the module name is ccu-sun50i-a64??? We can't really do much for the compatible, and it's the standard practice there anyway. However, it looks much more common for Kconfig to have a pattern like $FRAMEWORK_$SOC, so maybe we could just rename the Kconfig (and drivers name) to CCU_SUN50I_A64? It's not been exposed to the defconfig so far anyway, so we can change them without any real harm > Once we allow building modules, the names are ABI, and this > inconsistency will bother me until the end of time :) > > If there is a way to completely rename the module without renaming the > files (not adding an alias), then that would be enough for me. Otherwise, yeah, we can do what Stephen suggested Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel