From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mNiU3-0006M5-1W for mharc-grub-devel@gnu.org; Tue, 07 Sep 2021 17:18:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNiU1-0006Lf-3N for grub-devel@gnu.org; Tue, 07 Sep 2021 17:18:21 -0400 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]:40672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNiTx-0001rL-7D for grub-devel@gnu.org; Tue, 07 Sep 2021 17:18:19 -0400 Received: by mail-io1-xd31.google.com with SMTP id z1so344818ioh.7 for ; Tue, 07 Sep 2021 14:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=ABiWL6bUOfK9uOuNE/wpWxTnbserj2bITlqvxDCMchs=; b=S5URBdKWYEdFE9lC3YzQ0t7uYy/XZkkPXg47npVC5e38Uw0L8k2TR55bMWcRoQMVqv /8vTrKLDpJxbk1MSaCumOkDP7JSHEn0f6jMMsqYmyEPfShW9d95vGrjsRV2weQXgLG1k 1+585BT+Y6JPGzEQdblSMaU7u2EaXwcA1QMoA1SyQvCazQoeY0kmsdHCfOh2rseycRJx eIX1JZ3VywcZ4MSlF3MsfHieAAwafJiyR5Oc5Kp3zMUQXZrnv8lNASdBktjAlB8tJEWJ w7E4LFayFinjUpRa1YudIPD9HJo4rHYJtTt47fDzvPwOGcbgvemAaj/o/u2Gcy4trSQB ysIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=ABiWL6bUOfK9uOuNE/wpWxTnbserj2bITlqvxDCMchs=; b=YwWuEYj6lxaSacjbz4yBnFDF+mRfLUFf6LGMS6/XsXzoNrd8YIefLJwWYenM5+vIC+ ikwuVWJyUc3tXZ7ZYN9Y03T9PyO6mtICuF8CLZfz9oSH9KgbMQhKJ+OWZ3UbcD4jqhGJ DFFJAdm6WzjY1utztWqyq6ehPs9wWSgoxmfz/XlZVQN9IArgQsUmHzyPN27ARsXfLKoq drzH0BJorsxNMLxxxEakuje9YINHODOdS8NWH2495NcYLWCWkOLc9ku27SxxZJ583QPe fK/UnTgT/ov8qz5PAlLXf9+3uXq0DrHRERXrkYddM5H3LpSsmYKk+j/0JghE4Ph6u+Zq ajIQ== X-Gm-Message-State: AOAM5313U23cjbQxs1PkOEWbQ/dFUS0Ba7GIPvOesZiCCHEAWwSAKu34 jE5Gj7m+xaAOEXQDxKKK6U8U0w== X-Google-Smtp-Source: ABdhPJxmA0bXGWf3rmJEBhiQWPmUXgI0zZQdtZCRpg4seI01OpLzqiCn3q6ENN/MIPib6Zxpc25kEg== X-Received: by 2002:a5e:c903:: with SMTP id z3mr167237iol.61.1631049495379; Tue, 07 Sep 2021 14:18:15 -0700 (PDT) Received: from ubuntu ([185.220.103.12]) by smtp.gmail.com with ESMTPSA id l15sm72279iow.4.2021.09.07.14.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 14:18:14 -0700 (PDT) Date: Tue, 7 Sep 2021 21:15:58 +0000 From: Glenn Washburn To: Daniel Kiper Cc: Thomas Schmitt , grub-devel@gnu.org Subject: Re: [PATCH] tests: Let xorriso fixely assume UTF-8 as local character set Message-ID: <20210907211346.7d0dd9e8@ubuntu> In-Reply-To: <20210901131138.iymzlg6wquxwei3m@tomti.i.net-space.pl> References: <20210827210506.17586-1-scdbackup@gmx.net> <20210901131138.iymzlg6wquxwei3m@tomti.i.net-space.pl> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::d31; envelope-from=development@efficientek.com; helo=mail-io1-xd31.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2021 21:18:21 -0000 On Wed, 1 Sep 2021 15:11:38 +0200 Daniel Kiper wrote: > On Fri, Aug 27, 2021 at 11:05:06PM +0200, Thomas Schmitt wrote: > > iso9660_test fails if the effective locale is not UTF-8. This > > happens because xorriso needs to convert file names and FSLABEL to > > UCS-2 when preparing a Joliet tree. grub-fs-tester obviously > > intends to use UTF-8 as character set, but xorriso assumes by > > default the result of nl_langinfo(3) with item CODESET. > > So override the result of nl_langinfo(CODESET) by options of > > xorriso -as mkisofs. > > > > Signed-off-by: Thomas Schmitt > > Thomas, Glenn, thank you for doing such deep investigation! > > Reviewed-by: Daniel Kiper > > Glenn, did you test this patch? Coming to this late, had some issues which kept me away. I notice that the patch is already in master, but for what its worth, I have now tested with the patch and LANG unset and the test now succeeds. Thanks Thomas. Glenn