From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2253C433F5 for ; Wed, 8 Sep 2021 06:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92E9760EFE for ; Wed, 8 Sep 2021 06:16:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347710AbhIHGR6 (ORCPT ); Wed, 8 Sep 2021 02:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347725AbhIHGR5 (ORCPT ); Wed, 8 Sep 2021 02:17:57 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E156C0617AE for ; Tue, 7 Sep 2021 23:16:48 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id w7so1451620pgk.13 for ; Tue, 07 Sep 2021 23:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1Zq8fGof5d5XpqmYAb98Vp/W3flQC31yfyIUWvsR98c=; b=aDAu4A48OaIPTP8xEFp/xpRQhKH6QHQlnNrv3efDTAuMK956e2ZgjnBAJapHZt+pIM 8MgyUAL47JWud6NyVOp5t/+TuiQ5SoNeRsRSL2rAEIKfM1L7n9aGl6LruJk5W5rN8CCO lGCCfbXyBzEdbhKQkikyRySFyqLl2P484Rv0RtC7lJogVDYS56S5pgoWtNNOWlItpipu q/ZcfzmjtOK7XeqvVchD8D3cdzm+JjF9EKmF3i9gaoQ4JY6q/zLCPmI1dNAuKnoXbsZA MNWxJe+riqHX6D3z4jehAEFZ4iMayvyeJINbLksuFuBN7yVdulFfPQ0rae8XjmVKNZTs e4Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1Zq8fGof5d5XpqmYAb98Vp/W3flQC31yfyIUWvsR98c=; b=QE18tGBzdePNJKcf6rr3x3eJHtc7iUVLbTEV685IteZWZAZHITJ7JfGl5t/F7IHAGU U+TEyIAhUpO8l6afL3BpHIUX8rM3Toq8ePD2ngJdaKlbdeQt14bqPxBImMhPlxJI3Lr8 5wjl0zJH9dMvjn8DmeltuUEuGFtAF5URujECMbUDHjvNMkPdTt2eUBwzih69Kh5xX1sp O102l7a9dliShCErVQc16G2VxcjchPd0OZuOSyhqYKVbz1iIKcUq3zornEN/wJUJnB6w s7sdEaZhr4RNW8eIK9FT73XxcPAbtdKdHzi7FWhcmIWIowxr9HgPuGP5zkTN9TNdwRXn DZSg== X-Gm-Message-State: AOAM533z3uS2wyf7O+Dyv12LmgEDyjDaowVVZWFkcBOI+dUD6577Gmly t/5208+HQ2c//SDldio3iAa2eA== X-Google-Smtp-Source: ABdhPJzl+ip5khG2YokF65Zp4NGm+UqQwxxCrFDdLROE1DhaI6KBrmPLrPm97STLst878c0bpCeSKQ== X-Received: by 2002:a63:dd56:: with SMTP id g22mr2146469pgj.38.1631081807993; Tue, 07 Sep 2021 23:16:47 -0700 (PDT) Received: from tyrell.hq.igel.co.jp (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id n1sm971730pfv.209.2021.09.07.23.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 23:16:47 -0700 (PDT) From: Shunsuke Mie To: Zhu Yanjun Cc: Shunsuke Mie , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Daniel Vetter , Doug Ledford , Jason Gunthorpe , Jianxin Xiong , Leon Romanovsky , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, dhobsong@igel.co.jp, taki@igel.co.jp, etom@igel.co.jp Subject: [RFC PATCH 2/3] RDMA/rxe: Extract a mapping process into a function Date: Wed, 8 Sep 2021 15:16:10 +0900 Message-Id: <20210908061611.69823-3-mie@igel.co.jp> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210908061611.69823-1-mie@igel.co.jp> References: <20210908061611.69823-1-mie@igel.co.jp> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Functionization of the process to generate the memory map. The function generates maps from scatterlists to a list of page aligned addresses. Signed-off-by: Shunsuke Mie --- drivers/infiniband/sw/rxe/rxe_mr.c | 89 ++++++++++++++++++------------ 1 file changed, 54 insertions(+), 35 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c index be4bcb420fab..8b08705ed62a 100644 --- a/drivers/infiniband/sw/rxe/rxe_mr.c +++ b/drivers/infiniband/sw/rxe/rxe_mr.c @@ -103,15 +103,59 @@ void rxe_mr_init_dma(struct rxe_pd *pd, int access, struct rxe_mr *mr) mr->type = RXE_MR_TYPE_DMA; } +/* generate a rxe memory map data structure from ib_umem */ +static int rxe_mr_gen_map(struct rxe_mr *mr, struct ib_umem *umem) +{ + int err; + int num_buf; + struct rxe_map **map; + struct rxe_phys_buf *buf = NULL; + struct sg_page_iter sg_iter; + void *vaddr; + + num_buf = 0; + map = mr->map; + if (mr->length > 0) { + buf = map[0]->buf; + + for_each_sg_page(umem->sg_head.sgl, &sg_iter, umem->nmap, 0) { + if (num_buf >= RXE_BUF_PER_MAP) { + map++; + buf = map[0]->buf; + num_buf = 0; + } + + vaddr = page_address(sg_page_iter_page(&sg_iter)); + if (!vaddr) { + pr_warn("%s: Unable to get virtual address", __func__); + err = -ENOMEM; + goto err1; + } + + buf->addr = (uintptr_t)vaddr; + buf->size = PAGE_SIZE; + num_buf++; + buf++; + } + } + + mr->umem = umem; + mr->offset = ib_umem_offset(umem); + mr->state = RXE_MR_STATE_VALID; + mr->type = RXE_MR_TYPE_MR; + + return 0; + +err1: + ib_umem_release(umem); + return err; +} + int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova, int access, struct rxe_mr *mr) { - struct rxe_map **map; - struct rxe_phys_buf *buf = NULL; struct ib_umem *umem; - struct sg_page_iter sg_iter; - int num_buf; - void *vaddr; + int num_buf; int err; int i; @@ -138,43 +182,18 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova, mr->page_shift = PAGE_SHIFT; mr->page_mask = PAGE_SIZE - 1; - num_buf = 0; - map = mr->map; - if (length > 0) { - buf = map[0]->buf; - - for_each_sg_page(umem->sg_head.sgl, &sg_iter, umem->nmap, 0) { - if (num_buf >= RXE_BUF_PER_MAP) { - map++; - buf = map[0]->buf; - num_buf = 0; - } - - vaddr = page_address(sg_page_iter_page(&sg_iter)); - if (!vaddr) { - pr_warn("%s: Unable to get virtual address\n", - __func__); - err = -ENOMEM; - goto err_cleanup_map; - } - - buf->addr = (uintptr_t)vaddr; - buf->size = PAGE_SIZE; - num_buf++; - buf++; + mr->length = length; - } + err = rxe_mr_gen_map(mr, umem); + if (err) { + pr_warn("%s: Failed to map pages", __func__); + goto err_cleanup_map; } mr->ibmr.pd = &pd->ibpd; - mr->umem = umem; mr->access = access; - mr->length = length; mr->iova = iova; mr->va = start; - mr->offset = ib_umem_offset(umem); - mr->state = RXE_MR_STATE_VALID; - mr->type = RXE_MR_TYPE_MR; return 0; -- 2.17.1