From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB7AC433F5 for ; Wed, 8 Sep 2021 06:16:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4F4D61158 for ; Wed, 8 Sep 2021 06:16:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347675AbhIHGRm (ORCPT ); Wed, 8 Sep 2021 02:17:42 -0400 Received: from verein.lst.de ([213.95.11.211]:38054 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232146AbhIHGRl (ORCPT ); Wed, 8 Sep 2021 02:17:41 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6D92F67373; Wed, 8 Sep 2021 08:16:32 +0200 (CEST) Date: Wed, 8 Sep 2021 08:16:31 +0200 From: Christoph Hellwig To: Kanchan Joshi Cc: Christoph Hellwig , Kanchan Joshi , Jens Axboe , Keith Busch , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, anuj20.g@samsung.com, Javier Gonzalez , hare@suse.de Subject: Re: [RFC PATCH 6/6] nvme: enable passthrough with fixed-buffer Message-ID: <20210908061631.GB28505@lst.de> References: <20210805125539.66958-1-joshi.k@samsung.com> <20210805125539.66958-7-joshi.k@samsung.com> <20210907075055.GE29874@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Tue, Sep 07, 2021 at 10:17:53PM +0530, Kanchan Joshi wrote: > I'll do away with that comment. But sorry, what part do you think > should rather move to io_uring. Is that for the whole helper > "nvme_rq_map_user_fixed"? Yes. Nothing nvme-specific in it. Given that it only makes sense to be used for io_uring support moving it to io_uring.c might make sense. Or conditionally to block/blk-map.c. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2BF8C433F5 for ; Wed, 8 Sep 2021 06:22:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CB1E6113C for ; Wed, 8 Sep 2021 06:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6CB1E6113C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VmN8xiFmoHWu+ykbW3EXp2s/FBIIOCTHmaPb8JW6Uns=; b=EzMpYsL7BtDpcL 0kgGN2jebdwf0SH833bhAbkWCBSXgF6QoV03c6iEBn9S2qvq458GgJerFrpnizEDJWpQyPPT2fms/ qFjz7vfBSRNMRzcbV9jltaOGalFMVOXO6VXytt3pkxuuqyYSlQBWSTt0VF6pnrmobYOpM+t9bY1QL fZHpSRLfaBTOhjqFCQSemFA7FOqVjxrPyV26JOFd3/6XhF3UhMTYaYdEuM9i414QKC4cmP3seHCFa u9pd8cy7JpmVbzf+qpw37WGacVCSgzbB/LnfetAoei4Cb4ACnGoHmMs5BpAzezaggH7PccxZmvxQ7 ftjlveBr+cA7YISsaxFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNqy1-005ZdJ-6r; Wed, 08 Sep 2021 06:21:53 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNqst-005WtF-Ez for linux-nvme@lists.infradead.org; Wed, 08 Sep 2021 06:16:39 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6D92F67373; Wed, 8 Sep 2021 08:16:32 +0200 (CEST) Date: Wed, 8 Sep 2021 08:16:31 +0200 From: Christoph Hellwig To: Kanchan Joshi Cc: Christoph Hellwig , Kanchan Joshi , Jens Axboe , Keith Busch , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, anuj20.g@samsung.com, Javier Gonzalez , hare@suse.de Subject: Re: [RFC PATCH 6/6] nvme: enable passthrough with fixed-buffer Message-ID: <20210908061631.GB28505@lst.de> References: <20210805125539.66958-1-joshi.k@samsung.com> <20210805125539.66958-7-joshi.k@samsung.com> <20210907075055.GE29874@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_231635_713887_DA74019A X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Sep 07, 2021 at 10:17:53PM +0530, Kanchan Joshi wrote: > I'll do away with that comment. But sorry, what part do you think > should rather move to io_uring. Is that for the whole helper > "nvme_rq_map_user_fixed"? Yes. Nothing nvme-specific in it. Given that it only makes sense to be used for io_uring support moving it to io_uring.c might make sense. Or conditionally to block/blk-map.c. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme