From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F7DC433EF for ; Wed, 8 Sep 2021 00:34:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F3C461131 for ; Wed, 8 Sep 2021 00:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236573AbhIHAf1 (ORCPT ); Tue, 7 Sep 2021 20:35:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:47198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbhIHAf0 (ORCPT ); Tue, 7 Sep 2021 20:35:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C7E9661130; Wed, 8 Sep 2021 00:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631061259; bh=gZCHoiyYvJOBDFgLE8Co+IeXpF52HOMnDjNNoPUEA48=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fbsq7p+sBQ3L9lIV6HWb/jYT/SlisewLFImb7YXg4R2ZKBjoyhpQOcq1Syknu/M+H daU9GL0776U3rzkQvcq0x8a/mi/hHxagKU/IYHd7KnLqaci5rLyP6oukUWA9TzIIek NK0b76mRxAZPAjvXSsHh0axj3LHeg/nKPT8jSg6GvV6PojKN1eoemghoV6aHSZbJnk EFff3A20AB1DFERqoQ9VbshVsidbvYHDxRe++x0G3xOYtFavlCfz2db3dNNU70hyyL HCG2fqi+X2O6waheLYbZlm3g13bVcKcL99AVm9AQkQhcAzPqMKMRLYvoaC69OCDt9A swk0eQUtWEFRQ== Date: Wed, 8 Sep 2021 09:34:17 +0900 From: Masami Hiramatsu To: Masami Hiramatsu Cc: Punit Agrawal , linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [RESEND PATCH] tools/bootconfig: Fix a compilation issue with missing variable Message-Id: <20210908093417.6eb7244e6d5d7e8b75ab4850@kernel.org> In-Reply-To: <20210908091346.65e6c4c58bc31676e942ccb2@kernel.org> References: <20210907230710.1189193-1-punitagrawal@gmail.com> <20210908091346.65e6c4c58bc31676e942ccb2@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Sep 2021 09:13:46 +0900 Masami Hiramatsu wrote: > Hi Punit, > > This has been fixed by Julio's patch and we are waiting for merge. > > https://lore.kernel.org/all/20210831033256.5973-1-jcfaracco@gmail.com/T/#u Sorry, I missed thank you message on my previous message. That's my bad point... Anyway thanks for the report! > > Thank you, > > On Wed, 8 Sep 2021 08:07:10 +0900 > Punit Agrawal wrote: > > > While looking to build bootconfig tool in order to debug a kernel boot > > time issue I noticed that tool fails to compile. The broken changes > > were introduced by commit e5efaeb8a8f5 ("bootconfig: Support mixing a > > value and subkeys under a key"). > > > > Fix the compile issue by introducing a "ret" variable to track the > > return value from xbc_node_compose_key(). > > > > Fixes: e5efaeb8a8f5 ("bootconfig: Support mixing a value and subkeys under a key") > > Signed-off-by: Punit Agrawal > > Cc: Masami Hiramatsu > > Cc: Steven Rostedt > > --- > > > > (Apologies for the resend. I fat-fingered the email address for lkml) > > > > Hi Masami, > > > > I am not sure what went wrong but the patch in the lore link[0] > > doesn't match the end result (bad merge?). You may want to recheck the > > other changes to make sure it all looks sane. > > > > Regards, > > Punit > > > > [0] https://lkml.kernel.org/r/162262194685.264090.7738574774030567419.stgit@devnote2 > > --- > > tools/bootconfig/main.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c > > index f45fa992e01d..fd67496a947f 100644 > > --- a/tools/bootconfig/main.c > > +++ b/tools/bootconfig/main.c > > @@ -111,9 +111,11 @@ static void xbc_show_list(void) > > char key[XBC_KEYLEN_MAX]; > > struct xbc_node *leaf; > > const char *val; > > + int ret; > > > > xbc_for_each_key_value(leaf, val) { > > - if (xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX) < 0) { > > + ret = xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX); > > + if (ret < 0) { > > fprintf(stderr, "Failed to compose key %d\n", ret); > > break; > > } > > -- > > 2.32.0 > > > > > -- > Masami Hiramatsu -- Masami Hiramatsu