From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77865C433F5 for ; Wed, 8 Sep 2021 12:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5324061167 for ; Wed, 8 Sep 2021 12:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351747AbhIHMkM (ORCPT ); Wed, 8 Sep 2021 08:40:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58033 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351735AbhIHMkL (ORCPT ); Wed, 8 Sep 2021 08:40:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631104742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qJk9DPikcEEEFmKWzBbvekDGUKQO1oc5fhwtnVuechI=; b=fgWFlSwgFVb5A24gLr1gyzfzUgF0RRZNPh4MXDuYMIl+Guj+FvQ84Tgl+wks2vp4/6nLYd 9ZBL5MA95bEiBrrMoPp8i7dYUeDHWHay7+9rAArbBbu7LguUd3Fl8CSubqCQgFcvmHz+k+ DLrECC4qvuYOydf2OoS0vJFpJtowLYg= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-12-kuSR9GajOVqX2UTZ36UPeg-1; Wed, 08 Sep 2021 08:39:01 -0400 X-MC-Unique: kuSR9GajOVqX2UTZ36UPeg-1 Received: by mail-ed1-f70.google.com with SMTP id s15-20020a056402520f00b003cad788f1f6so988205edd.22 for ; Wed, 08 Sep 2021 05:39:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qJk9DPikcEEEFmKWzBbvekDGUKQO1oc5fhwtnVuechI=; b=dsQjli4ly/lEScUGpYJTfFg2Sr/nC5NwtjmbEo2dgXkAGfE9Z5DNzLeuf2FJKuHPqI yq+ajvawO6jLH9/11CqOfWtZ0eukia31WA9zCjXcvkYqQIoHI5cu1M29yKi7YjvgwYTL XXgc3XVMkRhz3bZzn115CNQfyQ9RyLYQdS3eo9tsyKETVtZrDzvJwbVPv/u2mXwzbgri AOS5NpJ5SqyitltP0fQDdlTklvQS8aAMXaPB7+UAtG6tDcUznwXGDcpJ4VMR33I9xKRB xK2bZMgFQxpLQllBn/pGJ5I/WoluoJfARGCGa8VQeWHyQtQw3d/kioerTgTbQtRMGhyQ RQvQ== X-Gm-Message-State: AOAM532KiktwAB3/E47vRXHtogqORPvzn9tBNLlht1vOEvWT9Bvfu/q8 cIXIhChv1Es2lvGTnlC1E7LmgchM/9sEjrT+oaAB+GX9XPaLDCpQvf+g/GIgfClKUvp41OTZYAP rjPlX8niTdgIf X-Received: by 2002:aa7:cfd2:: with SMTP id r18mr3792146edy.82.1631104740791; Wed, 08 Sep 2021 05:39:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjid3++di+F5iCU9+5CzYDTvq+wLZRd9DcKg7WpI/zFqCadUN/JE18oA3HheHdzPjP0LYM/w== X-Received: by 2002:aa7:cfd2:: with SMTP id r18mr3792124edy.82.1631104740608; Wed, 08 Sep 2021 05:39:00 -0700 (PDT) Received: from gator (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id bm14sm1157297edb.71.2021.09.08.05.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 05:39:00 -0700 (PDT) Date: Wed, 8 Sep 2021 14:38:58 +0200 From: Andrew Jones To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v5 3/8] KVM: arm64: Simplify masking out MTE in feature id reg Message-ID: <20210908123858.fqoltrkp3aodj4ly@gator> References: <20210827101609.2808181-1-tabba@google.com> <20210827101609.2808181-4-tabba@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210827101609.2808181-4-tabba@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Aug 27, 2021 at 11:16:04AM +0100, Fuad Tabba wrote: > Simplify code for hiding MTE support in feature id register when > MTE is not enabled/supported by KVM. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/sys_regs.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 1d46e185f31e..447acce9ca84 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -1077,14 +1077,8 @@ static u64 read_id_reg(const struct kvm_vcpu *vcpu, > val |= FIELD_PREP(ARM64_FEATURE_MASK(ID_AA64PFR0_CSV3), (u64)vcpu->kvm->arch.pfr0_csv3); > break; > case SYS_ID_AA64PFR1_EL1: > - val &= ~ARM64_FEATURE_MASK(ID_AA64PFR1_MTE); > - if (kvm_has_mte(vcpu->kvm)) { > - u64 pfr, mte; > - > - pfr = read_sanitised_ftr_reg(SYS_ID_AA64PFR1_EL1); > - mte = cpuid_feature_extract_unsigned_field(pfr, ID_AA64PFR1_MTE_SHIFT); > - val |= FIELD_PREP(ARM64_FEATURE_MASK(ID_AA64PFR1_MTE), mte); > - } > + if (!kvm_has_mte(vcpu->kvm)) > + val &= ~ARM64_FEATURE_MASK(ID_AA64PFR1_MTE); > break; > case SYS_ID_AA64ISAR1_EL1: > if (!vcpu_has_ptrauth(vcpu)) > -- > 2.33.0.259.gc128427fd7-goog > Reviewed-by: Andrew Jones From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33975C433EF for ; Wed, 8 Sep 2021 12:39:19 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 9D77C61166 for ; Wed, 8 Sep 2021 12:39:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D77C61166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3A1DD407F1; Wed, 8 Sep 2021 08:39:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cmv4NSOaHebA; Wed, 8 Sep 2021 08:39:17 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 30D194B0DD; Wed, 8 Sep 2021 08:39:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7E301407F1 for ; Wed, 8 Sep 2021 08:39:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GoNANiIr-yju for ; Wed, 8 Sep 2021 08:39:12 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E061E4B090 for ; Wed, 8 Sep 2021 08:39:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631104752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qJk9DPikcEEEFmKWzBbvekDGUKQO1oc5fhwtnVuechI=; b=VOrC+WHUNm+S7u41WiVImVFIlDxfthvppKXKyaGMHWv1FSgFCmeapTcdZx+NEN2mIafAis GRHouc7jWrSJBS2qqzsNrMDXb9tCFqceW72M72azsMJ4c3wWVmcPmmNwz/bA6LFV2a/2HU slsSaTLreZD9JtZTSITyfAbsytUtfzc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-589-LpEGetJeMju89wVuD5T6gg-1; Wed, 08 Sep 2021 08:39:11 -0400 X-MC-Unique: LpEGetJeMju89wVuD5T6gg-1 Received: by mail-wm1-f72.google.com with SMTP id y24-20020a7bcd98000000b002eb50db2b62so799724wmj.5 for ; Wed, 08 Sep 2021 05:39:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qJk9DPikcEEEFmKWzBbvekDGUKQO1oc5fhwtnVuechI=; b=WTjs8aYeuZlyoL8hS+zwJqZ8Z0uuCBNGSwKRwFrZB5sWq3w1E4rdQcyCzhFs/FmCfM pGmYfuYkbXDW/pH3IOL8bZV5bWcwOKiOejvtHl0/K49Wj3YXQw+hqA3CtPdWWcUG23ll h4ScwuiTsVbBSpSjEjT1rXNsfJ4p1ZUS2Hkt5/ds0k0gvVG8N5pj9poTi014+4uOWifE kKR36QInkJTd4k+KecoEpLWsusad47WCYt3PO9tVyYTR5oHQP+wPG5DLXDrSWEsbu7M/ nYEDm31sTPd0kjxnZSfWNtjwqjmgDnzCTBECKt6l3kITDeexSUCRD8WcM2VvQW/Ca6EH LLSw== X-Gm-Message-State: AOAM5322DI/jyGKo+lhJoel8d4UMEE3jyspSkufV40AzC4mxDrOYjQ5d 3axCNV1+vjtR9i8P7SaFOLliaXyEAzTE2dYaEfCnbn0zqW+YAvi7HmJqIEpIahqZl554GAZgfnI /yqjGIjJQe8dqWCqWQ26sfYRV X-Received: by 2002:aa7:cfd2:: with SMTP id r18mr3792145edy.82.1631104740790; Wed, 08 Sep 2021 05:39:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjid3++di+F5iCU9+5CzYDTvq+wLZRd9DcKg7WpI/zFqCadUN/JE18oA3HheHdzPjP0LYM/w== X-Received: by 2002:aa7:cfd2:: with SMTP id r18mr3792124edy.82.1631104740608; Wed, 08 Sep 2021 05:39:00 -0700 (PDT) Received: from gator (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id bm14sm1157297edb.71.2021.09.08.05.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 05:39:00 -0700 (PDT) Date: Wed, 8 Sep 2021 14:38:58 +0200 From: Andrew Jones To: Fuad Tabba Subject: Re: [PATCH v5 3/8] KVM: arm64: Simplify masking out MTE in feature id reg Message-ID: <20210908123858.fqoltrkp3aodj4ly@gator> References: <20210827101609.2808181-1-tabba@google.com> <20210827101609.2808181-4-tabba@google.com> MIME-Version: 1.0 In-Reply-To: <20210827101609.2808181-4-tabba@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: kernel-team@android.com, kvm@vger.kernel.org, maz@kernel.org, pbonzini@redhat.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Aug 27, 2021 at 11:16:04AM +0100, Fuad Tabba wrote: > Simplify code for hiding MTE support in feature id register when > MTE is not enabled/supported by KVM. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/sys_regs.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 1d46e185f31e..447acce9ca84 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -1077,14 +1077,8 @@ static u64 read_id_reg(const struct kvm_vcpu *vcpu, > val |= FIELD_PREP(ARM64_FEATURE_MASK(ID_AA64PFR0_CSV3), (u64)vcpu->kvm->arch.pfr0_csv3); > break; > case SYS_ID_AA64PFR1_EL1: > - val &= ~ARM64_FEATURE_MASK(ID_AA64PFR1_MTE); > - if (kvm_has_mte(vcpu->kvm)) { > - u64 pfr, mte; > - > - pfr = read_sanitised_ftr_reg(SYS_ID_AA64PFR1_EL1); > - mte = cpuid_feature_extract_unsigned_field(pfr, ID_AA64PFR1_MTE_SHIFT); > - val |= FIELD_PREP(ARM64_FEATURE_MASK(ID_AA64PFR1_MTE), mte); > - } > + if (!kvm_has_mte(vcpu->kvm)) > + val &= ~ARM64_FEATURE_MASK(ID_AA64PFR1_MTE); > break; > case SYS_ID_AA64ISAR1_EL1: > if (!vcpu_has_ptrauth(vcpu)) > -- > 2.33.0.259.gc128427fd7-goog > Reviewed-by: Andrew Jones _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770F9C433EF for ; Wed, 8 Sep 2021 12:40:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DF2F61163 for ; Wed, 8 Sep 2021 12:40:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3DF2F61163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jSUt/K/Gi8l0uWJG4kqRL+iOI41SNien+xcSJQM2Stg=; b=yo4yNgxrTXH3tm xTl45BRe54VvekI/WStpQ/Gv5F0XO/FgWq2LdDqKMFVyGzAhOseqor8svpFXeVYn5jNlNmS1bZ0Fj fdOD0KLB81Mm5A/NcDdEOQuwmQVAhAXu4b1JtRHTAdCu3l7kh3thM1xRsI5PBh17iEaa0BUPHBsYs 9uCSVieF4AxOhFSx/aylhdJpKzeRkOSUz0DNg9cojYwTHNWtmHKxzhWIMy29SKgzCOr5NoLNb73Tt 1ndJgXTTMOwCSFubdSGFQag7o5R7SrrTSUty2gd0w0AX8JrHNsd0o92x8L5buYKqYlvwG2n9c/EdG m/N2ulPE2n9V6MlbmQoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNwr7-006icH-AY; Wed, 08 Sep 2021 12:39:09 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNwr3-006ibi-Mx for linux-arm-kernel@lists.infradead.org; Wed, 08 Sep 2021 12:39:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631104744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qJk9DPikcEEEFmKWzBbvekDGUKQO1oc5fhwtnVuechI=; b=T6vo/4KJgBspkAzM5yIp4dNqRDE9QMpSRWaYew7TO5T2wcoxcHdsIFgqO3TggH7PwinA4a oxEtYrcVEjuBL/aNNBvB0E88bAaRA/MUiyb+Jc869N15rlt0nsMMNWY2AYUpqOC5t9lBvk LNhN2+obUvr0+RuMVTpZG+RmLlqNAMs= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-vpHC4yOLNcStd9lmTLoofQ-1; Wed, 08 Sep 2021 08:39:01 -0400 X-MC-Unique: vpHC4yOLNcStd9lmTLoofQ-1 Received: by mail-ej1-f71.google.com with SMTP id n18-20020a170906089200b005dc91303dfeso915953eje.15 for ; Wed, 08 Sep 2021 05:39:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qJk9DPikcEEEFmKWzBbvekDGUKQO1oc5fhwtnVuechI=; b=CYiOMaGI0s3bqgf3W2OJFILrzckyycex94iyTLkzCLELk7Bmib3LlxpS77S07/EgaA hScjy8xTYAoHiWXGj1XSajQnMekAJWQnB+5TQwEl4LFKQlmR1TdJ/qPIQ0w9wv1D2vPk 06JP9jqCUOGI3X4Unbv9oCqNTBJ+J/50/XAeLozGxwxI5HN8op348fB94V08KMQZgXJs PksIhRVVemDFiR7llkY6OQSaAKaW9vaFX4HPSv8aQvbBrBunTt55yuNFf9LvhdJn7ZW/ P3tsDjkfxR+5cbvZSS22AzQkaYEOXoGIPyG1jXAhwwqD3xGU/m0+XF9XRTD36imiWG/z Fc9w== X-Gm-Message-State: AOAM531ku7hmzPDnokL5dFH9WdSa8Oi1v8zmx0t/TBQwKB9Sl5pKJBAk 3Dx3+S0idju5zXJMsfvQNMbanjaMTyITX+frJLqUDtqqszt6v5CjmzpiKJ4ohv/uJ4vEXQxp8R1 JWfzbyNRTM0s7Vqg9JFsp10oH4qo4QeHTi2M= X-Received: by 2002:aa7:cfd2:: with SMTP id r18mr3792157edy.82.1631104740792; Wed, 08 Sep 2021 05:39:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjid3++di+F5iCU9+5CzYDTvq+wLZRd9DcKg7WpI/zFqCadUN/JE18oA3HheHdzPjP0LYM/w== X-Received: by 2002:aa7:cfd2:: with SMTP id r18mr3792124edy.82.1631104740608; Wed, 08 Sep 2021 05:39:00 -0700 (PDT) Received: from gator (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id bm14sm1157297edb.71.2021.09.08.05.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 05:39:00 -0700 (PDT) Date: Wed, 8 Sep 2021 14:38:58 +0200 From: Andrew Jones To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, oupton@google.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v5 3/8] KVM: arm64: Simplify masking out MTE in feature id reg Message-ID: <20210908123858.fqoltrkp3aodj4ly@gator> References: <20210827101609.2808181-1-tabba@google.com> <20210827101609.2808181-4-tabba@google.com> MIME-Version: 1.0 In-Reply-To: <20210827101609.2808181-4-tabba@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_053905_867720_5F3DEA3D X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 27, 2021 at 11:16:04AM +0100, Fuad Tabba wrote: > Simplify code for hiding MTE support in feature id register when > MTE is not enabled/supported by KVM. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/sys_regs.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 1d46e185f31e..447acce9ca84 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -1077,14 +1077,8 @@ static u64 read_id_reg(const struct kvm_vcpu *vcpu, > val |= FIELD_PREP(ARM64_FEATURE_MASK(ID_AA64PFR0_CSV3), (u64)vcpu->kvm->arch.pfr0_csv3); > break; > case SYS_ID_AA64PFR1_EL1: > - val &= ~ARM64_FEATURE_MASK(ID_AA64PFR1_MTE); > - if (kvm_has_mte(vcpu->kvm)) { > - u64 pfr, mte; > - > - pfr = read_sanitised_ftr_reg(SYS_ID_AA64PFR1_EL1); > - mte = cpuid_feature_extract_unsigned_field(pfr, ID_AA64PFR1_MTE_SHIFT); > - val |= FIELD_PREP(ARM64_FEATURE_MASK(ID_AA64PFR1_MTE), mte); > - } > + if (!kvm_has_mte(vcpu->kvm)) > + val &= ~ARM64_FEATURE_MASK(ID_AA64PFR1_MTE); > break; > case SYS_ID_AA64ISAR1_EL1: > if (!vcpu_has_ptrauth(vcpu)) > -- > 2.33.0.259.gc128427fd7-goog > Reviewed-by: Andrew Jones _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel