From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31612C433F5 for ; Wed, 8 Sep 2021 13:39:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3AA361168 for ; Wed, 8 Sep 2021 13:39:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B3AA361168 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0B62C834AD; Wed, 8 Sep 2021 15:36:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="KcFAjCyb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DD8EF833FB; Wed, 8 Sep 2021 15:35:15 +0200 (CEST) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F0A39833F8 for ; Wed, 8 Sep 2021 15:34:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wr1-x42e.google.com with SMTP id q11so3328269wrr.9 for ; Wed, 08 Sep 2021 06:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=deMD6HUNXW37pwoUeFnHnOtcaRDVD3Rl1yGIp8PWeMc=; b=KcFAjCyb22zk0E2TMmgTsxM2xQPeJZVUxLk3lY5zsbiSrjIjvYliqn/dyOr4m3CM2K W7vlU0bPExh+wLCH4vPUo3ZDjWRXWxmHby5YyN4QDPkSC65aof3V+skc3GlOayQN8Bv9 RqPrAD6JIrH+5pi9bkMA/FIQiIgQYAyleMEfg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=deMD6HUNXW37pwoUeFnHnOtcaRDVD3Rl1yGIp8PWeMc=; b=41BrpcBOb37gBXLUMTWuDK7ntOXqF7lI8gVghRT/N1LMqixbaUEJxNdIbxI1gjY4y4 z0D/wBJuBimjrI2ADIeW1LoDd3W7MH6IB75ILbk/JnsVau/y96BW3RJ3mjeckNxoeNOl Pd1dC4l8M7ypk884K/yzzCda0aJoEtUM/CLcDpDVUIqXsAwxjgci0AZjVNV+gcqyYhqD hXRGpvnB+/L7SXxYU/HBND1EpC2JgjSGbzbvpeM4maB1jwWQ8lPOzg+Vk8y5DT8KdTPG aQMs7MSSGzPt7xWH2OW9TbtFb4Iq9H9OXk3YYTJOWZ98dwNhBQAnjwaQV8qSPOmRrfZv zMgg== X-Gm-Message-State: AOAM533/OsjEDJ3M1mTGiqR7kuuWVh8BQLA/shzhzy7nDaRT8h+QOc3+ cbe+jKTnUb+xRWAGBPdi5rQD53XMWmQw2NSN X-Google-Smtp-Source: ABdhPJy+J8s0DDCPg4nOi4v7P7lrPr0ir0zVJiG0WlTdpqwTAynvIaAaU2IdVJDZdfA2hLpwh1Z31A== X-Received: by 2002:adf:eb89:: with SMTP id t9mr4280367wrn.66.1631108091162; Wed, 08 Sep 2021 06:34:51 -0700 (PDT) Received: from sjg1.roam.corp.google.com (82-69-54-180.dsl.in-addr.zen.co.uk. [82.69.54.180]) by smtp.gmail.com with ESMTPSA id l2sm2209065wmi.1.2021.09.08.06.34.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 06:34:50 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Ilias Apalodimas , Heinrich Schuchardt , Bin Meng , Tom Rini , Christian Melki , Simon Glass , Alexander Graf Subject: [PATCH 27/35] efi: Add comments to struct efi_priv Date: Wed, 8 Sep 2021 07:33:57 -0600 Message-Id: <20210908133405.696481-12-sjg@chromium.org> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog In-Reply-To: <20210908133405.696481-1-sjg@chromium.org> References: <20210908133405.696481-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This structure is uncommented. Fix it. Signed-off-by: Simon Glass --- include/efi.h | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/include/efi.h b/include/efi.h index c0fddf7f6cd..2db60a36f0b 100644 --- a/include/efi.h +++ b/include/efi.h @@ -400,15 +400,39 @@ static inline struct efi_mem_desc *efi_get_next_mem_desc( return (struct efi_mem_desc *)((ulong)desc + map->desc_size); } +/** + * struct efi_priv - Information about the environment provided by EFI + * + * @parent_image: image passed into the EFI app or stub + * @sys_table: Pointer to system table + * @boot: Pointer to boot-services table + * @run: Pointer to runtime-services table + * + * Used by app only: + * @use_pool_for_malloc: true if all allocation should go through the EFI 'pool' + * methods allocate_pool() and free_pool(); false to use 'pages' methods + * allocate_pages() and free_pages() + * @ram_base: Base address of RAM (size CONFIG_EFI_RAM_SIZE) + * @image_data_type: Type of the loaded image (e.g. EFI_LOADER_CODE) + * + * Used by stub only: + * @info: Header of the info list, holding info collected by the stub and passed + * to U-Boot + * @info_size: Size of the info list, in bytes from @info + * @next_hdr: Pointer to where to put the next header when adding to the list + */ struct efi_priv { efi_handle_t parent_image; - struct efi_device_path *device_path; struct efi_system_table *sys_table; struct efi_boot_services *boot; struct efi_runtime_services *run; + + /* app: */ bool use_pool_for_malloc; unsigned long ram_base; unsigned int image_data_type; + + /* stub: */ struct efi_info_hdr *info; unsigned int info_size; void *next_hdr; -- 2.33.0.153.gba50c8fa24-goog