From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD25C433EF for ; Wed, 8 Sep 2021 13:40:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1851D60295 for ; Wed, 8 Sep 2021 13:40:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1851D60295 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D167834C3; Wed, 8 Sep 2021 15:36:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="VncDfrhv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 05CEC833A2; Wed, 8 Sep 2021 15:35:24 +0200 (CEST) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4821683402 for ; Wed, 8 Sep 2021 15:34:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x332.google.com with SMTP id i3so1749725wmq.3 for ; Wed, 08 Sep 2021 06:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R7WVFnZYIui7iR5NHYZKFZt+Wv3h9MRJFFZiKxDGGXA=; b=VncDfrhvR5pZbNHOO7vqrnXMMwq1HsViFh7GWiDSoo5WXl0c/BEF0MlDTHPMezcYn6 gMS4wq6GYlJpHybDSUgdsbk6vuLB+6aRIOhEpDwKCJjLESrtRdG2v1tXPfwHc8OQjFyA yRhbV0Rka4OAf+fPgypQL8pKijvCGLrfpd2E4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R7WVFnZYIui7iR5NHYZKFZt+Wv3h9MRJFFZiKxDGGXA=; b=wJNEdPsIxrAYyPcKH/G2W05G8+v2xSm1xJK6qeFLmPm0zrL6r/H90h6rpYavoSelPU zR9eYggbzlRlpf+smDfkvLm+pY4A3K474htzro9KK41waDlR4lEfu0TGXnKoVemwJhYo ZlKG2Cfb1A7RdPgFShxtQeC+hZs9dZorfcxIxH8On7ICxMxen3NXEl5fjFBgen+QEzgk V9wFK6pqXFLfD2syR1ulUrLty3dIpr1w1fNkdwVxZMi+es6x6BsiWg6UGOBfOIiguOrk PlQabQGcJMa2vg1oDcJ6ZXs0+2txpbJO+71Iqk88NarjSc1sL8YXLCx4rtxLywS8sSzU kQ0Q== X-Gm-Message-State: AOAM531zK2Bf0+/V6I4gbyIFWgClOv5bZ0SI2cJ09jT/RiH8/E2M8+b5 Ho0QkI7hzkohmQNvP7qFzfdpcpo0oz4MH4ax X-Google-Smtp-Source: ABdhPJxfbqE9Cq10dbHWs+0LKbWh+G/5lwZFxV+JyS8PqRW2QjOd5V6vGX/eJRknlgStscNqbqrjFw== X-Received: by 2002:a7b:c4cb:: with SMTP id g11mr3666635wmk.80.1631108096474; Wed, 08 Sep 2021 06:34:56 -0700 (PDT) Received: from sjg1.roam.corp.google.com (82-69-54-180.dsl.in-addr.zen.co.uk. [82.69.54.180]) by smtp.gmail.com with ESMTPSA id l2sm2209065wmi.1.2021.09.08.06.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 06:34:56 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Ilias Apalodimas , Heinrich Schuchardt , Bin Meng , Tom Rini , Christian Melki , Simon Glass , Alexander Graf Subject: [PATCH 32/35] efi: Check for failure when initing the app Date: Wed, 8 Sep 2021 07:34:02 -0600 Message-Id: <20210908133405.696481-17-sjg@chromium.org> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog In-Reply-To: <20210908133405.696481-1-sjg@chromium.org> References: <20210908133405.696481-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean The stub checks for failure with efi_init(). Add this for the app as well. It is unlikely that anything can be done, but we may as well stop. Signed-off-by: Simon Glass --- lib/efi/efi_app.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/efi/efi_app.c b/lib/efi/efi_app.c index 6da3fbd5104..e0666d1fae2 100644 --- a/lib/efi/efi_app.c +++ b/lib/efi/efi_app.c @@ -221,8 +221,11 @@ efi_status_t EFIAPI efi_main(efi_handle_t image, efi_status_t ret; /* Set up access to EFI data structures */ - efi_init(priv, "App", image, sys_table); - + ret = efi_init(priv, "App", image, sys_table); + if (ret) { + printf("Failed to set up ARP: err=%lx\n", ret); + return ret; + } efi_set_priv(priv); /* -- 2.33.0.153.gba50c8fa24-goog