From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCDEC433EF for ; Wed, 8 Sep 2021 13:37:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2911561167 for ; Wed, 8 Sep 2021 13:37:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2911561167 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0F41283469; Wed, 8 Sep 2021 15:35:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="bw3ns6gI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BD4D583370; Wed, 8 Sep 2021 15:34:55 +0200 (CEST) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 03D95833BE for ; Wed, 8 Sep 2021 15:34:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wr1-x42b.google.com with SMTP id i28so3372500wrb.2 for ; Wed, 08 Sep 2021 06:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PUPrAH8mgDgsGLFcHqdrH1swODotposNL3WNMXwY+1k=; b=bw3ns6gIpE7S1uAJEUT5m2FGWk+dlsXj1qr4UwMC6n9y1Sz6Gmzcmuxa1uTtqtbjN8 M7xqHtjAsG+teE2LisUG9DTFiyjrqrCmEPtfcIEJ2BXqNmSb8b7KrqPXi92fPNsjTsge YKQpXA0fsqSRl6yIAyi4wS5+1QQsdypvGaZno= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PUPrAH8mgDgsGLFcHqdrH1swODotposNL3WNMXwY+1k=; b=iLX4iczFkHXfDIrY5/YnJLSKAL/kQZefibyPSWiKl+lFmFPba5P5zTiWXQnihJIjBM i5ZDVwz6uWgG0Sso7Sso4rtGpRuDmSkav3Fsj2lauWwAkUqezLyMShsJgiOGnK5o6hPL OqF0oj/PHJ1VZHrpmIFmAjAdvVVQ9hBXpEzEqmelN7zlJDNAT0SMlP55yi6ozxPLAI4p YBHEJHhpkfJY6gmjvvi/E87nqGyRiGsWmFSxxFUIWhQhtGTYl49JAcKZiWl+vMrLQ5Ul EcIzNXu6vUX9huFinQLoENhDEEswIwEXI4lTY942kqCH7jEmk7c3JsKFXkZmF+KVij1V fBDg== X-Gm-Message-State: AOAM5330gnBIwVuf+FpFc4YMZOgAIAD8Eh6Zo5o1PA+MT0gnaY/rgjBw aMBauKb0s5eWl68SmLpHq1zQYxJeicJh3+Ka X-Google-Smtp-Source: ABdhPJxel/XQ+xreeWAMdDNQFd8TQz3wfVPC8CfL1aiaV83y6d1gFD0VD4ooq4OBZaZ6dn1uHJcJjg== X-Received: by 2002:adf:f7cf:: with SMTP id a15mr4199941wrq.188.1631108079281; Wed, 08 Sep 2021 06:34:39 -0700 (PDT) Received: from sjg1.roam.corp.google.com (82-69-54-180.dsl.in-addr.zen.co.uk. [82.69.54.180]) by smtp.gmail.com with ESMTPSA id l2sm2209065wmi.1.2021.09.08.06.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 06:34:38 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Ilias Apalodimas , Heinrich Schuchardt , Bin Meng , Tom Rini , Christian Melki , Simon Glass Subject: [PATCH 16/35] binman: Report an error if test files fail to compile Date: Wed, 8 Sep 2021 07:33:46 -0600 Message-Id: <20210908133405.696481-4-sjg@chromium.org> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog In-Reply-To: <20210908133405.696481-1-sjg@chromium.org> References: <20210908133405.696481-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean At present any error from the 'make' command is silently swallowed by the test system. Fix this by showing it when detected. Signed-off-by: Simon Glass --- tools/binman/elf_test.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/binman/elf_test.py b/tools/binman/elf_test.py index 7a128018d9f..bcccd78c0a1 100644 --- a/tools/binman/elf_test.py +++ b/tools/binman/elf_test.py @@ -70,8 +70,12 @@ def BuildElfTestFiles(target_dir): # correctly. So drop any make flags here. if 'MAKEFLAGS' in os.environ: del os.environ['MAKEFLAGS'] - tools.Run('make', '-C', target_dir, '-f', - os.path.join(testdir, 'Makefile'), 'SRC=%s/' % testdir) + try: + tools.Run('make', '-C', target_dir, '-f', + os.path.join(testdir, 'Makefile'), 'SRC=%s/' % testdir) + except ValueError as e: + # The test system seems to suppress this in a strange way + print(e) class TestElf(unittest.TestCase): -- 2.33.0.153.gba50c8fa24-goog