From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC96C433EF for ; Wed, 8 Sep 2021 14:55:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 416246069E for ; Wed, 8 Sep 2021 14:55:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 416246069E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNyzV-0006bR-97 for qemu-devel@archiver.kernel.org; Wed, 08 Sep 2021 10:55:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNyxm-0004JK-Lv for qemu-devel@nongnu.org; Wed, 08 Sep 2021 10:54:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNyxl-00020n-3e for qemu-devel@nongnu.org; Wed, 08 Sep 2021 10:54:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631112848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F5mZkQGrfqaMGTrG34XBe66PhA6H7f6ZpkWYJPXBJzM=; b=H1yKUsotJ8wIFheUeNz7qAygry7NZI2wp8BU3EMRdTV0IIAOVh6LSxktUVnZSk06jOU5vJ XzxgCwyOYCOihmuWwl0Lx8UdeUdD9BHZgLxG+6jJzNun5BGLSNN+vPFf3dkg3VpV2N9i8j mjlndmFimYsRH7qQjFEoOYeK7VJs/OQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-L8rqdzyJMwipUUrK1Xnn-w-1; Wed, 08 Sep 2021 10:54:06 -0400 X-MC-Unique: L8rqdzyJMwipUUrK1Xnn-w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EAC69801A92; Wed, 8 Sep 2021 14:54:05 +0000 (UTC) Received: from redhat.com (ovpn-113-24.phx2.redhat.com [10.3.113.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8CF4C6B556; Wed, 8 Sep 2021 14:54:05 +0000 (UTC) Date: Wed, 8 Sep 2021 09:54:03 -0500 From: Eric Blake To: Paolo Bonzini Subject: Re: [PULL v4 36/43] sgx-epc: Add the fill_device_info() callback support Message-ID: <20210908145403.bup6hhx47x7qkxkt@redhat.com> References: <20210908100426.264356-1-pbonzini@redhat.com> <20210908100426.264356-37-pbonzini@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210908100426.264356-37-pbonzini@redhat.com> User-Agent: NeoMutt/20210205-739-420e15 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.393, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yang Zhong , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 08, 2021 at 12:04:19PM +0200, Paolo Bonzini wrote: > From: Yang Zhong > > Since there is no fill_device_info() callback support, and when we > execute "info memory-devices" command in the monitor, the segfault > will be found. > > This patch will add this callback support and "info memory-devices" > will show sgx epc memory exposed to guest. The result as below: > > +++ b/qapi/machine.json > @@ -1220,6 +1220,29 @@ > 'data': { 'sgx-epc': ['SgxEPC'] } > } > > +## > +# @SgxEPCDeviceInfo: > +# > +# Sgx EPC state information > +# > +# @id: device's ID > +# > +# @memaddr: physical address in memory, where device is mapped > +# > +# @size: size of memory that the device provides > +# > +# @memdev: memory backend linked with device > +# > +# Since: 6.1 And another spot for a followup patch for 6.2 designation. > +## > +{ 'struct': 'SgxEPCDeviceInfo', > + 'data': { '*id': 'str', > + 'memaddr': 'size', > + 'size': 'size', > + 'memdev': 'str' > + } > +} > + > ## > # @MemoryDeviceInfo: > # > @@ -1234,7 +1257,8 @@ > 'data': { 'dimm': 'PCDIMMDeviceInfo', > 'nvdimm': 'PCDIMMDeviceInfo', > 'virtio-pmem': 'VirtioPMEMDeviceInfo', > - 'virtio-mem': 'VirtioMEMDeviceInfo' > + 'virtio-mem': 'VirtioMEMDeviceInfo', > + 'sgx-epc': 'SgxEPCDeviceInfo' > } > } > > -- > 2.31.1 > > > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org