All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Greentime Hu <green.hu@gmail.com>,
	kernel test robot <rong.a.chen@intel.com>,
	Nick Hu <nickhu@andestech.com>,
	Vincent Chen <deanbo422@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Mike Rapoport <rppt@linux.ibm.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] nds32/setup: remove unused memblock_region variable in setup_memory()
Date: Wed, 8 Sep 2021 08:20:26 -0700	[thread overview]
Message-ID: <20210908152026.GA389642@roeck-us.net> (raw)
In-Reply-To: <20210712125218.28951-1-rppt@kernel.org>

On Mon, Jul 12, 2021 at 03:52:18PM +0300, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> kernel test robot reports unused variable warning:
> 
> cppcheck possible warnings: (new ones prefixed by >>, may not real
> problems)
> 
> >> arch/nds32/kernel/setup.c:247:26: warning: Unused variable: region
> >> [unusedVariable]
>     struct memblock_region *region;
>                             ^
> 
> Remove the unused variable.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>

This is now fatal.

arch/nds32/kernel/setup.c: In function 'setup_memory':
arch/nds32/kernel/setup.c:247:26: error: unused variable 'region'

Anyone care to apply it ?

Guenter

> ---
>  arch/nds32/kernel/setup.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/nds32/kernel/setup.c b/arch/nds32/kernel/setup.c
> index 41725eaf8bac..b3d34d646652 100644
> --- a/arch/nds32/kernel/setup.c
> +++ b/arch/nds32/kernel/setup.c
> @@ -244,7 +244,6 @@ static void __init setup_memory(void)
>  	unsigned long ram_start_pfn;
>  	unsigned long free_ram_start_pfn;
>  	phys_addr_t memory_start, memory_end;
> -	struct memblock_region *region;
>  
>  	memory_end = memory_start = 0;
>  
> 
> base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3
> -- 
> 2.28.0
> 

      reply	other threads:[~2021-09-08 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 12:52 Mike Rapoport
2021-09-08 15:20 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210908152026.GA389642@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=akpm@linux-foundation.org \
    --cc=deanbo422@gmail.com \
    --cc=green.hu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=nickhu@andestech.com \
    --cc=rong.a.chen@intel.com \
    --cc=rppt@kernel.org \
    --cc=rppt@linux.ibm.com \
    --subject='Re: [PATCH] nds32/setup: remove unused memblock_region variable in setup_memory()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.