From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0781272 for ; Wed, 8 Sep 2021 19:10:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 91A8B610A3; Wed, 8 Sep 2021 19:10:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631128238; bh=u+kiB7HjM/T2FYDJZafBBCyh264F1JkNmR2O3D1dGFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VtVlbnoJHzuw7p5S8oEbWCYN53Ft21MwQqoi5TT79B4FohAom59y3Sqqv23CdqaPw 6J8ne7qaXe6moF+J0a2RyeD3S2cy7ngOmQfg614RED+8dJrn5XZyPgL/9jgZyEf4rb ZsTgb4qgYxGmADi4mQvOWoKLeisZ1+CWOhY5avQgKQA+xGKLLoUhe3TzLETQy582ya FTl2VMSQhVhdglMbaLRpQYxZv4zi9xqrhREol4r6/tGCviNb1Cg2QB06L6lZrKVQZJ cctovkFaUceohBdKpzuQvKQiIJF5HdUX8nL3AdDcTb555NEsRUeht9fnoDDpLvy039 mmdrzr6fcpIcg== Received: by pali.im (Postfix) id 4F78D708; Wed, 8 Sep 2021 21:10:36 +0200 (CEST) Date: Wed, 8 Sep 2021 21:10:36 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Kari Argillander Cc: Konstantin Komarov , ntfs3@lists.linux.dev, Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Christian Brauner Subject: Re: [PATCH v4 1/9] fs/ntfs3: Remove unnecesarry mount option noatime Message-ID: <20210908191036.ztjy7eoitrxujqcu@pali> References: <20210907153557.144391-1-kari.argillander@gmail.com> <20210907153557.144391-2-kari.argillander@gmail.com> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210907153557.144391-2-kari.argillander@gmail.com> User-Agent: NeoMutt/20180716 On Tuesday 07 September 2021 18:35:49 Kari Argillander wrote: > Remove unnecesarry mount option noatime because this will be handled > by VFS. Our option parser will never get opt like this. > > Acked-by: Christian Brauner > Reviewed-by: Christoph Hellwig > Signed-off-by: Kari Argillander Reviewed-by: Pali Rohár > --- > Documentation/filesystems/ntfs3.rst | 4 ---- > fs/ntfs3/super.c | 7 ------- > 2 files changed, 11 deletions(-) > > diff --git a/Documentation/filesystems/ntfs3.rst b/Documentation/filesystems/ntfs3.rst > index ffe9ea0c1499..af7158de6fde 100644 > --- a/Documentation/filesystems/ntfs3.rst > +++ b/Documentation/filesystems/ntfs3.rst > @@ -85,10 +85,6 @@ acl Support POSIX ACLs (Access Control Lists). Effective if > supported by Kernel. Not to be confused with NTFS ACLs. > The option specified as acl enables support for POSIX ACLs. > > -noatime All files and directories will not update their last access > - time attribute if a partition is mounted with this parameter. > - This option can speed up file system operation. > - > =============================================================================== > > ToDo list > diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c > index 55bbc9200a10..a18b99a3e3b5 100644 > --- a/fs/ntfs3/super.c > +++ b/fs/ntfs3/super.c > @@ -223,7 +223,6 @@ enum Opt { > Opt_nohidden, > Opt_showmeta, > Opt_acl, > - Opt_noatime, > Opt_nls, > Opt_prealloc, > Opt_no_acs_rules, > @@ -242,7 +241,6 @@ static const match_table_t ntfs_tokens = { > { Opt_sparse, "sparse" }, > { Opt_nohidden, "nohidden" }, > { Opt_acl, "acl" }, > - { Opt_noatime, "noatime" }, > { Opt_showmeta, "showmeta" }, > { Opt_nls, "nls=%s" }, > { Opt_prealloc, "prealloc" }, > @@ -333,9 +331,6 @@ static noinline int ntfs_parse_options(struct super_block *sb, char *options, > ntfs_err(sb, "support for ACL not compiled in!"); > return -EINVAL; > #endif > - case Opt_noatime: > - sb->s_flags |= SB_NOATIME; > - break; > case Opt_showmeta: > opts->showmeta = 1; > break; > @@ -587,8 +582,6 @@ static int ntfs_show_options(struct seq_file *m, struct dentry *root) > seq_puts(m, ",prealloc"); > if (sb->s_flags & SB_POSIXACL) > seq_puts(m, ",acl"); > - if (sb->s_flags & SB_NOATIME) > - seq_puts(m, ",noatime"); > > return 0; > } > -- > 2.25.1 >