From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2847EC433EF for ; Thu, 9 Sep 2021 01:26:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A28286108D for ; Thu, 9 Sep 2021 01:26:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A28286108D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 166D3834A6; Thu, 9 Sep 2021 03:25:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FqwBKxfF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6489D83491; Thu, 9 Sep 2021 03:25:40 +0200 (CEST) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DD40D83486 for ; Thu, 9 Sep 2021 03:25:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id b14so121209qtb.0 for ; Wed, 08 Sep 2021 18:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zaA+MeDWg9LuK7SQv6Khw9SKYfXl5dKwphNoWixHWR4=; b=FqwBKxfF8Aoo7Kb7NxI0eCQ4H9de15xKolu6e2SsKEDih7CqOL/GkuPU4b1IGZKurG VygAUof3dcqPYOqVrLfol0V7oUBHd3FR5J2R3gbb65YRJXJHXBUgemUEPK4kQ+Ozs6T6 /RS0APPmrid6Qkha2IPcSFiMXII/Q3XkMbWG4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zaA+MeDWg9LuK7SQv6Khw9SKYfXl5dKwphNoWixHWR4=; b=z2ePYB/d/3GIuYKLOf9nrK3aj/TWy1oC+TGEb6e1ACa5CPtMjfsIr/I3iF8Yh5n0gD pE5gzWbIB/AuqKPlZ3g+qLSC9NCiXKbKhOGjo4BhrDIMpfHL26Yecjn+pmgizB53xWHV nldmM4OunW2u8KNZxymU0W83Q9IWGdIAp+3fSgHLYs0VzuXKZxMv14ZaY8IF3DO17Bj9 5g0Bb4oP2+ui+O9AYAbEpQ3Wmq14uRKQkJkUyBMSwwcH2EtNwYG6ptsQ7WAmZvsG442k qBNRjvqy6H7TDCxm6O7PXI9eWn1piilNYqApWfTSw8X9/FMGIBuohRT9WjBaBZGFaGVU AboA== X-Gm-Message-State: AOAM532AO1LD31nYC246UfnSZgSl71cHpX6XfhPWREFacg9wUJi3BpTU 4zrASxagtlIb4AJIouNLVlkoLA== X-Google-Smtp-Source: ABdhPJxD9HlOsQ5P+PAhZpxc++QYX53ieiTPOHfRWbNu/6Majn2lQoCvZOYb/IAF6eO4dyoXbYYTYw== X-Received: by 2002:ac8:7d43:: with SMTP id h3mr542941qtb.181.1631150733710; Wed, 08 Sep 2021 18:25:33 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f91e-f867-d1bc-397d.res6.spectrum.com. [2603:6081:7b01:cbda:f91e:f867:d1bc:397d]) by smtp.gmail.com with ESMTPSA id d20sm283928qkl.13.2021.09.08.18.25.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Sep 2021 18:25:33 -0700 (PDT) Date: Wed, 8 Sep 2021 21:25:31 -0400 From: Tom Rini To: Alexandru Gagniuc Cc: u-boot@lists.denx.de, sjg@chromium.org Subject: Re: [PATCH v2 5/6] image: Drop if/elseif hash selection in calculate_hash() Message-ID: <20210909012531.GT12964@bill-the-cat> References: <20210903005422.1336362-1-mr.nuke.me@gmail.com> <20210903005422.1336362-6-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6pllAmZw5nNZD8Lv" Content-Disposition: inline In-Reply-To: <20210903005422.1336362-6-mr.nuke.me@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --6pllAmZw5nNZD8Lv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2021 at 07:54:21PM -0500, Alexandru Gagniuc wrote: > calculate_hash() would try to select the appropriate hashing function > by a if/elseif contruct. But that is exactly why hash_lookup_algo() > exists, so use it instead. >=20 > This does mean that we now have to 'select HASH' to make sure we get > the hash_lookup_algo() symbol. However, the change makes sense because > even basic FITs will have to deal with "hash" nodes. >=20 > My only concern is that the 'select SPL_HASH' might cause some > platform to grow above its SPL size allowance >=20 > Signed-off-by: Alexandru Gagniuc Applied to u-boot/master, thanks! --=20 Tom --6pllAmZw5nNZD8Lv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE5YosACgkQFHw5/5Y0 tyzbpAv/XnRe707T+mezUG2iH8qb208xmpBRff3sXWcsbuL5qzgjAQmd6ZdC1gTc MLk9ZDO49twZdiChcDQh/4/80WVAo+rANxbQE6Jh7lNDyUFs3uHGdcNS+Se7wcuf IRMEESwNMDtU4bnwY43AiaOnUVXKsl+Ysw5PmcPKXpxisZCbY3LjusP9lN4ma+zD GVbtlEeJN3K3p4m2e4866UGkvHdCxxy/P3g1cp/10hLCZJBufCQfnMQKhxoBHRbF KnoyoV6sGVCMIKTMCjwPDCWVro1tob4euJ8zoGT+kzzw/G/MCIYXbGqFqkUDHXaK ohpml7MuPrgy3Qdpzzx5Qalhq7BOFqnXyIJ4Mlx9DAednr+b0E6DZi2N1pBGANJr pKSsmEuMbxpB4Z91JSedNnNvRmTMNZr7AZu8DqrzekitirwFaXLzLwMwzE2wXaCO P4z0VGeJquvOTwNjnt/8nlvZjD4wmU3by9tU2T/HIS4dCvZchUqr7ptIwLOr/Hcs uIJmYuDm =Ish7 -----END PGP SIGNATURE----- --6pllAmZw5nNZD8Lv--