All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 3/4 v0.5] sched/umcg: RFC: implement UMCG syscalls
Date: Thu, 09 Sep 2021 06:02:37 +0800	[thread overview]
Message-ID: <202109090545.6ogU64Yq-lkp@intel.com> (raw)
In-Reply-To: <20210908184905.163787-4-posk@google.com>

[-- Attachment #1: Type: text/plain, Size: 4591 bytes --]

Hi Peter,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on tip/sched/core]
[cannot apply to tip/master asm-generic/master linus/master tip/x86/asm v5.14 next-20210908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Peter-Oskolkov/sched-umcg-RFC-UMCG-patchset/20210909-025118
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git b542e383d8c005f06a131e2b40d5889b812f19c6
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d83715835a24d5fa6541b50776b2d3bfcc3db7d9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Peter-Oskolkov/sched-umcg-RFC-UMCG-patchset/20210909-025118
        git checkout d83715835a24d5fa6541b50776b2d3bfcc3db7d9
        # save the attached .config to linux build tree
        make W=1 ARCH=um SUBARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from kernel/sched/core.c:29:
   kernel/sched/umcg.h: In function 'cmpxchg_user_32':
>> kernel/sched/umcg.h:100:3: error: implicit declaration of function '__uaccess_begin_nospec' [-Werror=implicit-function-declaration]
     100 |   __uaccess_begin_nospec();
         |   ^~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/core.c: In function 'ttwu_stat':
   kernel/sched/core.c:3466:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable]
    3466 |  struct rq *rq;
         |             ^~
   cc1: some warnings being treated as errors


vim +/__uaccess_begin_nospec +100 kernel/sched/umcg.h

cd5a21da83e15868 Peter Oskolkov 2021-09-08   80  
cd5a21da83e15868 Peter Oskolkov 2021-09-08   81  /**
cd5a21da83e15868 Peter Oskolkov 2021-09-08   82   * cmpxchg_32_user - compare_exchange 32-bit values
cd5a21da83e15868 Peter Oskolkov 2021-09-08   83   *
cd5a21da83e15868 Peter Oskolkov 2021-09-08   84   * Return:
cd5a21da83e15868 Peter Oskolkov 2021-09-08   85   * 0 - OK
cd5a21da83e15868 Peter Oskolkov 2021-09-08   86   * -EFAULT: memory access error
cd5a21da83e15868 Peter Oskolkov 2021-09-08   87   * -EAGAIN: @expected did not match; consult @prev
cd5a21da83e15868 Peter Oskolkov 2021-09-08   88   */
cd5a21da83e15868 Peter Oskolkov 2021-09-08   89  static inline int cmpxchg_user_32(u32 __user *uaddr, u32 *old, u32 new)
cd5a21da83e15868 Peter Oskolkov 2021-09-08   90  {
cd5a21da83e15868 Peter Oskolkov 2021-09-08   91  	int ret = -EFAULT;
cd5a21da83e15868 Peter Oskolkov 2021-09-08   92  	u32 __old = *old;
cd5a21da83e15868 Peter Oskolkov 2021-09-08   93  
cd5a21da83e15868 Peter Oskolkov 2021-09-08   94  	if (unlikely(!access_ok(uaddr, sizeof(*uaddr))))
cd5a21da83e15868 Peter Oskolkov 2021-09-08   95  		return -EFAULT;
cd5a21da83e15868 Peter Oskolkov 2021-09-08   96  
cd5a21da83e15868 Peter Oskolkov 2021-09-08   97  	pagefault_disable();
cd5a21da83e15868 Peter Oskolkov 2021-09-08   98  
cd5a21da83e15868 Peter Oskolkov 2021-09-08   99  	while (true) {
cd5a21da83e15868 Peter Oskolkov 2021-09-08 @100  		__uaccess_begin_nospec();
cd5a21da83e15868 Peter Oskolkov 2021-09-08  101  		ret = __try_cmpxchg_user_32(old, uaddr, __old, new);
cd5a21da83e15868 Peter Oskolkov 2021-09-08  102  		user_access_end();
cd5a21da83e15868 Peter Oskolkov 2021-09-08  103  
cd5a21da83e15868 Peter Oskolkov 2021-09-08  104  		if (!ret) {
cd5a21da83e15868 Peter Oskolkov 2021-09-08  105  			ret =  *old == __old ? 0 : -EAGAIN;
cd5a21da83e15868 Peter Oskolkov 2021-09-08  106  			break;
cd5a21da83e15868 Peter Oskolkov 2021-09-08  107  		}
cd5a21da83e15868 Peter Oskolkov 2021-09-08  108  
cd5a21da83e15868 Peter Oskolkov 2021-09-08  109  		if (fix_pagefault((unsigned long)uaddr, true) < 0)
cd5a21da83e15868 Peter Oskolkov 2021-09-08  110  			break;
cd5a21da83e15868 Peter Oskolkov 2021-09-08  111  	}
cd5a21da83e15868 Peter Oskolkov 2021-09-08  112  
cd5a21da83e15868 Peter Oskolkov 2021-09-08  113  	pagefault_enable();
cd5a21da83e15868 Peter Oskolkov 2021-09-08  114  	return ret;
cd5a21da83e15868 Peter Oskolkov 2021-09-08  115  }
cd5a21da83e15868 Peter Oskolkov 2021-09-08  116  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 8652 bytes --]

  reply	other threads:[~2021-09-08 22:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 18:49 [PATCH 0/4 v0.5] sched/umcg: RFC UMCG patchset Peter Oskolkov
2021-09-08 18:49 ` [PATCH 1/4 v0.5] sched/umcg: add WF_CURRENT_CPU and externise ttwu Peter Oskolkov
2021-09-08 18:49 ` [PATCH 2/4 v0.5] sched/umcg: RFC: add userspace atomic helpers Peter Oskolkov
2021-09-08 23:38   ` Jann Horn
2021-09-09  1:16     ` Jann Horn
2021-09-09 19:06     ` Peter Oskolkov
2021-09-09 21:20       ` Jann Horn
2021-09-09 22:09         ` Peter Oskolkov
2021-09-09 23:13           ` Jann Horn
2021-09-14 16:52         ` Andy Lutomirski
2021-09-14 18:11           ` Peter Zijlstra
2021-09-14 18:40             ` Andy Lutomirski
2021-09-15 15:42               ` Peter Zijlstra
2021-09-15 16:50                 ` Andy Lutomirski
2021-09-15 19:10                   ` Peter Zijlstra
2021-09-14  8:07       ` Peter Zijlstra
2021-09-14 16:29         ` Peter Oskolkov
2021-09-14 18:04           ` Peter Zijlstra
2021-09-14 18:15             ` Peter Zijlstra
2021-09-14 18:29             ` Peter Oskolkov
2021-09-14 18:48               ` Peter Oskolkov
2021-09-08 18:49 ` [PATCH 3/4 v0.5] sched/umcg: RFC: implement UMCG syscalls Peter Oskolkov
2021-09-08 22:02   ` kernel test robot [this message]
2021-09-09  1:39   ` Jann Horn
2021-09-14 16:51     ` Peter Oskolkov
2021-09-09 11:25   ` kernel test robot
2021-09-08 18:49 ` [PATCH 4/4 v0.5] sched/umcg: add Documentation/userspace-api/umcg.rst Peter Oskolkov
2021-09-14 16:35   ` Tao Zhou
2021-09-14 16:57     ` Peter Oskolkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202109090545.6ogU64Yq-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.