From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 067BCC433F5 for ; Thu, 9 Sep 2021 07:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C92ED60F11 for ; Thu, 9 Sep 2021 07:50:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbhIIHvW (ORCPT ); Thu, 9 Sep 2021 03:51:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbhIIHvV (ORCPT ); Thu, 9 Sep 2021 03:51:21 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BC6CC061575 for ; Thu, 9 Sep 2021 00:50:12 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOEow-00026M-L0; Thu, 09 Sep 2021 09:50:06 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mOEov-00079t-Bq; Thu, 09 Sep 2021 09:50:05 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mOEov-0005KO-AE; Thu, 09 Sep 2021 09:50:05 +0200 Date: Thu, 9 Sep 2021 09:50:05 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] ARM: dts: armada-{370,xp}: drop "marvell,orion-spi" from SPI controllers Message-ID: <20210909075005.fxy4vfarrvnmr6ez@pengutronix.de> References: <20161207152109.17545-1-uwe@kleine-koenig.org> <87eg1jhi4l.fsf@free-electrons.com> <20161207154145.yr2iua73xnoyjsse@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="34r7idygry2toucy" Content-Disposition: inline In-Reply-To: <20161207154145.yr2iua73xnoyjsse@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --34r7idygry2toucy Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Wed, Dec 07, 2016 at 04:41:45PM +0100, Uwe Kleine-K=F6nig wrote: > Hello Gregory, >=20 > On Wed, Dec 07, 2016 at 04:30:02PM +0100, Gregory CLEMENT wrote: > > On mer., d=E9c. 07 2016, Uwe Kleine-K=F6nig wr= ote: > >=20 > > > From: Uwe Kleine-K=F6nig > > > > > > The SPI controllers on Armada 370 and XP differ from the original Ori= on > > > SPI controllers (at least) in the configuration of the baud rate. So > > > it's wrong to claim compatibility which results in bogus baud rates. > >=20 > > Until two years ago with the commits > > df59fa7f4bca9658b75f0f5fee225b3a057475c5 and > > 4dacccfac69494ba70248b134352f299171c41b7 > > we used "marvell,orion-spi" compatible on Armada XP and Armada 370 > > without any problem. > >=20 > > The new compatible "marvell,armada-xp-spi" and "marvell,armada-xp-spi" > > allows to have more choice for the baudrate for a given clock but it is > > not true that Armada 370 and Armada XP are not compatible with > > "marvell,orion-spi". >=20 > The issue I was faced with that made me create this patch is that in > barebox no special case for 370/XP was active. The result was that a > device that could be operated at 60 MHz only got a clock of 11 MHz and > the driver assumed it configured 41.666 MHz. I didn't check if the same > can happen in the opposite direction (or if there are other important > incompatibilities) but still I'd say this is a bug with my patch being > the obvious fix. I just found this patch in an old branch and wonder what do to with it. It still applies fine at least. (If the original patch already disappeared from your inbox, it can be found at https://lore.kernel.org/r/20161207152109.17545-1-uwe@kleine-koenig= =2Eorg/ ) Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --34r7idygry2toucy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmE5vKoACgkQwfwUeK3K 7AmREgf/ZxDuWTyugvY5XoQ9RTCGvZsfeIfXE28DjDWcSMVB7nl7ejcCiJH/mgec 64SeDWY5fHQqA+O78F0XaxlE6xp3grf8Z+MXT4YvXjCEx+nsDwpHcXd2yfa+3RhB sinxDSA1gb2uxISaaqz6f/kiGYPvYK3s/v8+9eJYOSYMKDpcGvr4EbpDh2o4VJzV cKCPBKxt7OtKIovPdYZeKnrFBLocEXZQxp46wpCLGWNOTYtwfEyvHghYdBZDyNPj K8w5EODNFZp8kpC9/vQYYF0smZdIhnvqFp37kv+lYoDWBZ5OQvabPw3xq+tr5o1w zxHc7rnqKGvQee+Gvz+azek2E1qchQ== =jM/M -----END PGP SIGNATURE----- --34r7idygry2toucy-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66208C433EF for ; Thu, 9 Sep 2021 07:52:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29EBB60F5B for ; Thu, 9 Sep 2021 07:52:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 29EBB60F5B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nQDk2ZHGp8uGqW06PXqEQR6AXDz+Mtb8S1LicnRrcpw=; b=kQV9D8c8zXhy3suT2RZLhXs0et WxTpitNBhxYBpwLMQKJpjZbLiL7wPUhwo9kuVztqqH94DuOWg3aVw0vhktmyYU6LjfmK85GR3f59z y94l4n1dEvemsNDD++jzr+RTeUxTD/rVqH92d2HRs5j9whyv8fFimM9YA7EE8Y0T86vTyzMNegUsH B5mpLi4D8xMjrWvCobMyBLcE80u6GSUSR2Yc3xPisuU2vmxofOq+4luRZVK3uR36X4Zv6ySX5B4PP mJDDtP/FH59aztAMGlSu0nfwTxuLabhpJflWeXGsqtxFE2l+toI0dSuDqztP/boFnN8gEDLS2o89r EyBkp2SQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOEp7-008Tv6-BD; Thu, 09 Sep 2021 07:50:17 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOEp3-008TuU-1O for linux-arm-kernel@lists.infradead.org; Thu, 09 Sep 2021 07:50:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOEow-00026M-L0; Thu, 09 Sep 2021 09:50:06 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mOEov-00079t-Bq; Thu, 09 Sep 2021 09:50:05 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mOEov-0005KO-AE; Thu, 09 Sep 2021 09:50:05 +0200 Date: Thu, 9 Sep 2021 09:50:05 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] ARM: dts: armada-{370, xp}: drop "marvell, orion-spi" from SPI controllers Message-ID: <20210909075005.fxy4vfarrvnmr6ez@pengutronix.de> References: <20161207152109.17545-1-uwe@kleine-koenig.org> <87eg1jhi4l.fsf@free-electrons.com> <20161207154145.yr2iua73xnoyjsse@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20161207154145.yr2iua73xnoyjsse@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210909_005013_132079_82A76248 X-CRM114-Status: GOOD ( 30.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8015388167398365052==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8015388167398365052== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="34r7idygry2toucy" Content-Disposition: inline --34r7idygry2toucy Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Wed, Dec 07, 2016 at 04:41:45PM +0100, Uwe Kleine-K=F6nig wrote: > Hello Gregory, >=20 > On Wed, Dec 07, 2016 at 04:30:02PM +0100, Gregory CLEMENT wrote: > > On mer., d=E9c. 07 2016, Uwe Kleine-K=F6nig wr= ote: > >=20 > > > From: Uwe Kleine-K=F6nig > > > > > > The SPI controllers on Armada 370 and XP differ from the original Ori= on > > > SPI controllers (at least) in the configuration of the baud rate. So > > > it's wrong to claim compatibility which results in bogus baud rates. > >=20 > > Until two years ago with the commits > > df59fa7f4bca9658b75f0f5fee225b3a057475c5 and > > 4dacccfac69494ba70248b134352f299171c41b7 > > we used "marvell,orion-spi" compatible on Armada XP and Armada 370 > > without any problem. > >=20 > > The new compatible "marvell,armada-xp-spi" and "marvell,armada-xp-spi" > > allows to have more choice for the baudrate for a given clock but it is > > not true that Armada 370 and Armada XP are not compatible with > > "marvell,orion-spi". >=20 > The issue I was faced with that made me create this patch is that in > barebox no special case for 370/XP was active. The result was that a > device that could be operated at 60 MHz only got a clock of 11 MHz and > the driver assumed it configured 41.666 MHz. I didn't check if the same > can happen in the opposite direction (or if there are other important > incompatibilities) but still I'd say this is a bug with my patch being > the obvious fix. I just found this patch in an old branch and wonder what do to with it. It still applies fine at least. (If the original patch already disappeared from your inbox, it can be found at https://lore.kernel.org/r/20161207152109.17545-1-uwe@kleine-koenig= =2Eorg/ ) Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --34r7idygry2toucy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmE5vKoACgkQwfwUeK3K 7AmREgf/ZxDuWTyugvY5XoQ9RTCGvZsfeIfXE28DjDWcSMVB7nl7ejcCiJH/mgec 64SeDWY5fHQqA+O78F0XaxlE6xp3grf8Z+MXT4YvXjCEx+nsDwpHcXd2yfa+3RhB sinxDSA1gb2uxISaaqz6f/kiGYPvYK3s/v8+9eJYOSYMKDpcGvr4EbpDh2o4VJzV cKCPBKxt7OtKIovPdYZeKnrFBLocEXZQxp46wpCLGWNOTYtwfEyvHghYdBZDyNPj K8w5EODNFZp8kpC9/vQYYF0smZdIhnvqFp37kv+lYoDWBZ5OQvabPw3xq+tr5o1w zxHc7rnqKGvQee+Gvz+azek2E1qchQ== =jM/M -----END PGP SIGNATURE----- --34r7idygry2toucy-- --===============8015388167398365052== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8015388167398365052==--