From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>,
Wei Liu <wl@xen.org>
Subject: Re: [PATCH 2/2] stubdom: disable building pv-grub
Date: Thu, 9 Sep 2021 11:04:21 +0200 [thread overview]
Message-ID: <20210909090421.yn222xbmci425box@begin> (raw)
In-Reply-To: <20210909082705.9434-3-jgross@suse.com>
Juergen Gross, le jeu. 09 sept. 2021 10:27:05 +0200, a ecrit:
> The stubdom based pv-grub is using a very outdated version of grub
> (0.97) and should not be used any longer. Mainline grub has support for
> PV guests for a long time now, so that should be used as a boot loader
> of a PV domain.
>
> So disable building pv-grub per default. In case someone really wants
> to continue using it he/she can still use a pv-grub binary from an older
> Xen version or manually enable building it via:
>
> configure --enable-pv-grub
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> stubdom/configure | 8 ++------
> stubdom/configure.ac | 2 +-
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/stubdom/configure b/stubdom/configure
> index aa48df986d..df31532abb 100755
> --- a/stubdom/configure
> +++ b/stubdom/configure
> @@ -1342,7 +1342,7 @@ Optional Features:
> --enable-ioemu-stubdom Build and install ioemu-stubdom
> --enable-c-stubdom Build and install c-stubdom (default is DISABLED)
> --enable-caml-stubdom Build and install caml-stubdom (default is DISABLED)
> - --disable-pv-grub Build and install pv-grub (default is ENABLED)
> + --enable-pv-grub Build and install pv-grub (default is DISABLED)
> --disable-xenstore-stubdom
> Build and install xenstore-stubdom (default is
> ENABLED)
> @@ -2129,11 +2129,7 @@ fi
> else
>
>
> -grub=y
> -STUBDOM_TARGETS="$STUBDOM_TARGETS grub"
> -STUBDOM_BUILD="$STUBDOM_BUILD pv-grub"
> -STUBDOM_INSTALL="$STUBDOM_INSTALL install-grub"
> -STUBDOM_UNINSTALL="$STUBDOM_UNINSTALL install-grub"
> +grub=n
>
>
> fi
> diff --git a/stubdom/configure.ac b/stubdom/configure.ac
> index bd6f765929..a07a1edae5 100644
> --- a/stubdom/configure.ac
> +++ b/stubdom/configure.ac
> @@ -21,7 +21,7 @@ m4_include([../m4/fetcher.m4])
> AX_STUBDOM_CONDITIONAL([ioemu-stubdom], [ioemu])
> AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
> AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml])
> -AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
> +AX_STUBDOM_DEFAULT_DISABLE([pv-grub], [grub])
> AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
> AX_STUBDOM_DEFAULT_ENABLE([xenstorepvh-stubdom], [xenstorepvh])
> AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
> --
> 2.26.2
>
--
Samuel
<Raize> can you guys see what I type?
<vecna> no, raize
<Raize> How do I set it up so you can see it?
next prev parent reply other threads:[~2021-09-09 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 8:27 [PATCH 0/2] stubdom: disable building of pv-grub per default Juergen Gross
2021-09-09 8:27 ` [PATCH 1/2] stubdom: fix build with disabled pv-grub Juergen Gross
2021-09-09 9:03 ` Samuel Thibault
2021-09-09 8:27 ` [PATCH 2/2] stubdom: disable building pv-grub Juergen Gross
2021-09-09 9:04 ` Samuel Thibault [this message]
2021-09-09 8:44 ` [PATCH 0/2] stubdom: disable building of pv-grub per default Jan Beulich
2021-09-09 8:52 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909090421.yn222xbmci425box@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=iwj@xenproject.org \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.