All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kuznetsov <wwfq@yandex-team.ru>
To: netdev@vger.kernel.org
Cc: zeil@yandex-team.ru
Subject: [PATCH] ipv6: enable net.ipv6.route sysctls in network namespace
Date: Thu,  9 Sep 2021 14:14:09 +0300	[thread overview]
Message-ID: <20210909111409.14425-1-wwfq@yandex-team.ru> (raw)

We want to increase route cache size in network namespace
created with user namespace. Currently ipv6 route settings
are disabled for non-initial network namespaces.
Since routes are per network namespace it is safe
to enable these sysctls.

Signed-off-by: Alexander Kuznetsov <wwfq@yandex-team.ru>
Acked-by: Dmitry Yakunin <zeil@yandex-team.ru>
---
 net/ipv6/route.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index b6ddf23..de85e3b 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -6415,10 +6415,6 @@ struct ctl_table * __net_init ipv6_route_sysctl_init(struct net *net)
 		table[8].data = &net->ipv6.sysctl.ip6_rt_min_advmss;
 		table[9].data = &net->ipv6.sysctl.ip6_rt_gc_min_interval;
 		table[10].data = &net->ipv6.sysctl.skip_notify_on_dev_down;
-
-		/* Don't export sysctls to unprivileged users */
-		if (net->user_ns != &init_user_ns)
-			table[0].procname = NULL;
 	}
 
 	return table;
-- 
2.7.4


             reply	other threads:[~2021-09-09 11:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 11:14 Alexander Kuznetsov [this message]
2021-09-21  6:22 [PATCH] ipv6: enable net.ipv6.route sysctls in network namespace Alexander Kuznetsov
2021-09-21 13:09 ` Jakub Kicinski
2021-09-21 15:32   ` Florian Westphal
2021-09-25 15:25     ` David Ahern
2021-09-30  8:44   ` Alexander Al. Kuznetsov
2021-09-30 14:59 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210909111409.14425-1-wwfq@yandex-team.ru \
    --to=wwfq@yandex-team.ru \
    --cc=netdev@vger.kernel.org \
    --cc=zeil@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.