From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BA7BC433EF for ; Thu, 9 Sep 2021 12:12:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8026560FE3 for ; Thu, 9 Sep 2021 12:12:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243562AbhIIMNj (ORCPT ); Thu, 9 Sep 2021 08:13:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:47186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345229AbhIIMHF (ORCPT ); Thu, 9 Sep 2021 08:07:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 23CCE61980; Thu, 9 Sep 2021 11:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631188059; bh=CCqSZBrjoqhbOd+VZEKVATTkTGbF+yGwyIWlC/YNMf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XxlsHaFbBfEsbA2PyvSjho02a4es2g9zvClbejdIGYmffJ+i6kuuWvx0omqtHj4pY E7na6+/lvtlZgsF3D/5KsFRtIO7ReiwNJ9Axwo+He1nwtCeGzT6dnVEC6c7nGheIr2 5TpKlp6HvzMPBW02cYx2fFBQzNAhk78UVvFzMoF9KvbzDCVF6C9VnouLKWnQjc1/wH 6MAQ9zFL93kMj0QhVg4uL9+lMHkSltZElSrrkscUq+x1kjv8X5cUVYOosxxx330QaF M+vuF/E0dpIZq6i7lSGyic37PegmPuiGmcjtS6bzdbB9Fq9E3VB7IUvUQHZOraBELp 2sqmYcKWoHwGg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Louis Peens , Simon Horman , "David S . Miller" , Sasha Levin , oss-drivers@corigine.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.13 049/219] nfp: fix return statement in nfp_net_parse_meta() Date: Thu, 9 Sep 2021 07:43:45 -0400 Message-Id: <20210909114635.143983-49-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210909114635.143983-1-sashal@kernel.org> References: <20210909114635.143983-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Niklas Söderlund [ Upstream commit 4431531c482a2c05126caaa9fcc5053a4a5c495b ] The return type of the function is bool and while NULL do evaluate to false it's not very nice, fix this by explicitly returning false. There is no functional change. Signed-off-by: Niklas Söderlund Signed-off-by: Louis Peens Signed-off-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index eeb30680b4dc..0a0a26376bea 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -1697,7 +1697,7 @@ nfp_net_parse_meta(struct net_device *netdev, struct nfp_meta_parsed *meta, case NFP_NET_META_RESYNC_INFO: if (nfp_net_tls_rx_resync_req(netdev, data, pkt, pkt_len)) - return NULL; + return false; data += sizeof(struct nfp_net_tls_resync_req); break; default: -- 2.30.2