From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 953D73FE1 for ; Thu, 9 Sep 2021 11:52:03 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 89C0561264; Thu, 9 Sep 2021 11:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631188323; bh=r/XfC9YknuEJTwDT2ObfBukG4ljdVEksqJ+CNLioO00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CkaMjinvtOSPLjZFyPE8rhAZPx/IBkfFtxr6h/SNG4LFb2rxeWrI694l24XT49mMY n8D1pI+/Z8Ojw3BrgAMtHn7KCx02/BOy+UM5LSTdQvTjAHbARVNlWvQlfkuDQBdDcy bf1CEqq3niZJFiBOV6qa44wJr+eyqpWP9s0zgAiH92XUhhKwSixp4exN2BnxTmYv+E 9OMdjRXMf7pE1kkTOTjYrjr0ua4h20QuPCaVaMhyyh+9tUbDiQfCFn465bo1kNLAm7 q3zloYDPvElgE4VQm6NPD7E7lEVS224VNxnmfN6fxN8Bw67Ijb0ajxQnqSj84wn/wH +cILkRJWyryJQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dinghao Liu , Andy Shevchenko , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH AUTOSEL 5.10 035/176] media: atomisp: Fix runtime PM imbalance in atomisp_pci_probe Date: Thu, 9 Sep 2021 07:48:57 -0400 Message-Id: <20210909115118.146181-35-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210909115118.146181-1-sashal@kernel.org> References: <20210909115118.146181-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Dinghao Liu [ Upstream commit 672fe1cf145ab9978c62eb827d6a16aa6b63994b ] When hmm_pool_register() fails, a pairing PM usage counter increment is needed to keep the counter balanced. It's the same for the following error paths. Link: https://lore.kernel.org/linux-media/20210408081850.24278-1-dinghao.liu@zju.edu.cn Signed-off-by: Dinghao Liu Acked-by: Andy Shevchenko Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c index 0295e2e32d79..02f774ed80c8 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -1815,6 +1815,7 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i hmm_cleanup(); hmm_pool_unregister(HMM_POOL_TYPE_RESERVED); hmm_pool_fail: + pm_runtime_get_noresume(&pdev->dev); destroy_workqueue(isp->wdt_work_queue); wdt_work_queue_fail: atomisp_acc_cleanup(isp); -- 2.30.2