From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29649C433F5 for ; Thu, 9 Sep 2021 13:45:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 057946120F for ; Thu, 9 Sep 2021 13:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354563AbhIINqX (ORCPT ); Thu, 9 Sep 2021 09:46:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:57774 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356442AbhIIMzM (ORCPT ); Thu, 9 Sep 2021 08:55:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 94DE16326D; Thu, 9 Sep 2021 11:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631188681; bh=IG4WzuU9ZzfY8NhFaGUxR7321fnYT+WG2xobM7X31RA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kqX9BVXnhDDKXC7uNbH3BNB/87GILT7b20kU/lU2sKy7mSuXU8hEYrAEH4JT8ePCP mlQjTLVEbONas9uNsAB/9nqzbsRgZ/p2myEjxTsEsLYGMjsBVoMxerOIgXPpixQNyM v9oY28TJXJPCSzC+jS/Wog++txLOKkd0hMWs7REeE+L8MZyfNWzGNUMrIA2kBSnuyY MKow14XflJ+Sb0TyThSgj/6f15UtlRzgKRG2GN3/N1nNTMdqfARq7vdbEAPU7gbXFo s2BgtAh3UwG9oDjAZBY+4FPbjfzcr0sS8lvctGgqxsmnknDCaBA9OpjmqrYo7YN6Ix AzsQtE1PAAc3A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Jordy Zomer , Sasha Levin , linux-serial@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 28/74] serial: 8250_pci: make setup_port() parameters explicitly unsigned Date: Thu, 9 Sep 2021 07:56:40 -0400 Message-Id: <20210909115726.149004-28-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210909115726.149004-1-sashal@kernel.org> References: <20210909115726.149004-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman [ Upstream commit 3a96e97ab4e835078e6f27b7e1c0947814df3841 ] The bar and offset parameters to setup_port() are used in pointer math, and while it would be very difficult to get them to wrap as a negative number, just be "safe" and make them unsigned so that static checkers do not trip over them unintentionally. Cc: Jiri Slaby Reported-by: Jordy Zomer Link: https://lore.kernel.org/r/20210726130717.2052096-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/8250/8250_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index 725e5842b8ac..f54c18e4ae90 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c @@ -70,7 +70,7 @@ static void moan_device(const char *str, struct pci_dev *dev) static int setup_port(struct serial_private *priv, struct uart_8250_port *port, - int bar, int offset, int regshift) + u8 bar, unsigned int offset, int regshift) { struct pci_dev *dev = priv->dev; -- 2.30.2