From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34126C433EF for ; Thu, 9 Sep 2021 15:01:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ABE160F24 for ; Thu, 9 Sep 2021 15:01:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239522AbhIIPDD (ORCPT ); Thu, 9 Sep 2021 11:03:03 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:41744 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236545AbhIIPC6 (ORCPT ); Thu, 9 Sep 2021 11:02:58 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D088922334; Thu, 9 Sep 2021 15:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631199707; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7YDXHPzZgNhxK+JqlG9HXkSUyEV8IJc2b4TuXsz5yH0=; b=kRRhZmQ3mqVSek9+0O4cHQ+rYzMVNOxaruVMvb1v75PP9GurRgzsXJuC+mknsmdvE8YkvW Zb3LnQ3XGdB56U8spoEpjD4a2QLYTxaQiq0o27yIjFzfZdz3biJUxxSO3DHXksyCYs62PA HwqjlBP1xSO36QTsp9qKWvwqz6leJmo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B427213C53; Thu, 9 Sep 2021 15:01:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id F1QlK9shOmFYSAAAMHmgww (envelope-from ); Thu, 09 Sep 2021 15:01:47 +0000 Date: Thu, 9 Sep 2021 17:01:46 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: brookxu Cc: Tejun Heo , lizefan.x@bytedance.com, hannes@cmpxchg.org, vipinsh@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures Message-ID: <20210909150146.GA18171@blackbody.suse.cz> References: <20210824164423.GA11859@blackbody.suse.cz> <4ed67493-e595-e002-69f9-1f53662ba189@gmail.com> <20210826112954.GD4520@blackbody.suse.cz> <49057879-92a9-958a-ac30-057ceabd1b7f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49057879-92a9-958a-ac30-057ceabd1b7f@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Wed, Sep 08, 2021 at 01:29:18PM +0800, brookxu wrote: > I have sentout misc_cgroup events and events.local related patches. > I want to make corresponding changes to pids cgroup by the way. Do > you think it is ok? The pids controller is longer out there, so some changes should be more careful (e.g. I wouldn't drop the log message). Also, you can base it on [1] (there should be just missing the .local/hierarchical event files separation). HTH, Michal [1] https://lore.kernel.org/lkml/20200205134426.10570-1-mkoutny@suse.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal =?iso-8859-1?Q?Koutn=FD?= Subject: Re: [PATCH v2] misc_cgroup: use a counter to count the number of failures Date: Thu, 9 Sep 2021 17:01:46 +0200 Message-ID: <20210909150146.GA18171@blackbody.suse.cz> References: <20210824164423.GA11859@blackbody.suse.cz> <4ed67493-e595-e002-69f9-1f53662ba189@gmail.com> <20210826112954.GD4520@blackbody.suse.cz> <49057879-92a9-958a-ac30-057ceabd1b7f@gmail.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631199707; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7YDXHPzZgNhxK+JqlG9HXkSUyEV8IJc2b4TuXsz5yH0=; b=kRRhZmQ3mqVSek9+0O4cHQ+rYzMVNOxaruVMvb1v75PP9GurRgzsXJuC+mknsmdvE8YkvW Zb3LnQ3XGdB56U8spoEpjD4a2QLYTxaQiq0o27yIjFzfZdz3biJUxxSO3DHXksyCYs62PA HwqjlBP1xSO36QTsp9qKWvwqz6leJmo= Content-Disposition: inline In-Reply-To: <49057879-92a9-958a-ac30-057ceabd1b7f-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: brookxu Cc: Tejun Heo , lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hi. On Wed, Sep 08, 2021 at 01:29:18PM +0800, brookxu wrote: > I have sentout misc_cgroup events and events.local related patches. > I want to make corresponding changes to pids cgroup by the way. Do > you think it is ok? The pids controller is longer out there, so some changes should be more careful (e.g. I wouldn't drop the log message). Also, you can base it on [1] (there should be just missing the .local/hierarchical event files separation). HTH, Michal [1] https://lore.kernel.org/lkml/20200205134426.10570-1-mkoutny-IBi9RG/b67k@public.gmane.org/