Re: [PATCH net] net: stmmac: fix system hang caused by eee_ctrl_timer during suspend/resume

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3332 bytes --]

Hi Joakim,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Joakim-Zhang/net-stmmac-fix-system-hang-caused-by-eee_ctrl_timer-during-suspend-resume/20210908-154605
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 626bf91a292e2035af5b9d9cce35c5c138dfe06d
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2336c3b3edee28ce2cbe0ca5f3a4e2cd40247c61
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Joakim-Zhang/net-stmmac-fix-system-hang-caused-by-eee_ctrl_timer-during-suspend-resume/20210908-154605
        git checkout 2336c3b3edee28ce2cbe0ca5f3a4e2cd40247c61
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:796:12: error: 'stmmac_pltfr_noirq_resume' defined but not used [-Werror=unused-function]
     796 | static int stmmac_pltfr_noirq_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:775:12: error: 'stmmac_pltfr_noirq_suspend' defined but not used [-Werror=unused-function]
     775 | static int stmmac_pltfr_noirq_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/stmmac_pltfr_noirq_resume +796 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

   774	
 > 775	static int stmmac_pltfr_noirq_suspend(struct device *dev)
   776	{
   777		struct net_device *ndev = dev_get_drvdata(dev);
   778		struct stmmac_priv *priv = netdev_priv(ndev);
   779		int ret;
   780	
   781		if (!netif_running(ndev))
   782			return 0;
   783	
   784		if (!device_may_wakeup(priv->device) || !priv->plat->pmt) {
   785			/* Disable clock in case of PWM is off */
   786			clk_disable_unprepare(priv->plat->clk_ptp_ref);
   787	
   788			ret = pm_runtime_force_suspend(dev);
   789			if (ret)
   790				return ret;
   791		}
   792	
   793		return 0;
   794	}
   795	
 > 796	static int stmmac_pltfr_noirq_resume(struct device *dev)
   797	{
   798		struct net_device *ndev = dev_get_drvdata(dev);
   799		struct stmmac_priv *priv = netdev_priv(ndev);
   800		int ret;
   801	
   802		if (!netif_running(ndev))
   803			return 0;
   804	
   805		if (!device_may_wakeup(priv->device) || !priv->plat->pmt) {
   806			/* enable the clk previously disabled */
   807			ret = pm_runtime_force_resume(dev);
   808			if (ret)
   809				return ret;
   810	
   811			clk_prepare_enable(priv->plat->clk_ptp_ref);
   812		}
   813	
   814		return 0;
   815	}
   816	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 60616 bytes --]