From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F10E8C433EF for ; Thu, 9 Sep 2021 20:23:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 443C06113E for ; Thu, 9 Sep 2021 20:23:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 443C06113E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 43FE383513; Thu, 9 Sep 2021 22:23:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="WMUwJmJK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F2A2B8351A; Thu, 9 Sep 2021 22:23:15 +0200 (CEST) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2BCC482D7E for ; Thu, 9 Sep 2021 22:23:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id x5so2616466qtq.13 for ; Thu, 09 Sep 2021 13:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kzyczHZijXZcyPJFR+EBTxwOroUSL53QcgAivH5bPiI=; b=WMUwJmJK12pYDc6fVo49u5lT48PpzRbgPq37BXeMY6AJ2Gzoc4b4EEhojmhlIjHbz2 tps/OYueEw1NwfJW6TdLlm5Uyx5zW01k8yHeZWJUAyDhN4hA125wmNiLpHOwUAg3Xhyj +MQeukvIxRtDGD78sQwWDyESLnCBQF6LnW2zw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kzyczHZijXZcyPJFR+EBTxwOroUSL53QcgAivH5bPiI=; b=rHqxDim6MViYviqcmE55WhoHEYZcDC8FP1N9/Gb/9YPlzWfW/wFmswtIJMfznHcRlE Kc2dSTgCd9wC7e6KT8uKwbFkLndeTCZTATyVtW1b/JRDEYPjonXLFqaqG42EgtEv+QsA yJOuxOrowwD7o6y1LOVXcfW43FJtz3XhcbtqbH1zBiE0+BBXmW99Yf+Q2AGPX8qHd7k9 tMoLMqq+1mqGEvRyrYiRm+HlKitcfXHho5wtaNbtLGGBrM6hr3R2HdqIfO86mPirC98N wzRD1ST2Ldd0GT2426cRW9XRUd9Www1JJ1I0LgzOsN4YJHv+M55hyR5x01h+mc8Pf5Xx NWDA== X-Gm-Message-State: AOAM531DZWZP3Ooz8nwWg14FIKKxsuF/ZVP7z72GjWHUj2xw8Sb52vBz 0CfkoXM72Ie0+LivZECip0CLeA== X-Google-Smtp-Source: ABdhPJxpLWHQgU5BsfLQxeyh5Jr856LGpkDQ9CBngvunpnywt2oetdl2n5PEXwkUhK/jLdbt8qSfbw== X-Received: by 2002:ac8:7ef6:: with SMTP id r22mr4629718qtc.158.1631218990824; Thu, 09 Sep 2021 13:23:10 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f91e-f867-d1bc-397d.res6.spectrum.com. [2603:6081:7b01:cbda:f91e:f867:d1bc:397d]) by smtp.gmail.com with ESMTPSA id l13sm2121968qkp.97.2021.09.09.13.23.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Sep 2021 13:23:10 -0700 (PDT) Date: Thu, 9 Sep 2021 16:23:08 -0400 From: Tom Rini To: Mark Kettenis Cc: Simon Glass , xypron.glpk@gmx.de, u-boot@lists.denx.de, ilias.apalodimas@linaro.org, bmeng.cn@gmail.com, christian.melki@t2data.com, agraf@csgraf.de Subject: Re: [PATCH 11/35] RFC: efi: Drop code that doesn't work with driver model Message-ID: <20210909202308.GG12964@bill-the-cat> References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.11.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <56144ca004c70ce9@bloch.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9EA/m5/vJYu0Xr+b" Content-Disposition: inline In-Reply-To: <56144ca004c70ce9@bloch.sibelius.xs4all.nl> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --9EA/m5/vJYu0Xr+b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 09, 2021 at 10:15:44PM +0200, Mark Kettenis wrote: > > From: Simon Glass > > Date: Thu, 9 Sep 2021 13:57:39 -0600 > >=20 > > Hi Heinrich, > >=20 > > On Thu, 9 Sept 2021 at 03:26, Heinrich Schuchardt = wrote: > > > > > > > > > > > > On 9/9/21 10:57 AM, Simon Glass wrote: > > > > Hi Heinrich, > > > > > > > > On Wed, 8 Sept 2021 at 11:44, Heinrich Schuchardt wrote: > > > >> > > > >> > > > >> > > > >> On 9/8/21 3:33 PM, Simon Glass wrote: > > > >>> This code should never have been added as it builds a new feature= on top > > > >>> of legacy code. Drop it and add a dependency on BLK for this feat= ure. > > > >>> > > > >>> Boards which want EFI_LOADER should migrate to driver model first. > > > >>> > > > >>> Signed-off-by: Simon Glass > > > >> > > > >> This patch is not related to the rest of the series and the code h= as a > > > >> different maintainer. > > > >> > > > >> So, please, separate it from the series. > > > > > > > > Who is the maintainer? > > > > > > Until 623b3a57976 ("efi_selftest: provide an EFI selftest application= ") > > > there was no official maintainer for lib/efi/ but you were the main > > > contributor. > > > > > > But with that patch directory lib/efi/ was assigned to EFI PAYLOAD. > > > > > > I am happy if you would continue to care about U-Boot on EFI. > >=20 > > OK. > >=20 > > > > > > > > > > > I need this patch for this series to work. You can still review thi= ngs > > > > for other maintainers and in this case it is common for one maintai= ner > > > > to pick up the series once the others are happy. > > > > > > The direction of this patch is completely correct. > > > > > > There are some things that will have to be changed, e.g we should not > > > require CONFIG_DM_ETH=3Dy. I will work on reviewing this patch in det= ail. > >=20 > > OK, but why not require DM_ETH? The deadline passed a year ago. >=20 > Because we support boards without network ports? Boards without networking should disable the relevant code, and as needed the EFI code return the proper error code? --=20 Tom --9EA/m5/vJYu0Xr+b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGyBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE6bSsACgkQFHw5/5Y0 tyy5FAv4oxDhmUEE0Noyz+dnqp7pZOvNnYbXefAfQdpcbqb+FVEAThf1EAZ7AqGG ut5+EeCWpD6GeETuXP9Yk66iROFjfg3/YmpFRJG7yeUZZnLX0oh3UiXskC/UK6lw 4Mukh+my9m1WaQKXNkZSmNQ2gDzfzxK7pRB9tRRqHP5ZXF0LxcZfdwezX00v3V3g K6K4sXahEQoZwG78phtHk7u8Ak7NeQj7SMwe0egQJyyX23H4m2fRYjs8NaYijuJW pnbK3wyouKMd/wxTQs/OziF9n3FyP+7+8eOh2aaRAULz/nDyAGld5K9iwNvtmun3 UhzCkdfqIrdvzJ8XUp0o0O/4gT5gXczejDEUd2RDIHl3EoZo8XFYBtNlRNRxZmBZ eQuyU9mZkHSHi5hJthKoGSbKLDnlrAdazRX2/ansQg6mropqv9/W/QX5RFQIr0fn cpnIYYxtGGFaj+Syw0K76C5jTh4dKo95ICJxvQ5z30LjJPgorl/QLU3mP677DG2h d8J4MwU= =O2JK -----END PGP SIGNATURE----- --9EA/m5/vJYu0Xr+b--