From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4336CC433EF for ; Thu, 9 Sep 2021 22:06:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FE8360F92 for ; Thu, 9 Sep 2021 22:06:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4FE8360F92 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 674CC811F7; Fri, 10 Sep 2021 00:06:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FzX49Z8i"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 873AC83483; Fri, 10 Sep 2021 00:06:37 +0200 (CEST) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 222AF80397 for ; Fri, 10 Sep 2021 00:06:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72d.google.com with SMTP id y144so3649490qkb.6 for ; Thu, 09 Sep 2021 15:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0o71awXm5XHrYXaft3FxwK6HS+ZI4PNJBRXoIJmp4Js=; b=FzX49Z8ijPLf5rPzLZ+5TFvXl8mJ52M9Jl1puY0D4WzgmX/O9SuVlmQYBmaqPMb3lD iWEx6BWpY5CMNpmYcQMc0EjTxUS+6sz16bbFK+XtornFei/6rIVsak7u8oata5jURimD 09POENlJXTl1Tdg9ExrpSaQJscBy4p/incb5E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0o71awXm5XHrYXaft3FxwK6HS+ZI4PNJBRXoIJmp4Js=; b=jFLgz6VY1KryeqfPSmNVNmFAokBh21rXE/K+EKoE2hf+cd4eqhMkbsWIQTpRNH9lUg dMUuCEHzvBOe/x7CtJVeAan2WvrTD1tTG88NkAfQ4cTa0/QsowQMhy8jgJvscTBx+DOU K6rmftLWID1ACdm0pHmZ1+C9iJMT0fBaB/WuzW7FmPqHYMiHEnW3q3O7Pk2JbjDD1Plw HviMLvbzzujzs5h/XCRc1WpNXgodjy+4Lh/nYKPlUv/RF2TQ1R1YSxhmsj6ckiDTjWUj /ejPAfsDlK5sp4i4eqrx97KjIJP6xRIW2qs2WGIVqvqxH5JKQ5t8IVyREi29srAp+0ho vp+Q== X-Gm-Message-State: AOAM531xzdMNvwlOpvO8QI6tLIw2lPsMXRZwEg8kCWnblqr+Kueq9hxA m7s1yvCh+aiB3amrDV1EtObENQ== X-Google-Smtp-Source: ABdhPJzNm2WKFI7rbu5gkc1aFIUhP00jyaVFmJekFVhOqz8RgW3eDKDWcrlwRc2r/UIpEerQJKlA8Q== X-Received: by 2002:a05:620a:228a:: with SMTP id o10mr4864883qkh.342.1631225192918; Thu, 09 Sep 2021 15:06:32 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f91e-f867-d1bc-397d.res6.spectrum.com. [2603:6081:7b01:cbda:f91e:f867:d1bc:397d]) by smtp.gmail.com with ESMTPSA id 69sm2525645qke.55.2021.09.09.15.06.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Sep 2021 15:06:32 -0700 (PDT) Date: Thu, 9 Sep 2021 18:06:30 -0400 From: Tom Rini To: Mark Kettenis Cc: sjg@chromium.org, xypron.glpk@gmx.de, u-boot@lists.denx.de, ilias.apalodimas@linaro.org, bmeng.cn@gmail.com, christian.melki@t2data.com, agraf@csgraf.de Subject: Re: [PATCH 11/35] RFC: efi: Drop code that doesn't work with driver model Message-ID: <20210909220630.GI12964@bill-the-cat> References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.11.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <56144ca004c70ce9@bloch.sibelius.xs4all.nl> <20210909202308.GG12964@bill-the-cat> <56144d0e41952059@bloch.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p7Jy7isCirGQ9JA8" Content-Disposition: inline In-Reply-To: <56144d0e41952059@bloch.sibelius.xs4all.nl> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --p7Jy7isCirGQ9JA8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 09, 2021 at 11:45:08PM +0200, Mark Kettenis wrote: > > Date: Thu, 9 Sep 2021 16:23:08 -0400 > > From: Tom Rini > >=20 > > On Thu, Sep 09, 2021 at 10:15:44PM +0200, Mark Kettenis wrote: > > > > From: Simon Glass > > > > Date: Thu, 9 Sep 2021 13:57:39 -0600 > > > >=20 > > > > Hi Heinrich, > > > >=20 > > > > On Thu, 9 Sept 2021 at 03:26, Heinrich Schuchardt wrote: > > > > > > > > > > > > > > > > > > > > On 9/9/21 10:57 AM, Simon Glass wrote: > > > > > > Hi Heinrich, > > > > > > > > > > > > On Wed, 8 Sept 2021 at 11:44, Heinrich Schuchardt wrote: > > > > > >> > > > > > >> > > > > > >> > > > > > >> On 9/8/21 3:33 PM, Simon Glass wrote: > > > > > >>> This code should never have been added as it builds a new fea= ture on top > > > > > >>> of legacy code. Drop it and add a dependency on BLK for this = feature. > > > > > >>> > > > > > >>> Boards which want EFI_LOADER should migrate to driver model f= irst. > > > > > >>> > > > > > >>> Signed-off-by: Simon Glass > > > > > >> > > > > > >> This patch is not related to the rest of the series and the co= de has a > > > > > >> different maintainer. > > > > > >> > > > > > >> So, please, separate it from the series. > > > > > > > > > > > > Who is the maintainer? > > > > > > > > > > Until 623b3a57976 ("efi_selftest: provide an EFI selftest applica= tion") > > > > > there was no official maintainer for lib/efi/ but you were the ma= in > > > > > contributor. > > > > > > > > > > But with that patch directory lib/efi/ was assigned to EFI PAYLOA= D. > > > > > > > > > > I am happy if you would continue to care about U-Boot on EFI. > > > >=20 > > > > OK. > > > >=20 > > > > > > > > > > > > > > > > > I need this patch for this series to work. You can still review= things > > > > > > for other maintainers and in this case it is common for one mai= ntainer > > > > > > to pick up the series once the others are happy. > > > > > > > > > > The direction of this patch is completely correct. > > > > > > > > > > There are some things that will have to be changed, e.g we should= not > > > > > require CONFIG_DM_ETH=3Dy. I will work on reviewing this patch in= detail. > > > >=20 > > > > OK, but why not require DM_ETH? The deadline passed a year ago. > > >=20 > > > Because we support boards without network ports? > >=20 > > Boards without networking should disable the relevant code, and as > > needed the EFI code return the proper error code? >=20 > Yes, but it means you can't make DM_ETH a (hard) requirement for > EFI_LOADER support. What I mean is that it should still be possible > to build U-Boot with EFI_LOADER support even if DM_EFI isn't set for a > board. It should just result in a UEFI implementation with no network > support instead. Yes, agreed. I was just trying to say that in the context of what DM code EFI_LOADER can demand, the deadline for BLK has passed and everything that didn't support it has been removed, so that's a good requirement and area of code to clean up as needed. But DM_ETH-or-bust isn't there, yet. --=20 Tom --p7Jy7isCirGQ9JA8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE6hWIACgkQFHw5/5Y0 tyybZgv+IN6bZ+k4gGszD0mjcMKmucrYCmvf/sIOWOvwQ6hF2dP03Ly5krTvbcCK aseRCg8QxI4rlAuoRz+/wcFjt9IEm+QU4u8N+1G+MuKDKgEIO6k8Qh+SxciPIcVf ESRa3wLZ+kbFMn4Blw4Bp9GZfdereoEES5V9rIX9HIAw+1wUBiWlh3B/jeYqoNsD CxZWQxNaCAxvWfxDFgD5ZKp1V4mt2Abqu6N+MsNVBCc0doA0esnwGyD+BmL1amWs ChtKCtPDc55obb4MYdB/Zx5x3SWTgHaYimtBGsNYxgeqEeacwAd6meJPVEuq7GTA CWIom5l4lpxUIRQg/4qHPrvmXDef6ngMTri/xTVw8Jtr1wR8FuUzzPXlanrJq5E+ 8cubpU1aDM+Vi8bTZC+sCAV0tPoRPuX35KEdSYoivSSS+HME2QdTLNM1AvWbjqm0 8vWoGxSyk67whIjDTSi6DG56JbdXfBZ5yt7bSO8eq8SdwGIOct6V2RaGRsj6NkEp MB7dJ12O =rgQb -----END PGP SIGNATURE----- --p7Jy7isCirGQ9JA8--